Received: by 10.213.65.68 with SMTP id h4csp1767754imn; Mon, 19 Mar 2018 12:42:49 -0700 (PDT) X-Google-Smtp-Source: AG47ELsvKq4DC3FTjW4+Qe903zNEdaAHrx5+560KHlwOy6BkGyaGFQTgE8ASxcAdrZDi4qfY2uDZ X-Received: by 10.99.64.131 with SMTP id n125mr4012069pga.303.1521488569892; Mon, 19 Mar 2018 12:42:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521488569; cv=none; d=google.com; s=arc-20160816; b=Ak7lEUMDNXHBFTaJx5AFFbRJl9SIcEKH5Vh52YlPzKiANAzUlLmFMDUS772HXqfNIp UqrESM71jP/SgNvlJQYkYAfqys1dM/8dY9juSD1s02Rn8pA6y5ckmCQVmAi3GIOdiNZQ i9YaeygLmoEgcyahDxx7PcMwyrgJtiisn6Thk4lne5EiczPVtmbkoEA89eJPudBElL5h 246P7UcdrgZOVURiPWHCIrWn7EvcfO9R9xgGGa4hYlDlDgXp+NKD9UJo17zwItnzuLWw OLfmN5bfRvN67R8ii50mxsB9bPsGwyWkPNhhXSJPg2n3iUnJp2hGfDD9Qebc4IgH947p yfSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=KdzplP90BZMDQWxze2OC+nVu5Z7niamSbe2TfxfYS9A=; b=gqVNLR4XsGZrFTirydAHX2XQriqjiFO5eO2+VlkdTkNfe8OzxlfEtfDuFJIScidqsP YpGvNI9Q0HvOoWK9DNYhyRTLlrxEkddFh+WWuaCdjsXmfBR0xAreWvub85CuOmbgbyjv hvhE4negFPtlE1DbgFYOsfaDlowZoyIUEXTXORB25Y47/CmDZIVbceGjbUtc+fUZwDlP 6F6/wlCVqTQutDcSh7q4GzLB5r7pQVQJV7vU0HV3c7pTVjAia5pcPvspdPfWgMBug4s2 DJkE1rtM+FpXr+8Ou+TL7tjvsNaxAK4ekU8JcILxlNL9Gh27knIl0hfS9KYJMMAMOxNs c4Jg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p3si434902pfh.84.2018.03.19.12.42.35; Mon, 19 Mar 2018 12:42:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969647AbeCSTky (ORCPT + 99 others); Mon, 19 Mar 2018 15:40:54 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48292 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S969489AbeCSSVw (ORCPT ); Mon, 19 Mar 2018 14:21:52 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id A69EF1288; Mon, 19 Mar 2018 18:21:51 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Felix Manlunas , Satanand Burla , "David S. Miller" , Sasha Levin Subject: [PATCH 4.9 089/241] vxlan: vxlan dev should inherit lowerdevs gso_max_size Date: Mon, 19 Mar 2018 19:05:54 +0100 Message-Id: <20180319180754.891352785@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180319180751.172155436@linuxfoundation.org> References: <20180319180751.172155436@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Felix Manlunas [ Upstream commit d6acfeb17d030bb3907e77c048b0e7783ad8e5a9 ] vxlan dev currently ignores lowerdev's gso_max_size, which adversely affects TSO performance of liquidio if it's the lowerdev. Egress TCP packets' skb->len often exceed liquidio's advertised gso_max_size. This may happen on other NIC drivers. Fix it by assigning lowerdev's gso_max_size to that of vxlan dev. Might as well do likewise for gso_max_segs. Single flow TSO throughput of liquidio as lowerdev (using iperf3): Before the patch: 139 Mbps After the patch : 8.68 Gbps Percent increase: 6,144 % Signed-off-by: Felix Manlunas Signed-off-by: Satanand Burla Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/vxlan.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -2912,6 +2912,11 @@ static int vxlan_dev_configure(struct ne return -EINVAL; } + if (lowerdev) { + dev->gso_max_size = lowerdev->gso_max_size; + dev->gso_max_segs = lowerdev->gso_max_segs; + } + if (conf->mtu) { err = __vxlan_change_mtu(dev, lowerdev, dst, conf->mtu, false); if (err)