Received: by 10.213.65.68 with SMTP id h4csp1775985imn; Mon, 19 Mar 2018 12:58:39 -0700 (PDT) X-Google-Smtp-Source: AG47ELu8plphc6vf+anQ+5mZlq03ncZufnt3zyjQJzZ9skXlakCZHPmwe3/XxMItqdgKjj+vijrE X-Received: by 10.98.51.129 with SMTP id z123mr11318793pfz.132.1521489519851; Mon, 19 Mar 2018 12:58:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521489519; cv=none; d=google.com; s=arc-20160816; b=CSkPLS8RXmO+8+Eey/MpivThFLhUFkQlBDKPmalmhEBJWkbIY+iRCR5WWPaULkID1a 7IMTEArzY4XK3LSQ6IJKdL9FKDmFAGU17+jWCPfUkpvatFdW5KM9zQyg+Lv9QHE4qTpr WBCSOBczDJm2S9bvIdwfGTB8dwRNKnL/5bxlLf3EbW7kK1jap03Ac1WY810MknF60C8w Onvn11R3Wybpi+jYLhmX9LJFO6cInrJWaEjaGzxlVMtGCDrG6zNIZzS/el/DpxzP4XED AdYpXHdK2IRjuaizMRiqYnWh6owLFL7zt0Bss3kn5QlTO4ry5SPhLV3ZVI36HcZ297zY p2nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=NdBapFR/sy32crxuP8x/fJq017PljFF+7mLcu17HP1Q=; b=x4nwKd2xrGaYIIoEmIkZSXpwJqs8DTvovmrJuc6p8jpZVeCGrgq0ExhmThBn1QpF3F Lz2rKivG6cLMxUBqSHhZroSRarVIOwVU6vcgFr4/wANnRA7J2sDx8m9XHSCR4haRV/lw +rDI2yAeJgjipPON9/Vzq83ibBv1XCmxbIJeaxLz3b0yQydn4e2Ee383MRbBdpbHVQOR vATeK3geT4lS6DCioR8nCcFqeeYjOsOL4BBgF5ZUEppKFBjeHbTd/wnuwzf8wE4BqObT XHLaQte81nd5TlneRrv5StbTRZR4+dwZQw2oYGlFYHZ6QOH03ZCxJvn/hKK6GBNkMgpC XETw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y5si429451pgc.820.2018.03.19.12.57.56; Mon, 19 Mar 2018 12:58:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S971004AbeCSTy0 (ORCPT + 99 others); Mon, 19 Mar 2018 15:54:26 -0400 Received: from verein.lst.de ([213.95.11.211]:32973 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968513AbeCSTyW (ORCPT ); Mon, 19 Mar 2018 15:54:22 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 0B6C26F233; Mon, 19 Mar 2018 20:54:21 +0100 (CET) Date: Mon, 19 Mar 2018 20:54:21 +0100 From: Christoph Hellwig To: Jonas Rabenstein Cc: Scott Bauer , Jonathan Derrick , Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v2 02/11] block: sed-opal: unify space check in add_token_* Message-ID: <20180319195421.GD3380@lst.de> References: <955fd10854ed68f6925612ae73cdaa4637cfb5e4.1521482295.git.jonas.rabenstein@studium.uni-erlangen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <955fd10854ed68f6925612ae73cdaa4637cfb5e4.1521482295.git.jonas.rabenstein@studium.uni-erlangen.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 19, 2018 at 07:36:44PM +0100, Jonas Rabenstein wrote: > All add_token_* functions have a common set of conditions that have to > be checked. Use a common function for those checks in order to avoid > different behaviour as well as code duplication. > > Signed-off-by: Jonas Rabenstein Looks good, Reviewed-by: Christoph Hellwig