Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Sasha Levin <Alexander.Levin@microsoft.com>
To:     Paolo Bonzini <pbonzini@redhat.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH AUTOSEL for 4.14 12/67] KVM: x86: add support for
 emulating UMIP
Thread-Topic: [PATCH AUTOSEL for 4.14 12/67] KVM: x86: add support for
 emulating UMIP
Thread-Index: AQHTtpn6RxGhJxHWy02eLbnawN2M7MGVFwZS4kKoBwA=
Date:   Mon, 19 Mar 2018 15:22:47 +0000
Message-ID: <20180319152244.ekaloppjdbtg4gjo@sasha-lappy>
References: <20180308045641.7814-1-alexander.levin@microsoft.com>
 <20180308045641.7814-12-alexander.levin@microsoft.com>
 <1211566882.5943983.1520491599636.JavaMail.zimbra@redhat.com>
In-Reply-To: <1211566882.5943983.1520491599636.JavaMail.zimbra@redhat.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-ID: <05587E6C657F0B4AB75B5650B05F95C8@namprd21.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e25d9ed6-26fe-43a0-674a-08d58dad453b
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2018 15:22:47.1371
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1048
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 08, 2018 at 01:46:39AM -0500, Paolo Bonzini wrote:
>
>
>----- Original Message -----
>> From: "Sasha Levin" <Alexander.Levin@microsoft.com>
>> To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
>> Cc: "Paolo Bonzini" <pbonzini@redhat.com>, "Sasha Levin" <Alexander.Levi=
n@microsoft.com>
>> Sent: Thursday, March 8, 2018 5:57:36 AM
>> Subject: [PATCH AUTOSEL for 4.14 12/67] KVM: x86: add support for emulat=
ing UMIP
>>
>> From: Paolo Bonzini <pbonzini@redhat.com>
>>
>> [ Upstream commit 66336cab3531d3325ebde36a04725dddd0c42cb5 ]
>>
>> The User-Mode Instruction Prevention feature present in recent Intel
>> processor prevents a group of instructions (sgdt, sidt, sldt, smsw, and
>> str) from being executed with CPL > 0. Otherwise, a general protection
>> fault is issued.
>>
>> UMIP instructions in general are also able to trigger vmexits, so we can
>> actually emulate UMIP on older processors.  This commit sets up the
>> infrastructure so that kvm-intel.ko and kvm-amd.ko can set the UMIP
>> feature bit for CPUID even if the feature is not actually available
>> in hardware.
>>
>> Reviewed-by: Wanpeng Li <wanpeng.li@hotmail.com>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
>
>This is not enough (there were a couple bugs, plus you have not
>added the changes needed to the handle SLDT, STR, etc. in the
>emulator).  But since this is a feature, why is it being backported
>to 4.14, especially without any testing??

Hi Paolo,

They were proposed for stable as part of the automatic patch selection
process. I'll drop this patch.

--=20

Thanks,
Sasha=