Received: by 10.213.65.68 with SMTP id h4csp35668imn; Mon, 19 Mar 2018 18:42:09 -0700 (PDT) X-Google-Smtp-Source: AG47ELudfou/CVwQrg4UJEpNVrxpxR7K6DG7QN1NHauTw2SV+woOByrKlMOHysQ2swnUNNP54jgR X-Received: by 2002:a17:902:467:: with SMTP id 94-v6mr14367093ple.57.1521510129291; Mon, 19 Mar 2018 18:42:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521510129; cv=none; d=google.com; s=arc-20160816; b=kjCFWCnA+jokZWx5fqkAkubqsb8936uxXJY2RZeHp9utMagSUgCjsBovBWNRmnXoDC H2PSDk4XmXU5LvfSIcV5s7YNiZs+9trbUfLaAbIaxdV8Tbspm4+EzWKRKbbNlkYmHTzw gXuViifr4XY3fPdaUSfRNslKUs8mTpuJ/72NW8LNIGF/D6qNqAnvPtRPi39RpTj+QquS gBPm35va9FxETBA1BjYwh8KUbJiml2dKyP2tBUFtm7cQTYAxLcne9+AYXdMN8xOK0A0M nLvZZpHxbPhxdM9NZa/++q3KTb3mr34Xb/z8wUUsOdDqXI7VrRofxGIRjKJ6VtOAUwlA zi5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=rMO+5p/tUMeYbLy4hdKzP4v63zcJxRcdFNTv/FgXc/g=; b=vtmR5+P6Sivd5X9A9SzXawOi1k2xoF08puk14RAUTYDTugeknBip70Ud2SnXTBD3JW fel098MPLqjjt4wSFnBf++feFQP8Jku5dog2ZTDJ1NmlgEHn03fPY1wJl0aZEFnj0eXW rrpS/q+sJTdobwzUIJ4bCO3NCGsmNgJgvBcGZLyHFCTPgSZOTo5qcvJSbSIRdAaVctvh 4bwR5dfEdiq7MTiuCXLsGLPSFkzYXrtZ3N86Xq3IONxxN1kAtFEU9xS9sslf3QgXIfFs ttlnTKZq5bDnlctdsrXEK6GwTPilwZubr3hiRqhHrDr2RpRx6E2JiJg+kY9mXUAasSYS ouzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=KcJcDlIO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 61-v6si491853plr.136.2018.03.19.18.41.55; Mon, 19 Mar 2018 18:42:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=KcJcDlIO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030261AbeCSRxZ (ORCPT + 99 others); Mon, 19 Mar 2018 13:53:25 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:55259 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965702AbeCSRxR (ORCPT ); Mon, 19 Mar 2018 13:53:17 -0400 Received: by mail-wm0-f68.google.com with SMTP id h76so16828461wme.4 for ; Mon, 19 Mar 2018 10:53:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rMO+5p/tUMeYbLy4hdKzP4v63zcJxRcdFNTv/FgXc/g=; b=KcJcDlIOAl8JFA+yN3jdV8gO3NNbBeV5kb3FjyZF6OoeN2hZDC5ZBGLp2p4hZxepir 62E0B+6Kqt0zOUagcn5tV6q+o1jdCToPfOmohGsET7UriJ8JJKGL8EhwibgCMAvqvsj9 gO9wnAbKOg7wF961SbVL3a/eTx+3SRO7YnA3DXnWXS2hLPmN4i7ENLQv2gQ4TvMgWxsc 1VOYG8xU6jY2gbYRPeOizCwy+k2QXPOE0ZXI9NxSS1dqcw9Cg38789+IDaEwwuKik8dr f1MKZh5lmXOUl4Z4sGWzMvx8/qNzTqRfzDF59CkJemamO4dAT0xq+koJEbRY1XxnLvQV jvOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rMO+5p/tUMeYbLy4hdKzP4v63zcJxRcdFNTv/FgXc/g=; b=NaEz0BKnYZTPzDdChr5d89aF04Bx6xMg5SKHIPLeRZbEOh++yaMh4KNraziNlOldXa UdbXFzxiCymOltmOSEdKV9VzdyeT4vbMfkEP7dyJCk22ksPrYhXuNu3s6NJ6lhVX6+gF GCc0A2oeFdj7eK0fUPy2VlyontaUbwWXmdw5VOaKFm0HOTfPaXZDrB2Nr65DwpeVNXHE yOS4N3fgbGCI+ZJfMRUgJNgQDCo9bWZsAzkvZzAc2SAoGlfNQj7aMD+aPCoHTDRVMXF0 pF4Ze61qXlbc06ESslB5pmI7uLEpTkTLAuF+1lb2sC50nBl7V1lla6GBf0bg67dJJOZN khjg== X-Gm-Message-State: AElRT7HOeHHFRUsapS0lboIFHBcOeX9eXu2uHLZOQRKfL7xXKiwdAy1i hfqyLmAe/VDLZilkFoGywcV3TA== X-Received: by 10.28.154.87 with SMTP id c84mr4378786wme.141.1521481996451; Mon, 19 Mar 2018 10:53:16 -0700 (PDT) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [174.3.196.123]) by smtp.gmail.com with ESMTPSA id z197sm1243979wmz.24.2018.03.19.10.53.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Mar 2018 10:53:15 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.86_2) (envelope-from ) id 1exyy8-0000NF-R6; Mon, 19 Mar 2018 11:53:12 -0600 Date: Mon, 19 Mar 2018 11:53:12 -0600 From: Jason Gunthorpe To: Honggang LI Cc: dledford@redhat.com, linux-rdma@vger.kernel.org, noaos@mellanox.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] IB/core: Set speed string to SDR for invalid active rates Message-ID: <20180319175312.GE1225@ziepe.ca> References: <20180315090214.21706-1-honli@redhat.com> <20180315090214.21706-2-honli@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180315090214.21706-2-honli@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 15, 2018 at 05:02:13PM +0800, Honggang LI wrote: > From: Honggang Li > > commit f1b65df5a232 ("IB/mlx5: Add support for active_width and > active_speed in RoCE"). Before this patch applied, the mlx5_ib > driver set default active_width and active_speed to IB_WIDTH_4X > and IB_SPEED_QDR. > > Now, the active_width and active_speed are zeros if the RoCE port > is in DOWN state. The speed string should be set to " SDR" instead of > a blank string when active_speed is zero. > > Signed-off-by: Honggang Li > drivers/infiniband/core/sysfs.c | 1 + > 1 file changed, 1 insertion(+) Applied to for-next, thanks Jason