Received: by 10.213.65.68 with SMTP id h4csp37671imn; Mon, 19 Mar 2018 18:46:20 -0700 (PDT) X-Google-Smtp-Source: AG47ELsIuUIK1++ssLNyliQDKVLFDQcXlGEOPXMlaHe2SvAW/a9ZTdxyPC/3mYpQXlpvQEpyfRgo X-Received: by 2002:a17:902:43a4:: with SMTP id j33-v6mr14428279pld.247.1521510379998; Mon, 19 Mar 2018 18:46:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521510379; cv=none; d=google.com; s=arc-20160816; b=QRWHJ8+f1R96yDqJONSuR4aVbtLsNgMCaz53F4iBxTgQQHUGQ8kVgUs42p27FRcavY 50XnyNBDjXHL9FWTbbs95tiPoxp6mo7iC/0xxcCVjEfbMDKsAnAgAnSnKZrPVSiXrZex 5TA7wcNU2Rndh7IAhO0DnV+WaSf0EUUatVdIl4CEw8v5t754fYr1tgSNJrRS+y3fMD5C 3/+dxLTBdQCCNHlGq7cGfWnOfEBQhDfnF90MYYf2YiVsFnrIZUMnrKrRRSc7GmI6esvI RJfLIa1bUD7ep9QlfwQjXCkuAxIFbhhfdxE1n7W8NDHrYak4F3/zzolw16Bt/1EI01u3 1gkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=jJcIzNGpqhTu4EcQkleIYW4XZH+7LZZMv9++QOVlE1M=; b=YQO92BSlesjoHU12A6dyYQpMCnDgfAKrl4IEtBKQSmEWLe35JcNHwK4fASl5dgmrbU +AjijmCAJ8SxwsJ1tfr8SuLA/+O/hpeot/Cs5GBA/XT+ed2AaXs2tkzRL9/LPgP5S2Op FEJz//bmpBzQJIxsf5wmyvdLfEt0xFmJKC0hbQ7faCmBRVSHf3+D1PzsdomioKVdUDtx 5i2cf8zB3o1vedz/kMme2LtZ7fPr7N2JaekAd/jm556isqiVHLWJPRUYuxZqivFu8PNO DyM6TU4klgoesjD8ERgj2bC0Wnld2yE/K0e5p+u8gx8/fA2bew6RnUL8uMioycPCvQtW OMAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q26si431227pfh.129.2018.03.19.18.46.06; Mon, 19 Mar 2018 18:46:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966763AbeCSTX5 (ORCPT + 99 others); Mon, 19 Mar 2018 15:23:57 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:50116 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S969698AbeCSSYr (ORCPT ); Mon, 19 Mar 2018 14:24:47 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 76AF8F9E; Mon, 19 Mar 2018 18:24:46 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Laxman Dewangan , Thierry Reding , Sasha Levin Subject: [PATCH 4.9 154/241] pwm: tegra: Increase precision in PWM rate calculation Date: Mon, 19 Mar 2018 19:06:59 +0100 Message-Id: <20180319180757.557584913@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180319180751.172155436@linuxfoundation.org> References: <20180319180751.172155436@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Laxman Dewangan [ Upstream commit 250b76f43f57d578ebff5e7211eb2c73aa5cd6ca ] The rate of the PWM calculated as follows: hz = NSEC_PER_SEC / period_ns; rate = (rate + (hz / 2)) / hz; This has the precision loss in lower PWM rate. Change this to have more precision as: hz = DIV_ROUND_CLOSEST_ULL(NSEC_PER_SEC * 100, period_ns); rate = DIV_ROUND_CLOSEST(rate * 100, hz) Example: 1. period_ns = 16672000, PWM clock rate is 200 KHz. Based on old formula hz = NSEC_PER_SEC / period_ns = 1000000000ul/16672000 = 59 (59.98) rate = (200K + 59/2)/59 = 3390 Based on new method: hz = 5998 rate = DIV_ROUND_CLOSE(200000*100, 5998) = 3334 If we measure the PWM signal rate, we will get more accurate period with rate value of 3334 instead of 3390. 2. period_ns = 16803898, PWM clock rate is 200 KHz. Based on old formula: hz = 59, rate = 3390 Based on new formula: hz = 5951, rate = 3360 The PWM signal rate of 3360 is more near to requested period than 3333. Signed-off-by: Laxman Dewangan Signed-off-by: Thierry Reding Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/pwm/pwm-tegra.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) --- a/drivers/pwm/pwm-tegra.c +++ b/drivers/pwm/pwm-tegra.c @@ -76,6 +76,7 @@ static int tegra_pwm_config(struct pwm_c struct tegra_pwm_chip *pc = to_tegra_pwm_chip(chip); unsigned long long c = duty_ns; unsigned long rate, hz; + unsigned long long ns100 = NSEC_PER_SEC; u32 val = 0; int err; @@ -95,9 +96,11 @@ static int tegra_pwm_config(struct pwm_c * cycles at the PWM clock rate will take period_ns nanoseconds. */ rate = clk_get_rate(pc->clk) >> PWM_DUTY_WIDTH; - hz = NSEC_PER_SEC / period_ns; - rate = (rate + (hz / 2)) / hz; + /* Consider precision in PWM_SCALE_WIDTH rate calculation */ + ns100 *= 100; + hz = DIV_ROUND_CLOSEST_ULL(ns100, period_ns); + rate = DIV_ROUND_CLOSEST(rate * 100, hz); /* * Since the actual PWM divider is the register's frequency divider