Received: by 10.213.65.68 with SMTP id h4csp38692imn; Mon, 19 Mar 2018 18:48:38 -0700 (PDT) X-Google-Smtp-Source: AG47ELs9JeGk1gHjU7IRaXnpXaO4JU9A5cE/9moec8/j1Gj54GHO+GmvZjkmDInzlsDtgPvQGlgb X-Received: by 2002:a17:902:f44:: with SMTP id 62-v6mr14467898ply.27.1521510518532; Mon, 19 Mar 2018 18:48:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521510518; cv=none; d=google.com; s=arc-20160816; b=VMg+Bpw0uBWpXWywGOw2gxlcPO1i4THY5ff+qJdxQ8IZ72ufRgUv8W+J+hfyMOsGek P4UWrSQwSqBuAGdJKQKBqkmvjGxck59l250nOyFg++5Sh6hWBacXa3Vbgc3dmU/5NWeT Z2soe46+tjYtpRZUi7RGqrjst9F1p4ChTmBhvqSHLDVJcDULmN2wWQ9Haakg4AtpmgTh cZLGjkdvyCNAKCh83xes5qnvI0VQNxj5+0kHO7s0PB01Qf+1LwqE6V8xNRMNvN310LTI k2FN2/dVO8msQUuAv5arDAdU1Pn/IaHQgoL2ZVvvGLASDVFodFtraNZGSenPUpVGFqS6 iYsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=E4EoITbpP2yqEk04Y3fSvS+Nz1ZMivSRv0XpsKsljWA=; b=A+JNlQ6CrYGXDfOx8/b/mCqjazfuLfLuK9qPqIY2Xfpmn9n6jZ4nt1XwpdktTc6us1 FWwW4GMxMbcGqPMr9XszsTD9wjLIeP4OJr20ECY0VQPJqGzrBv/xqbAGI+tkqbzcnyud jSLJ7Mo5N4Rn+UpYvIoZXCIRmeE0BTY9SIyjUlp/Hkmqk7GS5kgfgYU1ZCG8ZtdlYGMv cIjOPiS4ldEOrqTIL2ys6/RyNceL+UfQxZNEGJkby5FSYOcxQiIjHLDed5pIwN5IYMVl 9qa9YZkiC8GFvOmB0FvSbFFHNPbRk1Ybft1wTx7ThyIJjbcfTvK2t4Q6Tfau59lElZ3w MhPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 61-v6si491853plr.136.2018.03.19.18.48.25; Mon, 19 Mar 2018 18:48:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969438AbeCSTol (ORCPT + 99 others); Mon, 19 Mar 2018 15:44:41 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:47918 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966411AbeCSSU7 (ORCPT ); Mon, 19 Mar 2018 14:20:59 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 3F9F81224; Mon, 19 Mar 2018 18:20:58 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hiroyuki Yokoyama , Kuninori Morimoto , Mark Brown , Sasha Levin Subject: [PATCH 4.9 062/241] ASoC: rcar: ssi: dont set SSICR.CKDV = 000 with SSIWSR.CONT Date: Mon, 19 Mar 2018 19:05:27 +0100 Message-Id: <20180319180753.770928793@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180319180751.172155436@linuxfoundation.org> References: <20180319180751.172155436@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kuninori Morimoto [ Upstream commit 6b8530cc056efd4a11b034ca5b1e9f7e9563f553 ] R-Car Datasheet is indicating "SSICR.CKDV = 000 is invalid when SSIWSR.WS_MODE = 1 or SSIWSR.CONT = 1". Current driver will set CONT, thus, we shouldn't use CKDV = 000. This patch fixup it. Reported-by: Hiroyuki Yokoyama Signed-off-by: Kuninori Morimoto Tested-by: Hiroyuki Yokoyama Signed-off-by: Mark Brown Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- sound/soc/sh/rcar/ssi.c | 9 +++++++++ 1 file changed, 9 insertions(+) --- a/sound/soc/sh/rcar/ssi.c +++ b/sound/soc/sh/rcar/ssi.c @@ -233,6 +233,15 @@ static int rsnd_ssi_master_clk_start(str for (j = 0; j < ARRAY_SIZE(ssi_clk_mul_table); j++) { /* + * It will set SSIWSR.CONT here, but SSICR.CKDV = 000 + * with it is not allowed. (SSIWSR.WS_MODE with + * SSICR.CKDV = 000 is not allowed either). + * Skip it. See SSICR.CKDV + */ + if (j == 0) + continue; + + /* * this driver is assuming that * system word is 32bit x chan * see rsnd_ssi_init()