Received: by 10.213.65.68 with SMTP id h4csp39108imn; Mon, 19 Mar 2018 18:49:34 -0700 (PDT) X-Google-Smtp-Source: AG47ELuu5Uji9UfX3/KbU/Sz3Xpy8xYRV7fvgu2i/OuCzV3NMQ0c+Nw2KUFu+8qNgxSaxUhmlkQX X-Received: by 2002:a17:902:8c88:: with SMTP id t8-v6mr4935536plo.329.1521510574697; Mon, 19 Mar 2018 18:49:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521510574; cv=none; d=google.com; s=arc-20160816; b=JQYtGP1JjXKubLGIQwTSX/++FFh/kUCxrRBP3hiiToMcdV0sLFydwptItpsNzUxLis MxDnNnY/u1ed/+XB2Nt7gJ5Bm96fHa1nWmFYQ3Plpb6lVGRyIryCcavifR/GkytdtRk+ t/H/ZaqyZFZPnPQ5xyJIYR7xr41t4jUaTggr/ZksumR5biwgblqIXHAJIcBwpdmitsvw hRhRr/s2VyUgEVHgaCkWZyfcOqx7heIUJnuHqvM65FVlWofxo+Ot6gqivgOdhc7cpbHY Bw1CWpByODtV78Kt9zG32IV4veMoxUBHc1evu3sEvBgq3GH65lp0TFqCJfPI4n+o9QGY rLpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=le+rk+CUOoead3I27HUSSYs60TDbQBHp0uAHyz4s2tA=; b=YlQmw6HL2B3B42i2+PMViLl1m2MhEU8LnQdFZbuyWSJTJ9ERbdqmIOfaT7h1aGGpv1 qsw2eoLbxaotGnxQCY2wspWAxRAhiGEYnISu94uQx4V6NBpuC06KKgo9A2xwhjqxvUfU WbPyAhn36lgavIAmWTBC3ZUJX8DQvCSGUo2wWr5Eh7YB+3PWMBkgzXfWdpavsz9fhk9I rqw02WTfhBgekwnORUuJ2ICxX/bQ7mhl0BkIDmNxDZy9OjQ31+Mk56i9LvBnk5THEBQj zvpnRIGodxNm130aB2SYgJXQ35P0SSFz+V5FEa3cHquBYDgarGEb8hs9gEjZNA04n52m 9oqQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v13si414856pgq.478.2018.03.19.18.49.21; Mon, 19 Mar 2018 18:49:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030971AbeCST6Z (ORCPT + 99 others); Mon, 19 Mar 2018 15:58:25 -0400 Received: from verein.lst.de ([213.95.11.211]:32996 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S970929AbeCST6C (ORCPT ); Mon, 19 Mar 2018 15:58:02 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 2415E6F233; Mon, 19 Mar 2018 20:58:01 +0100 (CET) Date: Mon, 19 Mar 2018 20:58:01 +0100 From: Christoph Hellwig To: Jonas Rabenstein Cc: Scott Bauer , Jonathan Derrick , Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v2 04/11] block: sed-opal: unify error handling of responses Message-ID: <20180319195801.GF3380@lst.de> References: <4a20f9848927d0f654491136e4821f2adab131cc.1521482295.git.jonas.rabenstein@studium.uni-erlangen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4a20f9848927d0f654491136e4821f2adab131cc.1521482295.git.jonas.rabenstein@studium.uni-erlangen.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 19, 2018 at 07:36:46PM +0100, Jonas Rabenstein wrote: > Also response_get_token had already been in place, its functionality had > been duplicated within response_get_{u64,bytestring} with the same error > handling. Unify the handling by reusing response_get_token within the > other functions. Should probably be one patch for each of the two separate changes. Except for that this looks fine to me: Reviewed-by: Christoph Hellwig