Message-Id: <200308111800.h7BI0o0r030965@turing-police.cc.vt.edu>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: davej@redhat.com, torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove useless assertions from reiserfs 
In-Reply-To: Your message of "Mon, 11 Aug 2003 13:45:30 EDT."
             <3F37D63A.8010500@pobox.com> 
From: Valdis.Kletnieks@vt.edu
References: <E19mFqr-00068B-00@tetrachloride>
            <3F37D63A.8010500@pobox.com>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==_Exmh_-648034984P";
	 micalg=pgp-sha1; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7bit
Date: Mon, 11 Aug 2003 14:00:50 -0400
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1168
Lines: 44

--==_Exmh_-648034984P
Content-Type: text/plain; charset=us-ascii

On Mon, 11 Aug 2003 13:45:30 EDT, Jeff Garzik said:
> Why are these useless?

> >  	if (len >= 12)
> >  	{          
> >      //assert(len < 16);
> >               if (len >= 16)
> >                    BUG();
> 
> Seems like a valid check to me...

Just before that, there's code:

     while(len >= 16)
        {
	...
                len -= 16;
            }

So if that ever exits with a len >=16, we have a SERIOUS problem with
either the compiler or the hardware - as such, that "if (..) BUG" is dead code.
Similarly for the other checks.

--==_Exmh_-648034984P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
Comment: Exmh version 2.5 07/13/2001

iD8DBQE/N9nScC3lWbTT17ARAs8CAJ9YLu92aQWlhKnO/RPV+vo/rY31rwCdGgEn
s7xwgMS0hppavfYFZ0O3IlM=
=cz8Q
-----END PGP SIGNATURE-----

--==_Exmh_-648034984P--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/