Received: by 10.213.65.68 with SMTP id h4csp66472imn; Mon, 19 Mar 2018 19:51:39 -0700 (PDT) X-Google-Smtp-Source: AG47ELtGuYXPd02TmFjp30Dfzf+otMMpDCXHqkCiKs7yU+xLbbFqWGf9sAOeEcfZwPCqkLMKBwLJ X-Received: by 2002:a17:902:b408:: with SMTP id x8-v6mr9172958plr.7.1521514299597; Mon, 19 Mar 2018 19:51:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521514299; cv=none; d=google.com; s=arc-20160816; b=X/DTaJhqwzF1g4PVaHzRgcB4+zOwUY7mSIvDE/243SIpd40BB0CIK28MBMmo8ytB4j UHEa8SlLF7C7dCFO9JseBJZZONe3D2RkVj+9W4EoAkvcT6AVasOeciDjj5II9kDJh5b0 9YRguL9ntxIoHCN5AOTjK0FJzfZnOCV0+9kb3U/JLuMjq2Cle5u9XCdhNIsuOJOBP63z SDEmxzIWe6G41r+6rujN6rGsrCGppazSjVRMFWjtrh5WkDmXZ9eGR+9sSdawBLq+GMso XjLeOQ5X9VxR7fSq85wvT71BmWQQq4+sN3YkeFqrwL0b5Phqux5HCcnTLCQ61e4se7ky gmeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=IP4tDQcZ9RsS3UFqEeY/m4MCkn2HjG36NXLA1KIvTP4=; b=HivHBhOzPB8kl/+B+j8QHuiuzMiZa0OIVo7Be8er9mExBFD9+whKOF+MlShy48kIB7 NsTjkM4Wgo3dLTKza+jqiP+CNVocS4TPJxv/Ptb1O6w43wVos538ftP52y6c9QS/Fj4z +nPF+PGh+kQZf99CmSA34Fr9Zmu7poZwgRKwZgQH0mbaaU3z02iXcagdVxe03OOw0WAz 4SXDowPc92rzJ2w279WzgrOT45vxMlyTIrqg+JC/MkwmVCr9DoL9Np3WcIXYX/lBvRYL ED8dr6WY5Wm2VgHdVlNS8BQ4a9z307/eUVbZefmkYCV99V+HN4XQPebyxaSN6ikOjFNi gbbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=R6D2zwih; dkim=pass header.i=@codeaurora.org header.s=default header.b=MWVSX6Ql; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s20-v6si577523plp.340.2018.03.19.19.51.25; Mon, 19 Mar 2018 19:51:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=R6D2zwih; dkim=pass header.i=@codeaurora.org header.s=default header.b=MWVSX6Ql; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163AbeCTCu0 (ORCPT + 99 others); Mon, 19 Mar 2018 22:50:26 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:35142 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751857AbeCTCuV (ORCPT ); Mon, 19 Mar 2018 22:50:21 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 34221610D5; Tue, 20 Mar 2018 02:50:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521514219; bh=W9/yviHskqvwFPloVpoKaCcmJwlqdPqG2IWrksKoXY0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R6D2zwihP5TPXzq8ws57Pwh+7i6YYVANaOB/Jby39rssUGxicXTrI2+lZGY3vxmtc kfemyVaQGRHnF8+krHFobgFCOjjjHO/KDk5HbW7sxjtHY1Gs3osTyi6V+06m0ZZq7Q RbvUspPX10kVpnf+KcmE7IrspIZ4eoCWKOK8Cf0A= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0165A60FEE; Tue, 20 Mar 2018 02:50:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521514214; bh=W9/yviHskqvwFPloVpoKaCcmJwlqdPqG2IWrksKoXY0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MWVSX6QlqGdyn8teHhBhixyiolrGKEn+lihL0C9Vlzc3GM3paJPA7NWhu9Ho+795O R25MyVO3K3GGDmb0T49NIddFbg58FN+CmUFrE5b0Gy8qkAaE5XoiwVgV57HNpSPmVV bHRCnddyeZRzJd1ItKyf7dB4lfBjWQqvBHcn0aMo= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0165A60FEE Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: linux-scsi@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sinan Kaya , Don Brace , "James E.J. Bottomley" , "Martin K. Petersen" , esc.storagedev@microsemi.com, linux-kernel@vger.kernel.org Subject: [PATCH v4 1/7] scsi: hpsa: Eliminate duplicate barriers on weakly-ordered archs Date: Mon, 19 Mar 2018 22:50:01 -0400 Message-Id: <1521514207-10695-2-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521514207-10695-1-git-send-email-okaya@codeaurora.org> References: <1521514207-10695-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Code includes wmb() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-off-by: Sinan Kaya --- drivers/scsi/hpsa.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h index 018f980..c7d7e6a 100644 --- a/drivers/scsi/hpsa.h +++ b/drivers/scsi/hpsa.h @@ -599,7 +599,7 @@ static unsigned long SA5_ioaccel_mode1_completed(struct ctlr_info *h, u8 q) * but with current driver design this is easiest. */ wmb(); - writel((q << 24) | rq->current_entry, h->vaddr + + writel_relaxed((q << 24) | rq->current_entry, h->vaddr + IOACCEL_MODE1_CONSUMER_INDEX); atomic_dec(&h->commands_outstanding); } -- 2.7.4