Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Message-ID: <trinity-791d9452-e47f-4b31-aa93-f5fca597eaba-1521532205503@3c-app-mailcom-bs12>
From:   "Chengguang Xu" <cgxu519@gmx.com>
To:     yuanliang.wyl@alibaba-inc.com
Cc:     miklos <miklos@szeredi.hu>,
        linux-unionfs <linux-unionfs@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: =?UTF-8?Q?=28Resend=29_Re=3A_=E5=9B=9E=E5=A4=8D=EF=BC=9A=5BPATC?=
 =?UTF-8?Q?H=5D_fs/overlayfs=3A_Drop_?=
 =?UTF-8?Q?dentry_cache_to_prevent_unknown_file_status?=
Content-Type: text/plain; charset=UTF-8
Date:   Tue, 20 Mar 2018 08:50:05 +0100
Importance: normal
Sensitivity: Normal
In-Reply-To: <d4e3461e-7a46-41dd-a27b-d86a5c5144b9.yuanliang.wyl@alibaba-inc.com>
References: <1521525830-88382-1-git-send-email-yuanliang.wyl@alibaba-inc.com>
 <trinity-46014179-644f-4087-8f6b-614fa55fca2a-1521528270006@3c-app-mailcom-bs12>
 <trinity-f09d5d8a-6967-4254-88db-cf7ea9270afe-1521529654015@3c-app-mailcom-bs12>
 <d4e3461e-7a46-41dd-a27b-d86a5c5144b9.yuanliang.wyl@alibaba-inc.com>
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Sorry, resend email because of sending failure.
If you have already received, please ignore it.

Hi Yuanliang,
 
If you use ext4, you can try below command to check if filetype
feature has already enabled.
 
tune2fs -l /dev/xxx | grep feature
 
If filetype feature is not enabled, please enable it first and
check if the problem still persist.
 
The phenomenon I met is similar to yours in the previous email.
 
Thanks,
Chengguang.
 
---------

Sent: Tuesday, March 20, 2018 at 3:22 PM
From: 王元良 <yuanliang.wyl@alibaba-inc.com>
To: "Chengguang Xu" <cgxu519@gmx.com>, "Chengguang Xu" <cgxu519@gmx.com>
Cc: miklos <miklos@szeredi.hu>, linux-unionfs <linux-unionfs@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>
Subject: 回复：[PATCH] fs/overlayfs: Drop dentry cache to prevent unknown file status

Hi, Chengguang
 
is the ftype for xfs only?
 
Could you describe in detail the problems that you have encountered on your side and give more on-site information may help?
 
------------------------------------------------------------------
发件人：Chengguang Xu <cgxu519@gmx.com>
发送时间：2018年3月20日(星期二) 15:07
收件人：Chengguang Xu <cgxu519@gmx.com>
抄　送：王元良(尉犁) <yuanliang.wyl@alibaba-inc.com>; miklos <miklos@szeredi.hu>; linux-unionfs <linux-unionfs@vger.kernel.org>; linux-kernel <linux-kernel@vger.kernel.org>
主　题：Re: [PATCH] fs/overlayfs: Drop dentry cache to prevent unknown file status
 Hi Yuanliang,

Can you try ext4 or xfs(with ftype=1) as underlying fs? 
It seems the phenomenon that I met on xfs(with ftype=0) as underlying fs.
Thanks,
Chengguang.


> Sent: Tuesday, March 20, 2018 at 2:44 PM
> From: "Chengguang Xu" <cgxu519@gmx.com>
> To: 王元良 <yuanliang.wyl@alibaba-inc.com>
> Cc: miklos@szeredi.hu, linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org, 王元良 <yuanliang.wyl@alibaba-inc.com>
> Subject: Re: [PATCH] fs/overlayfs: Drop dentry cache to prevent unknown file status
>
> Hi Yuanliang,
> 
> Can you explain how to reproduce it? and what filesystem do you use as underlying fs?
> 
> 
> > Sent: Tuesday, March 20, 2018 at 2:03 PM
> > From: 王元良 <yuanliang.wyl@alibaba-inc.com>
> > To: miklos@szeredi.hu
> > Cc: linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org, 王元良 <yuanliang.wyl@alibaba-inc.com>
> > Subject: [PATCH] fs/overlayfs: Drop dentry cache to prevent unknown file status
> >
> > When the dentry cache is not destroyed, statfs will
> > take unknown status '?'
> > Undestroyed cache dentry also caused new file creating fails
> > 
> > Drop it using d_delete may be a choice
> > 
> > [root@host /]
> > Loaded plugins: bestyumcache, branch, fastestmirror, langpacks
> > Repodata is over 2 weeks old. Install yum-cron? Or run: yum makecache
> > fast
> > Cleaning repos: xxx.base.x86_64 ops.x.noarch ops.x.x86_64
> > Cleaning up everything
> > Cleaning up list of best yumcache
> > Cleaning up list of fastest mirrors
> > 
> > [root@host /]
> > Loaded plugins: bestyumcache, branch, fastestmirror, langpacks
> > Cleaning repos: xxx.base.x86_64 ops.x.noarch ops.x.x86_64
> > Cleaning up everything
> > Cleaning up list of best yumcache
> > Traceback (most recent call last):
> >     File "/usr/bin/yum", line 29, in <module>
> >     yummain.user_main(sys.argv[1:], exit_code=True)
> >     File "/usr/share/yum-cli/yummain.py", line 365, in user_main
> >     errcode = main(args)
> >     File "/usr/share/yum-cli/yummain.py", line 174, in main
> >     result, resultmsgs = base.doCommands()
> >     File "/usr/share/yum-cli/cli.py", line 573, in doCommands
> >     return self.yum_cli_commands[self.basecmd].doCommand(self,
> >      self.basecmd, self.extcmds)
> >     File "/usr/share/yum-cli/yumcommands.py", line
> >     1475, in doCommand
> >     return base.cleanCli(extcmds)
> >     File "/usr/share/yum-cli/cli.py", line 1666, in
> >     cleanCli
> >     self.plugins.run('clean')
> >     File
> >     "/usr/lib/python2.7/site-packages/yum/plugins.py", line 188, in run
> >     func(conduitcls(self, self.base, conf, **kwargs))
> >     File "/usr/lib/yum-plugins/branch.py", line 65, in clean_hook
> >     os.remove(os.path.join(root,filespath))
> >     OSError: [Errno 2] No such file or directory:
> >        '/var/cache/yum/x86_64/x/xxxx.noarch.stable/
> >       b49e49b87d17818d799363091c7a01dde83b421d-primary.sqlite.bz2'
> > 
> > [root@host /]
> >     ls: cannot access
> >     /var/cache/yum/x86_64/x/xxxx.noarch.stable/
> >     b49e49b87d17818d799363091c7a01dde83b421d-primary.sqlite.bz2:
> >     No such file or directory
> >     ls: cannot access
> >     /var/cache/yum/x86_64/x/xxxx.noarch.stable/cachecookie:
> >     No such file or directory
> >     ls: cannot access
> >     /var/cache/yum/x86_64/x/xxxx.noarch.stable/repomd.xml:
> >     No such file or directory
> >     total 0
> >     ?????????? ? ?    ?     ?            ?
> >     b49e49b87d17818d799363091c7a01dde83b421d-primary.sqlite.bz2
> >     ?????????? ? ?    ?     ?            ?
> >     cachecookie
> >     drwxr-xr-x 1 root root 30 Mar 15 16:12 gen
> >     drwxr-xr-x 2 root root  6 Jan 31 13:13
> >     packages
> >     ?????????? ? ?    ?     ?            ?
> >     repomd.xml
> > 
> > Signed-off-by: Yuanliang Wang <yuanliang.wyl@alibaba-inc.com>
> > ---
> >  fs/overlayfs/super.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
> > index e7c8ac4..f9343d3 100644
> > --- a/fs/overlayfs/super.c
> > +++ b/fs/overlayfs/super.c
> > @@ -380,9 +380,15 @@ static int ovl_dentry_weak_revalidate(struct dentry *dentry, unsigned int flags)
> >   return ret;
> >  }
> >  
> > +static int ovl_dentry_delete(const struct dentry *dentry)
> > +{
> > + return 1;
> > +}
> > +
> >  static const struct dentry_operations ovl_dentry_operations = {
> >   .d_release = ovl_dentry_release,
> >   .d_real = ovl_d_real,
> > + .d_delete = ovl_dentry_delete,
> >  };
> >  
> >  static const struct dentry_operations ovl_reval_dentry_operations = {
> > -- 
> > 1.8.3.1
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>