Received: by 10.213.65.68 with SMTP id h4csp251900imn; Tue, 20 Mar 2018 02:34:16 -0700 (PDT) X-Google-Smtp-Source: AG47ELvmQ9t+c+ON+0xWRmt3c8PmlLeGc3wKp/R5adR2/BrLIAJTZ/+Zb30Ui9ch+auB0L2iKQAz X-Received: by 2002:a17:902:6a17:: with SMTP id m23-v6mr15674336plk.342.1521538456341; Tue, 20 Mar 2018 02:34:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521538456; cv=none; d=google.com; s=arc-20160816; b=OAYA0RpQYxA6dBffQwDbWgOKo5q7eTeQp3h5pJbdKSJN9uUasThYdJghtMACm6xBaS NXX6pgFIqnRhHdZ7vaZyZUWf1AlSdPhJ4ihJHbVygrGQKoEc6fRGSKiSj+fakmfaeb3v mxPJuV2FVdq6/rBeWbAx+HlRMutDUxWrbh80iQ+mXjaZyACxQRrmF8CoIs8qrUf74m+a 78sYBVbhse+gFZap7zl0phpfNQ1be2pYDZ6wY9ftozhSOjUAKZQzj0zmpE/Er3POkHaf kuCjjmjtUdWY+KFrLa9wxSvlmjVxk8CHs7gdVHh7oc5PP/tWXc/cG49r2mlynbH+NkFv KNCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject:arc-authentication-results; bh=7QBbicXvuyvtfbjW1NDYxt1wwlV/IWanUCBVV4/qM+Y=; b=yQIGlJ/gInlbyI8B4pbbf8S6qR/N+5MJdEHqTrDKw9p/7o3Ua2q8buFwzXdWXfUZ8P kFb8QUdhtG4gmTpaSBGO6GU/kLm7zW96+glVjrhT76RnCkuxQEFopHtpUk2duk+TJiOb 9ZkC3hfVLNATmRqRNXhVacTIgOMbEZqt+daGLzjKajlOL58gH+WYyC0G2LU+fhuNr0rY c+HUVXv28JyMDefu+jx9Cej/xhMs7IH5ZygpGUf6ujGU/RV/ndf83M3ckjmDYemxqVWB nvW5mDSuEKO62zkVlzUW1iP2yf5lBUYw1gh45IzLTH/dQNBp8wIWkpgJDla7xOa3ivk6 TjNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q188si923312pga.547.2018.03.20.02.33.59; Tue, 20 Mar 2018 02:34:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752244AbeCTJcR (ORCPT + 99 others); Tue, 20 Mar 2018 05:32:17 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:41713 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752184AbeCTJcQ (ORCPT ); Tue, 20 Mar 2018 05:32:16 -0400 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx08-.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id w2K9NjQ0001529; Tue, 20 Mar 2018 10:31:52 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2grtsg6t4n-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 20 Mar 2018 10:31:52 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id C74E241; Tue, 20 Mar 2018 09:31:50 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag5node2.st.com [10.75.127.14]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 820452459; Tue, 20 Mar 2018 09:31:50 +0000 (GMT) Received: from [10.201.23.236] (10.75.127.48) by SFHDAG5NODE2.st.com (10.75.127.14) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Tue, 20 Mar 2018 10:31:49 +0100 Subject: Re: [RESEND PATCH v1 6/6] i2c: i2c-stm32f7: Implement I2C recovery mechanism From: Pierre Yves MORDRET To: Wolfram Sang CC: Maxime Coquelin , Alexandre Torgue , , , References: <1520852023-27083-1-git-send-email-pierre-yves.mordret@st.com> <1520852023-27083-7-git-send-email-pierre-yves.mordret@st.com> <20180317204720.mclh4jw5owobbtww@ninjato> <2672947b-46b2-7bd7-ac13-501db8bde72b@st.com> Message-ID: Date: Tue, 20 Mar 2018 10:31:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <2672947b-46b2-7bd7-ac13-501db8bde72b@st.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.48] X-ClientProxiedBy: SFHDAG4NODE3.st.com (10.75.127.12) To SFHDAG5NODE2.st.com (10.75.127.14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-03-20_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, I do believe there is a misunderstanding of this recovery mechanism at my end. I intends to solve a problem where my I2C was stall but not the slave. Thus if bus is busy I reset the IP. Looking at the recovery API, this recovery is for slave and nothing else with my case. Therefore I think I have to get move this reset out of recovery API. Please correct me whether I'm wrong Slave Recovery mechanism is another story to implement in our platform since we have to deal with GPIOs. Let me know Regards On 03/19/2018 09:51 AM, Pierre Yves MORDRET wrote: > Yes. Recovery mechanism is triggered whenever a busy line is detected. > This busy state can be checked by sw when either SDA or SCL is low: a bit is set > by Hw for this purpose. > On busy state I2C is reconfigured and lines are released the time of recovery. > > Regards > On 03/17/2018 09:47 PM, Wolfram Sang wrote: >> On Mon, Mar 12, 2018 at 11:53:43AM +0100, Pierre-Yves MORDRET wrote: >>> Feature prevents I2C lock-ups. Mechanism resets I2C state machine >>> and releases SCL/SDA signals but preserves I2C registers. >> >> Does it release SDA when held down by the slave? Because that is what >> the recovery mechanism is for. >>