Received: by 10.213.65.68 with SMTP id h4csp304252imn; Tue, 20 Mar 2018 04:07:34 -0700 (PDT) X-Google-Smtp-Source: AG47ELt1z3c3o5kDGCA918rSkVH3KS4S5nF2fpiy6/sA4bo8h1ZuAh7ciFGoYgb9fAHVA9kJZo6+ X-Received: by 10.99.106.202 with SMTP id f193mr12038876pgc.334.1521544054678; Tue, 20 Mar 2018 04:07:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521544054; cv=none; d=google.com; s=arc-20160816; b=sK6ICNKnwsxwUwpKnGzX+XP75s6G6NVR06qmiLPAF60GROSXL2pfii11aNH6+hbkcK P+XvoJhehyP5Js0OwZ3WA+VlDUKZAs576dP/hOeP+U9skbGyv3Vaz4y1ljT2y+KYaSzM eNa4yrxBtVaj77Ds/iLKg4UyCdJjB+OF7mCi8eTwEkrriTTIP4J/Z7iGMN1bkIrO4uzl SISI3s+VNcm18R68AZS76YYxVXwICs6u5SAnjQRuM3+xJYFiBBmWlNWn6v42ySJg0aGN tO3G46VOdr++RxC/SFfqgRMyVIrTv0lNcfVis5KtH51b1k7gEGlYvuOh1Harve5WGpRv LR6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=zLDDDMU0SJeG/DwZ3P/UTiGa5jUzluY9+Lw7sv1WbKs=; b=DOrhUZPQR1+/Hqr5++WtpIS5DwF1dpGEnlWYBtFTSyfQKz561m6zRZ7iYXjjBh5aPC fPcf7YgyfcSuvNU9my3F327pLwNri5vv6k9us/fCV5YQUTWv1RTpQ2gvOlOOriE/gqzw DpBViX8U8R7fkiYGZUJQqlZerLifVVR+8LHRFXe5umZisNxDYj65swh/KyrgjNKs9kGP bIL7zqIe7S3eTSFASN1rFlIbouTJCa4SigewdhbQPWAgDYZED+cLYn53BvjHl2ayvktU nvebPUmIyqPPrOuJuDSkXY1X10Gd98NLmTIaOs0hqx5qUkqy9qbusK6mXIyN+726SmcC blIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t20si1168177pfi.88.2018.03.20.04.07.20; Tue, 20 Mar 2018 04:07:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752907AbeCTLFd (ORCPT + 99 others); Tue, 20 Mar 2018 07:05:33 -0400 Received: from mail.cn.fujitsu.com ([183.91.158.132]:43692 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752848AbeCTLFV (ORCPT ); Tue, 20 Mar 2018 07:05:21 -0400 X-IronPort-AV: E=Sophos;i="5.43,368,1503331200"; d="scan'208";a="38002754" Received: from bogon (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 20 Mar 2018 19:05:18 +0800 Received: from G08CNEXCHPEKD02.g08.fujitsu.local (unknown [10.167.33.83]) by cn.fujitsu.com (Postfix) with ESMTP id 99A094D0EFFC; Tue, 20 Mar 2018 19:05:15 +0800 (CST) Received: from localhost.localdomain (10.167.226.106) by G08CNEXCHPEKD02.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.361.1; Tue, 20 Mar 2018 19:05:14 +0800 From: Dou Liyang To: , , , CC: , , , , , , , Dou Liyang Subject: [PATCH 4/5] acpi/processor: Fix the return value of acpi_processor_ids_walk() Date: Tue, 20 Mar 2018 19:04:31 +0800 Message-ID: <20180320110432.28127-5-douly.fnst@cn.fujitsu.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180320110432.28127-1-douly.fnst@cn.fujitsu.com> References: <20180320110432.28127-1-douly.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.167.226.106] X-yoursite-MailScanner-ID: 99A094D0EFFC.A2FB5 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: douly.fnst@cn.fujitsu.com X-Spam-Status: No Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ACPI driver should make sure all the processor IDs in their ACPI Namespace are unique for CPU hotplug. the driver performs a depth-first walk of the namespace tree and calls the acpi_processor_ids_walk(). But, the acpi_processor_ids_walk() will return true if one processor is checked, that cause the walk break after walking pass the first processor. Repace the value with AE_OK which is the standard acpi_status value. Fixes 8c8cb30f49b8 ("acpi/processor: Implement DEVICE operator for processor enumeration") Signed-off-by: Dou Liyang --- drivers/acpi/acpi_processor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c index 449d86d39965..db5bdb59639c 100644 --- a/drivers/acpi/acpi_processor.c +++ b/drivers/acpi/acpi_processor.c @@ -663,11 +663,11 @@ static acpi_status __init acpi_processor_ids_walk(acpi_handle handle, } processor_validated_ids_update(uid); - return true; + return AE_OK; err: acpi_handle_info(handle, "Invalid processor object\n"); - return false; + return AE_OK; } -- 2.14.3