Received: by 10.213.65.68 with SMTP id h4csp315148imn; Tue, 20 Mar 2018 04:23:27 -0700 (PDT) X-Google-Smtp-Source: AG47ELsik/UOm9dUe4pIoJ6Xw/xLnozzt1r60FJlebHLCLtfTpn9HXeAdGnbi2DEY9xN4Mqv9c1A X-Received: by 10.98.81.133 with SMTP id f127mr13380816pfb.20.1521545007428; Tue, 20 Mar 2018 04:23:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521545007; cv=none; d=google.com; s=arc-20160816; b=KmFMmOEZSG7HUnyCmyEIJS06OOqrpmQx9g5cRjjY/cUJ3Uac5slpz1Wf+xNUQty4+J Rwny9dq6RWVg6O4CLgSgB+H3cOIvNmI0TjSMZrEnIE7no9+bpn+9E8Yvf9CIxwnH/cjN OMCOO9+7UM4Vd1KaFNNpzqnDrT3Ke2Ge0ML4QB1WGgRabJ+sqWmfheyRe7KCOMd1y3ui sKLGsEPdAsO3WLsIvk+IcyBfVmQkEtPc8kG2QUfGdvcllD4/f+SMxslx74uBuSDVnPTm PFWi9UIAM+PEyABcO1JtRXAehncEJANHnR/cDbrRIFq2kKBSZElyW3fker9Xo6vjfOHp 88Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=NTJYwbFa+MftD71IArQbB9W+Ud5QNNH8RKefVsoGH8M=; b=as1NyKUoddeDBgfy81NOAmddDA2+2gQ/Vq1wuzg4dqwISRWBr6P5WG8bLiYbCNJbBr eNzU5Q8OQnJcJ53eSIe0YbXouFw8+ZrXUQ9OnuJEjyVOxZoJakWGHacHENCpa2R9I8kP KQzBCXDJpAnIXzz4sRLFVLASmY5fyPbi1hE8uaOqydxHR+JIjx/I0J7pYP+5+ZlXYzhU 5oxneCdVBESCnt3osf7v9zIb0JISM9rmQWdq06o5EkMHYjy09pcUWL1NPbZ9wT62jQZw ZdgM9YQ6tDeqzTA07mS9orF04RUJAP7Utx+wwtDKNn1HyC4b1sP3nTZd7cKxzi/90Gs7 7cGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=i0pZ28xX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 99-v6si1411801plc.601.2018.03.20.04.23.13; Tue, 20 Mar 2018 04:23:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=i0pZ28xX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752860AbeCTLWY (ORCPT + 99 others); Tue, 20 Mar 2018 07:22:24 -0400 Received: from mail-pl0-f68.google.com ([209.85.160.68]:44904 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752670AbeCTLWT (ORCPT ); Tue, 20 Mar 2018 07:22:19 -0400 Received: by mail-pl0-f68.google.com with SMTP id 9-v6so761279ple.11 for ; Tue, 20 Mar 2018 04:22:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NTJYwbFa+MftD71IArQbB9W+Ud5QNNH8RKefVsoGH8M=; b=i0pZ28xXfipMT/ciWPm3+hD6y5pFKGur46aTXnQUK8Bzwbj4qcWs+VEH5pFFu0mp6E efaNkLuqJayQcJClR7wfcEZE5AJVPqqlqyx2T3Beup17GUNKTgE5Yql+9H+TzUwU0+vB PzRtFh9W0O/XGKxUyCNNHUV7KHbbji2FVOuhs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NTJYwbFa+MftD71IArQbB9W+Ud5QNNH8RKefVsoGH8M=; b=tzR8ZDzTGoSqP/zm1x/EkiaI3mIrC8xVN/vFOU6ZgYxsbDL8jA7NJovsI76YFzveUG ELjClMsyR++SwQ9VOGVMUETA1FejTgNf/946GBpvtlQeKO0CnWMoIbgpEt5WPZwUDcD9 slsMrXJ1pAUqqvdOCFA2dLW7HPMCohrmV77r/QU6BSQJ4jskVW27TzGRZ028QjTGdES0 J0BlaUMEbV9mjVvNuOa+l1rzazz2hK11V5B4Q2Z0AKDllVHcqhdmCCvAkouQV7Qp8S5h M5/Pg77xhbQiAggaIjdPlVByOHZSoCN/OSMSW2FYQjvXgyv8bhimoMrO13zF+r7xXyDG qczw== X-Gm-Message-State: AElRT7EaXkUbH58F+FPoMZC/LGH1WwzeC4jEhHMEQVrshZh0/iw0yzcj W+978WjshUq5SZdEe4SW4jreEw== X-Received: by 2002:a17:902:b943:: with SMTP id h3-v6mr16138888pls.1.1521544939394; Tue, 20 Mar 2018 04:22:19 -0700 (PDT) Received: from holly.lan ([218.255.99.6]) by smtp.gmail.com with ESMTPSA id u22sm2557311pgv.77.2018.03.20.04.22.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Mar 2018 04:22:18 -0700 (PDT) Date: Tue, 20 Mar 2018 19:22:12 +0800 From: Daniel Thompson To: Enric Balletbo Serra Cc: Enric Balletbo i Serra , Doug Anderson , Pavel Machek , Rob Herring , Jingoo Han , Richard Purdie , Jacek Anaszewski , Brian Norris , Guenter Roeck , Lee Jones , Alexandru Stan , linux-leds@vger.kernel.org, "devicetree@vger.kernel.org" , linux-kernel , kernel@collabora.com Subject: Re: [PATCH v3 0/4] backlight: pwm_bl: support linear interpolation and brightness to human eye Message-ID: <20180320112212.2mwthxug3pu7uqgg@holly.lan> References: <20180208113032.27810-1-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180223 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 19, 2018 at 05:04:31PM +0100, Enric Balletbo Serra wrote: > Hi Daniel, > > Gentle ping for this series, there is any possibility you have a > chance to review it? Let me know if you want I change something. I haven't got it in my TODO backlog... which means either I mistakenly deleted it when it went through originally or that I deliberately deleted it because I thought a v4 was coming along soon. I could go diving through the archives if I need to but were there other pending changes for this patchset? Daniel. > > Thanks, > Enric > > 2018-02-08 12:30 GMT+01:00 Enric Balletbo i Serra > : > > Dear all, > > > > This series is a third patchset integrating the requested changes. > > > > The first and second patch what tries to solve is the problem of > > granularity for high resolution PWMs. The idea is simple interpolate > > between 2 brightness values so we can have a high PWM duty cycle (a > > 16 bits PWM is up to 65535 possible steps) without having to list > > out every possible value in the dts. I think that this patch is > > required to not break backward compability, to be more flexible and > > also extend the functionality to be able to use high resolution PWM > > with enough steps to have a good UI experience in userspace. > > > > The thirth and fourth patch is a bit more ambicious, the idea is let > > decide the driver the brightness-levels required in function of the PWM > > resolution. To do this create a brightness-levels table filled with the > > CIE 1931 algorithm values to convert brightness to PWM duty cycle. > > > > More detailed info is available in the commit message of every patch. > > > > Both functionalities were tested on a Samsung Chromebook Plus (that has > > a 16 bits PWM) and a SL50 device (with a 8 bits PWM) > > > > Waiting for your feedback. > > > > Best regards, > > > > Enric Balletbo i Serra (4): > > backlight: pwm_bl: linear interpolation between brightness-levels > > dt-bindings: pwm-backlight: add a num-interpolation-steps property. > > backlight: pwm_bl: compute brightness of LED linearly to human eye. > > dt-bindings: pwm-backlight: move brightness-levels to optional. > > > > .../bindings/leds/backlight/pwm-backlight.txt | 34 ++- > > drivers/video/backlight/pwm_bl.c | 232 +++++++++++++++++++-- > > 2 files changed, 246 insertions(+), 20 deletions(-) > > > > -- > > 2.15.1 > >