Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S273345AbTHKU3u (ORCPT ); Mon, 11 Aug 2003 16:29:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S273403AbTHKU3u (ORCPT ); Mon, 11 Aug 2003 16:29:50 -0400 Received: from electric-eye.fr.zoreil.com ([213.41.134.224]:27273 "EHLO fr.zoreil.com") by vger.kernel.org with ESMTP id S273345AbTHKU3s (ORCPT ); Mon, 11 Aug 2003 16:29:48 -0400 Date: Mon, 11 Aug 2003 22:27:55 +0200 From: Francois Romieu To: Zwane Mwaikambo Cc: Marcelo Tosatti , linux-kernel@vger.kernel.org, torvalds@osdl.org, axboe@suse.de Subject: Re: test3 oops on Compaq 8500R Message-ID: <20030811222755.C1246@electric-eye.fr.zoreil.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from zwane@linuxpower.ca on Mon, Aug 11, 2003 at 03:13:11PM -0400 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1181 Lines: 35 Zwane Mwaikambo : [...] > NULL disk->queue->queuedata, what does the following (possibly > fundamentally flawed) patch do? Hmmm... DAC960_Probe() -> DAC960_DetectController() -> for (i = 0; i < DAC960_MaxLogicalDrives; i++) { Controller->disks[i] = alloc_disk(1<disks[i]) goto Failure; Controller->disks[i]->private_data = (void *)i; Controller->disks[i]->queue = Controller->RequestQueue; } -> DAC960_InitializeController() -> DAC960_RegisterBlockDevice() -> RequestQueue = blk_init_queue(DAC960_RequestFunction,...); if (!RequestQueue) { unregister_blkdev(MajorNumber, "dac960"); return false; } Controller->RequestQueue = RequestQueue; Controller->disks[i]->queue = ... should be done once Controller->RequestQueue is set imho. -- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/