Received: by 10.213.65.68 with SMTP id h4csp478088imn; Tue, 20 Mar 2018 07:50:38 -0700 (PDT) X-Google-Smtp-Source: AG47ELt5LzGDk7v6d5m0N5tr1N9I8CrFc4z84z6ULx0pKOIJsR1CP1LY3ULF6ulq2Jvsm/NHphk6 X-Received: by 2002:a17:902:8c8e:: with SMTP id t14-v6mr7583675plo.206.1521557438773; Tue, 20 Mar 2018 07:50:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521557438; cv=none; d=google.com; s=arc-20160816; b=F2CTVE2qKq1x/2Cb8rhYH3yi0leEUC/utDbjgqHHj301cXqpJzf4uHnLhhRmZTLgoK fjLiWFa8wrO7L1RkOS4dZMd6ITamN5cdMlUu7MqdtWeIaE86E6fEnQjUC0izV74QByhq MDVBEe/Dt/JpJF9clYtHN3NjcQ1CU2w8OOwGWTyxHrTU5bbXZaMKGdJ2rhEPV+DHdkTt ltHQVbNV82zJBe2Tdq/IKaSgo9Y115K2dLcNzd5wgV0L72cErmZgieLaSPaTIO44H6oR VuAe1MvmPcqBc0JOh/SWdAsDg+5MfjaCQKmOFNI1q9l60MsM+czIpWnkVdaOBaFXJbDS W6OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=k/E00IfDNT9fB0312LUoOj81/bFLbD3v5jhhN+lS+mk=; b=dFSy9madLLcmrpVgQw5aL08T/sXbIna8jNHCuQR2xH/1a6/4WRlpMrKFoY7PT7p1D7 uDJmiUmppCQ3erTfrEd6d/iQHgtktdnWuavbMkbSQv8+4GW2SzQW+NUkCDARIm6TErO5 cif4ZEFtcwxSJGQR+FKNXadE7NjwLRZeXM5YwolljVzClZVo8QdY18F2+EMY2uX8Qd9x mgJxyeEAgD3zgu55+8EPyuNy9gnkiE9nFLVg8TDM8T2/vr9XqBqnPYC5f/bNXEoSIGsS BbiHdATPEVjYHsynZlL4MXtk/baw7SBNTyBrpx6hX85q+R1I+c4h8hHLP+DBFO+nHLM4 q0Sw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l8si1393187pff.237.2018.03.20.07.50.24; Tue, 20 Mar 2018 07:50:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751661AbeCTOsF (ORCPT + 99 others); Tue, 20 Mar 2018 10:48:05 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:55238 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751269AbeCTOsA (ORCPT ); Tue, 20 Mar 2018 10:48:00 -0400 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B1C6D1425ED4C; Tue, 20 Mar 2018 07:47:59 -0700 (PDT) Date: Tue, 20 Mar 2018 10:47:59 -0400 (EDT) Message-Id: <20180320.104759.796804827689233281.davem@davemloft.net> To: liran.alon@oracle.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, idan.brown@oracle.com, yuval.shaia@oracle.com Subject: Re: [PATCH] net: dev_forward_skb(): Scrub packet's per-netns info only when crossing netns From: David Miller In-Reply-To: <1520953642-8145-1-git-send-email-liran.alon@oracle.com> References: <1520953642-8145-1-git-send-email-liran.alon@oracle.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 20 Mar 2018 07:48:00 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Liran Alon Date: Tue, 13 Mar 2018 17:07:22 +0200 > Before this commit, dev_forward_skb() always cleared packet's > per-network-namespace info. Even if the packet doesn't cross > network namespaces. There was a lot of discussion about this patch. Particularly whether it could potentially break current users or not. If this is resolved and the patch should still be applied, please repost and the folks involved in this dicussion should add their ACKs. Thanks.