Received: by 10.213.65.68 with SMTP id h4csp557657imn; Tue, 20 Mar 2018 09:33:19 -0700 (PDT) X-Google-Smtp-Source: AG47ELvY2SGPBuVWwqmbeMx1tFH+C//3k/vWzzkpF36iuPtg+zFeKI+67CIa/VElXotRd55pb89N X-Received: by 10.98.41.134 with SMTP id p128mr14246158pfp.120.1521563599756; Tue, 20 Mar 2018 09:33:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521563599; cv=none; d=google.com; s=arc-20160816; b=fpYEoA7fkqsxjH4Txje4vVSvEmElWL9jsnbObrw2j1ggNMbGJFDmJ+XONlpV4JFhb/ vv/2U6jGi3pvh+QnOqHlf2ivgis9YFLqTq1w/M3JKgDHdgIy3Kw88uXY4XGXnnnGJXk+ /x01pn6YEP+fTg3RO1Bi94GwG8y3CzXc6NnCRf/ObAshoRQn0JI7TOO6UQVkZlYE2PnN O3GoSrCcCqbni52cyBs5cqs3p7Sf9w6UVBwUbu3sUqVJk5mWPif/wYqFFYt1BP5HHezx LKIdzWPDHKLBjwrSmmiRZyP5ViHLZ+EPnlSlDAFWxI7Q9GOwvag065EduwoML0M2XAmJ pHCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=+aDqXPyY50HKXScoUW9KBkIAl/ky75cgmQ3yO2fKfug=; b=rrqAkegSAnHkU7ryrPFj1pHuCdZBn6iKFd/b5P7EoYCISAi1BCNu0JSjeIE8Tt7kjj ee4Nt4B0rARdAre6QG3wkNT3UD7/dYL6eeLBJ94CHxqXtx79E2uWt7nt9wCzT7UG9xQL ek3yYLVMHBjyBFBgKe9bpzjawQMJ9HW7hnpUr6YVf+hIUYWuFW4tbzFdvHakc+Ly6ka+ 2cogn94XDoO+nnVs2ls1RmDszoZEO/fh3TFidP9GGuNqeLDaCbKdgXcOkJV1PCgmKs5t CmQnTu/Ayp85Gf5uq2BOgqx5U3eUopQlUUZAsu/Ae1ml10Z61XG8QHq6w6TSISvjnUVo 5E9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nexb-com.20150623.gappssmtp.com header.s=20150623 header.b=yDjHB9Wf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bc11-v6si1861066plb.43.2018.03.20.09.33.02; Tue, 20 Mar 2018 09:33:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nexb-com.20150623.gappssmtp.com header.s=20150623 header.b=yDjHB9Wf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751680AbeCTQa4 (ORCPT + 99 others); Tue, 20 Mar 2018 12:30:56 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:39490 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751348AbeCTQay (ORCPT ); Tue, 20 Mar 2018 12:30:54 -0400 Received: by mail-wr0-f193.google.com with SMTP id c24so2352964wrc.6 for ; Tue, 20 Mar 2018 09:30:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+aDqXPyY50HKXScoUW9KBkIAl/ky75cgmQ3yO2fKfug=; b=yDjHB9Wfl9gMx45LZ43q/XL/hy6qouXDXm4sNa1fGgQzplw4X3XXuIIkVLohyMFZiM nMkCoZs8uEUYWmmgYTF6r5EXOFMIoXHYVtkvCshnKZSqTllAmLMI5H1sJpir8qhpq0h1 rlLwh0FWTKS1cIfSSNmTmASqziU7AH19Uq0PqKzlgRUhiBCzRFpJ4E3dEOErJdFZZb0i Q4u0sEvcA6htEdGW+KA91de9CMLv5BZe60CpoUo/SgEW1X0OVIxsuS5Qtiai9pI2yhIL kI1mBpMADUHaZgGM2xVRCubWww4jtKR2Kznt/7puAjwyPEnI4j+0Pn9esVikQvaQJkFK n4lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+aDqXPyY50HKXScoUW9KBkIAl/ky75cgmQ3yO2fKfug=; b=ZaZcHSAiKiZS92DXmKE4hOaKZzEgRBs/e89CphLpJFPKdmpZ0sSY3ELrdTPas4e4/X ZOhbP1ETQuEIi7syGNU/ef06nUpt30T7SBjeYrEgckecoBXrcSWEj0qUn4sD88hjm2U0 GRyJvrmtZmp38aHxtQfzYnNUA+SoEEywEGPJa08LKWV7bsaZ8gMb1EUS397188k8HBmx A2tsEqfV6f6DAHYyWJVnLXumGgkSg9R6Ed2MjN0kvAIFRPW5KsNHQPe599aSDmGJRCZ6 i8G/2LP4AS+jVfSkjDHC7lnn2Zok66qvlTJMVLMTD59kg3dRrt7Nnz0KhRWujIsFqcz2 mbVg== X-Gm-Message-State: AElRT7FGRBW6ZIbTtdvg3DdqJ8KqIas6DwynbYJUggRy5ie6sQRe1Tk5 BBZp464WDUdBwHrfSjD4gwuIczhlBWjVWsBIkJaT5Q== X-Received: by 10.223.225.137 with SMTP id k9mr12806844wri.247.1521563453088; Tue, 20 Mar 2018 09:30:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.195.199 with HTTP; Tue, 20 Mar 2018 09:30:12 -0700 (PDT) In-Reply-To: References: From: Philippe Ombredanne Date: Tue, 20 Mar 2018 09:30:12 -0700 Message-ID: Subject: Re: [PATCH 1/5 v4] add compression algorithm zBeWalgo To: Benjamin Warnke <4bwarnke@informatik.uni-hamburg.de> Cc: Linux Crypto Mailing List , LKML , Herbert Xu , "David S. Miller" , minchan@kernel.org, ngupta@vflare.org, Sergey Senozhatsky Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Benjamin, On Tue, Mar 20, 2018 at 7:04 AM, Benjamin Warnke <4bwarnke@informatik.uni-hamburg.de> wrote: > zBeWalgo is a completely new algorithm - Currently it is not published > somewhere else right now, googleing it would not show up any results. The > following section describes how the algorithm works. > diff --git a/lib/zbewalgo/zbewalgo.c b/lib/zbewalgo/zbewalgo.c > new file mode 100644 > index 000000000..ef922bc27 > --- /dev/null > +++ b/lib/zbewalgo/zbewalgo.c > @@ -0,0 +1,723 @@ > +/* > + * Copyright (c) 2018 Benjamin Warnke <4bwarnke@informatik.uni-hamburg.de> > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License version 2 as published by > + * the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, but WITHOUT > + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for > + * more details. > + * > + * You should have received a copy of the GNU General Public License along with > + * this program. > + * Would you mind using SPDX ids [1] instead of this fine boilerplate here and throughout your patches? > +MODULE_LICENSE("GPL"); > +MODULE_DESCRIPTION("zBeWalgo Compression Algorithm"); Here your MODULE_LICENSE does not match your top level license. See module.h [2] for a description of values: GPL would mean "GNU Public License v2 or later" whereas your top level license (best expressed with SPDX) would mean GPL-2.0 and no other version. To avoid confusion, you would need to state the same thing in the MODULE_LICENSE and your SPDX tags. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/module.h#n175 -- Cordially Philippe Ombredanne