Received: by 10.213.65.68 with SMTP id h4csp561581imn; Tue, 20 Mar 2018 09:39:07 -0700 (PDT) X-Google-Smtp-Source: AG47ELsUS+oZ+HofM0y0ata64gchPatb63sNnfLE8gztEbveSJFO53M9E1Gprk1HY3XzOD8ifNbS X-Received: by 10.99.123.86 with SMTP id k22mr12585208pgn.228.1521563947832; Tue, 20 Mar 2018 09:39:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521563947; cv=none; d=google.com; s=arc-20160816; b=lJCY8cxZSkg8cC69pIlKh8ySwRQF96IngQXfCrdvNyP8y3BJ+uOTFUp639nKo2ukAX QxnDDib76TG8LczyMp+9hfB1qMLQaCyVpgSh9FI6kYH++18N9pNNgb0UiDM6PoirmZz3 PtAC8HolvYrMqcdguHl6/Hk1ks+M5/L4XhCtBO02cnxlhwcMsrvZDbMAA+g9NKZCmlzt +39dkKjonI+kfnpZluO5QEYh+bKpucJVWFieoZ61oBb1JWMw9XGIgG43aO1cA27fZi6H dCZWYK8T0tNNcW1HhCTKhiRCyIo/w+9Ljm4EUJPyCW4pHKOsE8lCP2+5nq+FQKLMoumj LHtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:to:subject:cc :arc-authentication-results; bh=FHqUH6/G4A8Sl4mJ75BKS/MkjsLP2EsIR/0/pQWekHg=; b=XnCgGj3hKIlzXil0jXxti+d4pVIAHcv4f4xeuvrv9s13/qqEPkk44cJQhT9Q7TCTAX pqJpAD+0fMKANuX45GTwDda0xS5FapEmkkJIgVXKW5rhtUBoXsrEry0B8loZUE8R5sVr QUG4/s1YSR6Yt7tNYSfMyEjuBvfdRiV67nqrLE6xJGXuvwIqDoa1gWdvsVIJZct0rkor wOMX2iWAOpylil0P2xG14RyxysNB8eVktaXQccCsRofiIkG/ESGyXN6zs1KpOSrOzsFB vHkP/nC+dNpmE79eW1Bx9UphxX9PL+d8aK4A+Zvg2qYyRVroaKAA34iU51gRR0ckrfmn POpg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j12si1407832pgn.770.2018.03.20.09.38.53; Tue, 20 Mar 2018 09:39:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751533AbeCTQgg (ORCPT + 99 others); Tue, 20 Mar 2018 12:36:36 -0400 Received: from foss.arm.com ([217.140.101.70]:42744 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751186AbeCTQgd (ORCPT ); Tue, 20 Mar 2018 12:36:33 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CB6B61529; Tue, 20 Mar 2018 09:36:32 -0700 (PDT) Received: from [10.1.210.28] (unknown [10.1.210.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0C9603F487; Tue, 20 Mar 2018 09:36:31 -0700 (PDT) Cc: Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware: arm_scmi: prevent accessing rate_discrete uninitialized To: Anders Roxell References: <20180316114442.9536-1-anders.roxell@linaro.org> From: Sudeep Holla Organization: ARM Message-ID: <2f747a8a-3649-b78a-e4f3-4bd8fba66e60@arm.com> Date: Tue, 20 Mar 2018 16:36:30 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180316114442.9536-1-anders.roxell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Anders, On 16/03/18 11:44, Anders Roxell wrote: > gcc-5.3 and earlier warns that rate_discrete maybe-uninitialized > ../drivers/firmware/arm_scmi/clock.c:185:5: warning: 'rate_discrete' > may be used uninitialized in this function [-Wmaybe-uninitialized] > if (rate_discrete) > ^ > ../drivers/firmware/arm_scmi/clock.c:128:7: note: > 'rate_discrete' was declared here > bool rate_discrete; > ^ > Thanks for the fix, applied. -- Regards, Sudeep