Received: by 10.213.65.68 with SMTP id h4csp572434imn; Tue, 20 Mar 2018 09:55:40 -0700 (PDT) X-Google-Smtp-Source: AG47ELvJ10wc/XY5fCFsr9fAj4ANhvQk6VUYfekOXcBG/PmvrjmSTHbxFrZj2W/TqkIhW8Oag4Qj X-Received: by 10.99.36.193 with SMTP id k184mr12529191pgk.80.1521564940499; Tue, 20 Mar 2018 09:55:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521564940; cv=none; d=google.com; s=arc-20160816; b=LOQ3fyPEs/m5hMGmZCBOieHzOrkSbBp7jRFAEBvgnjnqKUeb0G93FVV9baYJBxyiY4 kMQeObiRPgWGt6uyTUeO2SD4cS7jmcYLWYf3joTDk4HDUI+vsH1fvKHMCX+QWqpru/1X mN8y7T4av8xEVkgT9tyzEITzAz7EfRG8BIGuJaCRQiOBDI3E/rGFKpAxdZ7bkcQRmZsS 0NnFQIi8lGxHw09DkkhRB/VcanidP1LHzxGUzX83wP09GCxZObDx/OBAcbd9z8/OAlP7 sAsllUAmE+5TWBZ0sSPhC6FVOWa7CejERbCJR9FDmON5VN0iXL9/ybhALdgwyJz9ej4l 5bjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version:dmarc-filter:arc-authentication-results; bh=XTSlg71ogFsGpatRHU279VxpT2iYQc29wWabhP0BtJM=; b=zsy1J2mIM0CB4n8RgnXZmrrP+0dQonHCL2yMNvcmW8TlvoBRfslY7vgeRpHbFmBc2N SMBdJoidud8I+6N9zZHL+CsxwVWTtCax3wILvOAwva0btSRCNvLhus6jbmHycrcmjvuq SN1EZ4vQdvZtefD35O9psTugrIr2KqddSKJETiWQ5iXVwW/sKAT6eFIe4QwJ5D8HibCV yE8wPWBIcWajaJ53wxwjOm0MgK+GRy9dVsrvj0pgUUZtkQnF8l+aohSfYuI0FEsiNX+S D7ew7m09lgL82JZ4bOPeHuIGovu+Z/bbM0wEJr7cwLGvdpRrXIpHKckElwXJxoffoq5s QPCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b63si1446376pgc.72.2018.03.20.09.55.25; Tue, 20 Mar 2018 09:55:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751688AbeCTQyT convert rfc822-to-8bit (ORCPT + 99 others); Tue, 20 Mar 2018 12:54:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:46794 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751626AbeCTQyQ (ORCPT ); Tue, 20 Mar 2018 12:54:16 -0400 Received: from localhost (unknown [104.132.1.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 073A221770; Tue, 20 Mar 2018 16:54:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 073A221770 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=sboyd@kernel.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: David Lechner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org From: Stephen Boyd In-Reply-To: <1521168778-27236-19-git-send-email-david@lechnology.com> Cc: Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Sekhar Nori , Kevin Hilman , Bartosz Golaszewski , Adam Ford , linux-kernel@vger.kernel.org, David Lechner References: <1521168778-27236-1-git-send-email-david@lechnology.com> <1521168778-27236-19-git-send-email-david@lechnology.com> Message-ID: <152156485535.183971.1627687499726447092@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: Re: [PATCH v8 18/42] clk: davinci: New driver for TI DA8XX CFGCHIP clocks Date: Tue, 20 Mar 2018 09:54:15 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting David Lechner (2018-03-15 19:52:34) > + > +typedef int (*da8xx_cfgchip_init)(struct device *dev, void __iomem *base); Should be struct regmap *regmap? I've squashed this in. diff --git a/drivers/clk/davinci/da8xx-cfgchip.c b/drivers/clk/davinci/da8xx-cfgchip.c index 858d3786b27b..c971111d2601 100644 --- a/drivers/clk/davinci/da8xx-cfgchip.c +++ b/drivers/clk/davinci/da8xx-cfgchip.c @@ -736,7 +736,7 @@ static const struct platform_device_id da8xx_cfgchip_id_table[] = { { } }; -typedef int (*da8xx_cfgchip_init)(struct device *dev, void __iomem *base); +typedef int (*da8xx_cfgchip_init)(struct device *dev, struct regmap *regmap); static int da8xx_cfgchip_probe(struct platform_device *pdev) {