Received: by 10.213.65.68 with SMTP id h4csp944165imn; Tue, 20 Mar 2018 21:11:11 -0700 (PDT) X-Google-Smtp-Source: AG47ELv48Z6GME15jANyfJel1hXAraPT17U6k+x9Koz8WVkvxxLbOfY0Qq5vOpsY5Kr0cFdVOx7Y X-Received: by 10.98.198.146 with SMTP id x18mr15709008pfk.22.1521605471896; Tue, 20 Mar 2018 21:11:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521605471; cv=none; d=google.com; s=arc-20160816; b=G8VZ4TOao9R74TEiXHcZlycos2FfiUowAO742PcyqNYrDJ6oJEs0KoVjlJVI6AU7uo sNYPEG7ltun4k6zaC0lAQOzw6+jWZf8DE749dIkD/eRNtQlQtmYV/fSZGkHF65ZNgnHm wYcr06+MF7T859ETrbXXV0WUWvD8XDAikI2uiN9qrKPBBO3sQAeAaLFnHRmLwGY82RGy szp4nc6P5zNTDzmIlhTKCsPsYjqMwC3AMU5y1J3tE9GpaUcPiUDIwrIWjNzAiEFoNPy4 Do6LEPbK1mgehR496fLisPc2LRu8gqf6skUqKfMhLjmsJe+GLhQNA8B90iS2Vwi+BU6F nymw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=PRtHGjdE7DKxukR52bj2KVy5XYpPY2IaIdTHhuPu1dE=; b=MR/36eAnfJIFhFGMHJDVpxEr3lUFHrASc9/AZWzUeZAfPM4zi8VrbOllAKu5+42fNf 4b/J9rjQQM9Aqpdqyz8N8iMKplrzD7BRa2H3HpmBTzW70zZsO3mub6aW4aczwfUiaWfS 6vlBt5+3+OzN6DxecMmqbC+iLSN9C5QxTLznRI3U5O3/BLhRWs2uHHmF4IU995y1kVBP 3yDuz7ogmRr/04R9VwGDhh77RwaFcdy7BY2Zff/ElyfbrQxz4eMGyPbNSuggQAYM5Ojh IkYzPg31yceXEvbU9kh56zgjicYrBMgGoTOVUD89LjrcStygEcJrisOsYy6kAqrHl0Pm ggnw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d4si2155157pgv.560.2018.03.20.21.10.57; Tue, 20 Mar 2018 21:11:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751340AbeCUEKH (ORCPT + 99 others); Wed, 21 Mar 2018 00:10:07 -0400 Received: from bastet.se.axis.com ([195.60.68.11]:36274 "EHLO bastet.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750AbeCUEKE (ORCPT ); Wed, 21 Mar 2018 00:10:04 -0400 Received: from localhost (localhost [127.0.0.1]) by bastet.se.axis.com (Postfix) with ESMTP id 69744183EB; Wed, 21 Mar 2018 05:10:03 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at bastet.se.axis.com Received: from bastet.se.axis.com ([IPv6:::ffff:127.0.0.1]) by localhost (bastet.se.axis.com [::ffff:127.0.0.1]) (amavisd-new, port 10024) with LMTP id uK-eNwBZeFuK; Wed, 21 Mar 2018 05:10:02 +0100 (CET) Received: from boulder02.se.axis.com (boulder02.se.axis.com [10.0.8.16]) by bastet.se.axis.com (Postfix) with ESMTPS id 6AF1C183B3; Wed, 21 Mar 2018 05:10:02 +0100 (CET) Received: from boulder02.se.axis.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 47EA71A088; Wed, 21 Mar 2018 05:10:02 +0100 (CET) Received: from boulder02.se.axis.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3C7CB1A082; Wed, 21 Mar 2018 05:10:02 +0100 (CET) Received: from seth.se.axis.com (unknown [10.0.2.172]) by boulder02.se.axis.com (Postfix) with ESMTP; Wed, 21 Mar 2018 05:10:02 +0100 (CET) Received: from lnxartpec1.se.axis.com (lnxartpec1.se.axis.com [10.88.4.10]) by seth.se.axis.com (Postfix) with ESMTP id 2EC241638; Wed, 21 Mar 2018 05:10:02 +0100 (CET) Received: by lnxartpec1.se.axis.com (Postfix, from userid 20283) id 2679740197; Wed, 21 Mar 2018 05:10:02 +0100 (CET) Date: Wed, 21 Mar 2018 05:10:02 +0100 From: Niklas Cassel To: kishon@ti.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com Subject: Re: [PATCH v4 0/5] PCI endpoint 64-bit BAR fixes Message-ID: <20180321041001.GA29527@axis.com> References: <20180308133331.19464-1-niklas.cassel@axis.com> <20180319165234.GA12486@e107981-ln.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180319165234.GA12486@e107981-ln.cambridge.arm.com> User-Agent: Mutt/1.9.1+16 (8a41d1c2f267) (2017-09-22) X-TM-AS-GCONF: 00 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 19, 2018 at 04:52:34PM +0000, Lorenzo Pieralisi wrote: > On Thu, Mar 08, 2018 at 02:33:25PM +0100, Niklas Cassel wrote: > > PCI endpoint fixes to improve the way 64-bit BARs are handled. > > > > > > There are still future improvements that could be made: > > > > pci-epf-test.c always allocates space for > > 6 BARs, even when using 64-bit BARs (which > > really only requires us to allocate 3 BARs). > > > > pcitest.sh will print "NOT OKAY" for BAR1, > > BAR3, and BAR5 when using 64-bit BARs. > > This could probably be improved to say > > something like "N/A (64-bit BAR)". > > > > Niklas Cassel (5): > > PCI: endpoint: BAR width should not depend on sizeof dma_addr_t > > PCI: designware-ep: Make dw_pcie_ep_set_bar() handle 64-bit BARs > > properly > > PCI: designware-ep: Make dw_pcie_ep_reset_bar() handle 64-bit BARs > > properly > > PCI: endpoint: Make pci_epc_set_bar() return the BAR width that was > > set-up > > misc: pci_endpoint_test: Handle 64-bit BARs properly > > > > drivers/misc/pci_endpoint_test.c | 12 +++++++----- > > drivers/pci/cadence/pcie-cadence-ep.c | 2 +- > > drivers/pci/dwc/pcie-designware-ep.c | 22 ++++++++++++++++++---- > > drivers/pci/endpoint/functions/pci-epf-test.c | 22 +++++++++++++++------- > > 4 files changed, 41 insertions(+), 17 deletions(-) > > Niklas, > > I am fine with the series but I'd need Kishon ACKs (and Greg's for the > last patch), I am ready to queue them then. Hello Kishon, could you please have a look at this series? Kind regards, Niklas