Received: by 10.213.65.68 with SMTP id h4csp961673imn; Tue, 20 Mar 2018 21:54:01 -0700 (PDT) X-Google-Smtp-Source: AG47ELt2jhoccdnz6JgMLdhfAxvc7VScB57ikyLfNUPWMMT6nYAM5q/PxIjzBU9Y5vxw1S6ATgia X-Received: by 10.99.119.15 with SMTP id s15mr14172333pgc.211.1521608041408; Tue, 20 Mar 2018 21:54:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521608041; cv=none; d=google.com; s=arc-20160816; b=H3QTiEJwo38s+G6ojRgdNM8uup2AuQAqfBtXXiED0kFapZ6Q4oX80drd67CFHDrRmn e7kRl5RazWbMKXGRFK6UOkDPpgPSdnZwfYGtpzmrfzarAQRXBjVMwMZtATNlL86PZr/z Pp0R5XfgqLcevJ8L9Tbo9CF41zaVV4vHNMN2CJ8AGI3USiImcC/EZV3pJof1kV2afmgs y5CmLW5KHEMXyVY35Q04GUxZRc+o4M2ZbWQuLcwljT42WiC2FXHfyBGVMdRU/XB/Rx8F LoMDbTA/brC6pFgAA+NPhtJdmT194nXOgxhKFtd+fC/pEogp4ngFHDtuhtOb+Az+yT9X iKeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=pg9yq3Q6IIoI8aK3k02hO3LtVP1g8HuwSpanFCA0E3M=; b=LviG2+ByskBOwikttadpORQjQG4LUV07ejGTepM3xugpp7/X8oLwhQK4OHW0TeNy3l 9sbMR+4fB5dZkYQ2VTJmPDuH/33AwJz3YeyjS7bLb658olX8LqTV2o/Trdh4GRRidi2V BHsIZiz/XmpvZqQM5zk1K4a6ZsC2B56XZnxg5e9Lo3jHIZuuLJIhAAv6Rzhregv0Vhxr +wwCEntisY5zsbbyhrOcgwhIJmy6taoGnSQnc8qVxT0074VAhhMSAkTRfBdlNz0upIY2 ip4SBJ5ZmLUoWWrQyAzylhP9tU26qQ7gCHEv9NqQeTlrRx4R/YN8SqLboyJupzBCx5Sl 5GLg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q6si2237087pgt.130.2018.03.20.21.53.45; Tue, 20 Mar 2018 21:54:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751825AbeCUEww (ORCPT + 99 others); Wed, 21 Mar 2018 00:52:52 -0400 Received: from mga12.intel.com ([192.55.52.136]:44193 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751524AbeCUEws (ORCPT ); Wed, 21 Mar 2018 00:52:48 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2018 21:52:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,338,1517904000"; d="scan'208";a="27098032" Received: from aaronlu.sh.intel.com (HELO intel.com) ([10.239.159.135]) by orsmga008.jf.intel.com with ESMTP; 20 Mar 2018 21:52:45 -0700 Date: Wed, 21 Mar 2018 12:53:53 +0800 From: Aaron Lu To: "Figo.zhang" Cc: Linux MM , LKML , Andrew Morton , Huang Ying , Dave Hansen , Kemi Wang , Tim Chen , Andi Kleen , Michal Hocko , Vlastimil Babka , Mel Gorman , Matthew Wilcox , Daniel Jordan Subject: Re: [RFC PATCH v2 2/4] mm/__free_one_page: skip merge for order-0 page unless compaction failed Message-ID: <20180321045353.GC28705@intel.com> References: <20180320085452.24641-1-aaron.lu@intel.com> <20180320085452.24641-3-aaron.lu@intel.com> <20180321015944.GB28705@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 20, 2018 at 09:21:33PM -0700, Figo.zhang wrote: > suppose that in free_one_page() will try to merge to high order anytime , > but now in your patch, > those merge has postponed when system in low memory status, it is very easy > let system trigger > low memory state and get poor performance. Merge or not merge, the size of free memory is not affected.