Received: by 10.213.65.68 with SMTP id h4csp982708imn; Tue, 20 Mar 2018 22:40:40 -0700 (PDT) X-Google-Smtp-Source: AG47ELv7CZGxB0N8D8hhaaeArn/Ldu4hno0dDuW4aX2cCUGBIiv2REWH+vPBobUfyjR8kGRtWMwE X-Received: by 2002:a17:902:bf03:: with SMTP id bi3-v6mr19296188plb.343.1521610840634; Tue, 20 Mar 2018 22:40:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521610840; cv=none; d=google.com; s=arc-20160816; b=t5RYdVSLT6vBmQv+lKyHVlsVy+MH+z9X1Hv0EFP08LhYE4V2PkFgrWAQzivtezf4N2 R143rVMhKDUkqmMT3LSuIEKMEKLHPc/Ab+RbEA45SaDqmsB+dfShi63cEMBzTo2NOmXB GhPLcahddpcHpZ3h0PJm91+VWYxZGv7z00uWbYHIUExAMrP0Ow1sgYBadb/QPcbfLP/B dAisFPiho1lzjLZSpfG7FtC1p1lXwooeZR6LBaqHmdUA8YyfhAUOHH2e7MaXPEh7VofJ bhrQeoA1W5zFNE4mzvm781MUq7UAp8BZQq9TfjXZt4rCcA/TheoPinTNOqTW+++at0BX mSEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=fV/qIzI7Yo4bqiE8R8uQWr+mcFyhA0MohTW5iAFrxWs=; b=zqiOu8E8KvNhOqaYRrszztu3TnKbalBkjVSEMEn1kakIEA/NbgkN3zi8nza/UZODsi s8JHCNseCExpx0mtipRWPknJ9iHqBa95nf74Hsrdu36sAunu1cKspH5+YCv844qQoXBl YpLggvLkqOTdII36l+okslAtc803Ihrx3utIjDiXpnlPk+Lmwp6dMCyCUEWI6he/lypp dcSd32DGLjmwkgcxHedOyVowrspTP0V7eW7xJ5QJlEN2Jc6xPxLyI2B94IKPi8AZsLSl mOCofgY7gaIcHCzUg7WTDoMdsQQF1j70wh4SDw7fhC40wsCapY3KsPlJbQXvYLGDQaTt sGkQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d12si2020781pgq.491.2018.03.20.22.40.26; Tue, 20 Mar 2018 22:40:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751863AbeCUFiy (ORCPT + 99 others); Wed, 21 Mar 2018 01:38:54 -0400 Received: from mail.cn.fujitsu.com ([183.91.158.132]:49725 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751689AbeCUFix (ORCPT ); Wed, 21 Mar 2018 01:38:53 -0400 X-IronPort-AV: E=Sophos;i="5.43,368,1503331200"; d="scan'208";a="38028796" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 21 Mar 2018 13:38:50 +0800 Received: from G08CNEXCHPEKD02.g08.fujitsu.local (unknown [10.167.33.83]) by cn.fujitsu.com (Postfix) with ESMTP id 423094D0EFD1; Wed, 21 Mar 2018 13:38:47 +0800 (CST) Received: from localhost.localdomain (10.167.226.106) by G08CNEXCHPEKD02.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.361.1; Wed, 21 Mar 2018 13:38:46 +0800 Subject: Re: [PATCH 3/5] x86/smpboot: Make the check code more clear in prefill_possible_map() To: Peter Zijlstra CC: , , , , , , , , , References: <20180320110432.28127-1-douly.fnst@cn.fujitsu.com> <20180320110432.28127-4-douly.fnst@cn.fujitsu.com> <20180320123918.GS4043@hirez.programming.kicks-ass.net> From: Dou Liyang Message-ID: Date: Wed, 21 Mar 2018 13:38:44 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180320123918.GS4043@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset="gbk"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.167.226.106] X-yoursite-MailScanner-ID: 423094D0EFD1.A9689 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: douly.fnst@cn.fujitsu.com X-Spam-Status: No Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, At 03/20/2018 08:39 PM, Peter Zijlstra wrote: > On Tue, Mar 20, 2018 at 07:04:30PM +0800, Dou Liyang wrote: >> case 1: no | no | no | --> min (setup_possible_cpus, nr_cpu_ids, setup_max_cpus) >> case 2: no | no | yes| --> min (setup_possible_cpus, nr_cpu_ids) >> case 3: no | yes | no | --> 1 >> case 4: no | yes | yes| --> 1 >> case 5: yes | no | no | --> min (num_processors, nr_cpu_ids, setup_max_cpus) >> case 6: yes | no | yes| --> min (num_processors + disabled_cpus, nr_cpu_ids) >> case 7: yes | yes | no | --> 1 >> case 8: yes | yes | yes| --> 1 > > The case number is off by one ;-) > I got it! ;-?? Thanks dou > >