Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Cao jin <caoj.fnst@cn.fujitsu.com>
Subject: Re: questions about header.S
To:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>
CC:     <x86@kernel.org>, <linux-kernel@vger.kernel.org>
References: <ac02a918-0c7a-2376-569d-c53a87bc1a42@cn.fujitsu.com>
Message-ID: <b47b8ad8-4015-9437-d6b6-6e2d17ea117b@cn.fujitsu.com>
Date:   Wed, 21 Mar 2018 17:23:28 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <ac02a918-0c7a-2376-569d-c53a87bc1a42@cn.fujitsu.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Dear Maintainers,

  Could you help to give a hint?
  Thanks in advance.

-- 
Sincerely,
Cao jin

On 03/17/2018 06:01 PM, Cao jin wrote:
> Hi,
> 
>   I find two small questions which confuse me a little.
> 
> 1.
> # Check signature at end of setup
>        cmpl    $0x5a5aaa55, setup_sig
>        jne     setup_bad
> 
> setup_sig is defined in setup.ld, which points to the constant also
> defined in setup.ld, so I don't figure out in which case they don't
> equal and jump to setup_bad?
> 
> In my test, drop these 2 lines seems fine, system can boot without any
> obvious error.
> 
> 2.
> # Zero the bss
> 	movw	$__bss_start, %di
> 	movw	$_end+3, %cx
> 	xorl	%eax, %eax
> 	subw	%di, %cx
> 	shrw	$2, %cx
> 	rep; stosl
> 
> It is not a big deal, but I think replace "_end" with "__bss_end" make
> more sense, and "_end" is already aligned to word length. And, there is
> no other code use symbol "__bss_end". So I don't know is there any
> reason to use "_end" here?
> 
> In my test, replace the 2nd line with:
> 
> 	movw	$_end, %cx
> 
> or:
> 
> 	movw	$__bss_end+3, %cx
> 
> are both fine.
>