Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFC PATCH 0/3] Salted build ids via linker sections
To:     Laura Abbott <labbott@redhat.com>,
        Andy Lutomirski <luto@kernel.org>, mjw@fedoraproject.org,
        "H . J . Lu" <hjl.tools@gmail.com>,
        Masahiro Yamada <yamada.masahiro@socionext.com>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        X86 ML <x86@kernel.org>, linux-kernel@vger.kernel.org,
        Cary Coutant <ccoutant@gmail.com>
References: <20180321014635.29113-1-labbott@redhat.com>
From:   Nick Clifton <nickc@redhat.com>
Organization: Red Hat
Message-ID: <00fd0e10-2c64-7a19-dd01-ec1a4440933d@redhat.com>
Date:   Wed, 21 Mar 2018 09:40:22 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180321014635.29113-1-labbott@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Laura,

> This is an implementation of the counter proposal. If an environment variable
> is set, that value gets added as a .comment section to the necessary binaries.

This is not really my purview but ... can I just say that I really do not like
using environment variables to control build behaviour.  It makes reproducing a
build much harder.  Especially when you are trying to reproduce a bug report from
a user who does not even know that the environment variable exits.

Cheers
  Nick