Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   David Laight <David.Laight@ACULAB.COM>
To:     "'hariprasath.elango@gmail.com'" <hariprasath.elango@gmail.com>,
        "ruxandra.radulescu@nxp.com" <ruxandra.radulescu@nxp.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     "gehariprasath@gmail.com" <gehariprasath@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>
Subject: RE: [PATCH] staging: fsl-dpaa2: replace simple switch case by if
 statement
Thread-Topic: [PATCH] staging: fsl-dpaa2: replace simple switch case by if
 statement
Thread-Index: AQHTwQY99HFy4WEVM0a+/SD9vn9jDqPakoWQ
Date:   Wed, 21 Mar 2018 11:48:08 +0000
Message-ID: <faa92f0e20fc44019ee0b64b04413d69@AcuMS.aculab.com>
References: <20180321111604.9902-1-hariprasath.elango@gmail.com>
In-Reply-To: <20180321111604.9902-1-hariprasath.elango@gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-Authenticated_ID: 
X-PolicySMART: 3396946, 3397078
X-Virus-Status: Scanned by VirusSMART (c)
X-Virus-Status: Scanned by VirusSMART (s)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: > hariprasath.elango@gmail.com
> Sent: 21 March 2018 11:16
> From: HariPrasath Elango <hariprasath.elango@gmail.com>
> 
> Replace a couple of simple switch cases by if condition

Why?
In principle extra 'case' might be needed in the future.

...
> diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c b/drivers/staging/fsl-
> dpaa2/ethernet/dpaa2-ethtool.c
> index 070a3f2..fb517cb 100644
> --- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> +++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> @@ -171,8 +171,7 @@ static void dpaa2_eth_get_strings(struct net_device *netdev, u32 stringset,
>  	u8 *p = data;
>  	int i;
> 
> -	switch (stringset) {
> -	case ETH_SS_STATS:
> +	if (stringset == ETH_SS_STATS) {
>  		for (i = 0; i < DPAA2_ETH_NUM_STATS; i++) {
>  			strlcpy(p, dpaa2_ethtool_stats[i], ETH_GSTRING_LEN);
>  			p += ETH_GSTRING_LEN;
> @@ -181,18 +180,16 @@ static void dpaa2_eth_get_strings(struct net_device *netdev, u32 stringset,
>  			strlcpy(p, dpaa2_ethtool_extras[i], ETH_GSTRING_LEN);
>  			p += ETH_GSTRING_LEN;
>  		}
> -		break;
>  	}
>  }
...

	David