Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <faa92f0e20fc44019ee0b64b04413d69@AcuMS.aculab.com>
References: <20180321111604.9902-1-hariprasath.elango@gmail.com> <faa92f0e20fc44019ee0b64b04413d69@AcuMS.aculab.com>
From:   Denis Kirjanov <kirjanov@gmail.com>
Date:   Wed, 21 Mar 2018 15:17:51 +0300
Message-ID: <CAHj3AVkQMn26EGtYzu3R2TgDMAaijXoJXnAV3f94eUui6kWtJA@mail.gmail.com>
Subject: Re: [PATCH] staging: fsl-dpaa2: replace simple switch case by if statement
To:     David Laight <David.Laight@aculab.com>
Cc:     "hariprasath.elango@gmail.com" <hariprasath.elango@gmail.com>,
        "ruxandra.radulescu@nxp.com" <ruxandra.radulescu@nxp.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/21/18, David Laight <David.Laight@aculab.com> wrote:
> From: > hariprasath.elango@gmail.com
>> Sent: 21 March 2018 11:16
>> From: HariPrasath Elango <hariprasath.elango@gmail.com>
>>
>> Replace a couple of simple switch cases by if condition
>
> Why?
> In principle extra 'case' might be needed in the future.

I had the same question when saw it.
It's better to keep things as is.
>
> ...
>> diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
>> b/drivers/staging/fsl-
>> dpaa2/ethernet/dpaa2-ethtool.c
>> index 070a3f2..fb517cb 100644
>> --- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
>> +++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
>> @@ -171,8 +171,7 @@ static void dpaa2_eth_get_strings(struct net_device
>> *netdev, u32 stringset,
>>  	u8 *p =3D data;
>>  	int i;
>>
>> -	switch (stringset) {
>> -	case ETH_SS_STATS:
>> +	if (stringset =3D=3D ETH_SS_STATS) {
>>  		for (i =3D 0; i < DPAA2_ETH_NUM_STATS; i++) {
>>  			strlcpy(p, dpaa2_ethtool_stats[i], ETH_GSTRING_LEN);
>>  			p +=3D ETH_GSTRING_LEN;
>> @@ -181,18 +180,16 @@ static void dpaa2_eth_get_strings(struct net_devic=
e
>> *netdev, u32 stringset,
>>  			strlcpy(p, dpaa2_ethtool_extras[i], ETH_GSTRING_LEN);
>>  			p +=3D ETH_GSTRING_LEN;
>>  		}
>> -		break;
>>  	}
>>  }
> ...
>
> 	David
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>


--=20
Regards / Mit besten Gr=C3=BC=C3=9Fen,
Denis