Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "<Hariprasath Elango>" <hariprasath.elango@gmail.com>
Date:   Wed, 21 Mar 2018 18:35:57 +0530
To:     Denis Kirjanov <kirjanov@gmail.com>
Cc:     David Laight <David.Laight@aculab.com>,
        "hariprasath.elango@gmail.com" <hariprasath.elango@gmail.com>,
        "ruxandra.radulescu@nxp.com" <ruxandra.radulescu@nxp.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: fsl-dpaa2: replace simple switch case by if
 statement
Message-ID: <20180321130411.GA11639@hariprasath>
References: <20180321111604.9902-1-hariprasath.elango@gmail.com>
 <faa92f0e20fc44019ee0b64b04413d69@AcuMS.aculab.com>
 <CAHj3AVkQMn26EGtYzu3R2TgDMAaijXoJXnAV3f94eUui6kWtJA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHj3AVkQMn26EGtYzu3R2TgDMAaijXoJXnAV3f94eUui6kWtJA@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 21, 2018 at 03:17:51PM +0300, Denis Kirjanov wrote:
> On 3/21/18, David Laight <David.Laight@aculab.com> wrote:
> > From: > hariprasath.elango@gmail.com
> >> Sent: 21 March 2018 11:16
> >> From: HariPrasath Elango <hariprasath.elango@gmail.com>
> >>
> >> Replace a couple of simple switch cases by if condition
> >
> > Why?
> > In principle extra 'case' might be needed in the future.
> 
> I had the same question when saw it.
> It's better to keep things as is.
> >
> > ...

 Hi, since the switch statement had only one case,I thought of doing
 this. If there are plans to add more cases, we can leave it like
 that.

 thanks,
 hari

> >> diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> >> b/drivers/staging/fsl-
> >> dpaa2/ethernet/dpaa2-ethtool.c
> >> index 070a3f2..fb517cb 100644
> >> --- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> >> +++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> >> @@ -171,8 +171,7 @@ static void dpaa2_eth_get_strings(struct net_device
> >> *netdev, u32 stringset,
> >>  	u8 *p = data;
> >>  	int i;
> >>
> >> -	switch (stringset) {
> >> -	case ETH_SS_STATS:
> >> +	if (stringset == ETH_SS_STATS) {
> >>  		for (i = 0; i < DPAA2_ETH_NUM_STATS; i++) {
> >>  			strlcpy(p, dpaa2_ethtool_stats[i], ETH_GSTRING_LEN);
> >>  			p += ETH_GSTRING_LEN;
> >> @@ -181,18 +180,16 @@ static void dpaa2_eth_get_strings(struct net_device
> >> *netdev, u32 stringset,
> >>  			strlcpy(p, dpaa2_ethtool_extras[i], ETH_GSTRING_LEN);
> >>  			p += ETH_GSTRING_LEN;
> >>  		}
> >> -		break;
> >>  	}
> >>  }
> > ...
> >
> > 	David
> >
> > _______________________________________________
> > devel mailing list
> > devel@linuxdriverproject.org
> > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> >
> 
> 
> -- 
> Regards / Mit besten Gr??en,
> Denis