Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1521649863.23626.130.camel@codethink.co.uk>
Subject: Re: 4.9.80 compile failure with X86_VSYSCALL_EMULATION=n due to
 9a0be5af
From:   Ben Hutchings <ben.hutchings@codethink.co.uk>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
Cc:     LKML <linux-kernel@vger.kernel.org>
Date:   Wed, 21 Mar 2018 16:31:03 +0000
In-Reply-To: <20180321160424.GF18454@kroah.com>
References: <20180212154325.ge4walt2m6u3ef7g@csclub.uwaterloo.ca>
         <20180321160424.GF18454@kroah.com>
Organization: Codethink Ltd.
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2018-03-21 at 17:04 +0100, Greg Kroah-Hartman wrote:
> On Mon, Feb 12, 2018 at 10:43:25AM -0500, Lennart Sorensen wrote:
> > Commit 9a0be5af added a reference to vsyscall_pgprot in
> > arch/x86/mm/kaiser.c but that is undefined if X86_VSYSCALL_EMULATION=n
> > which on an embedded system where you know how all your software is
> > compiled is quite likely.
> > 
> > Of course the condition is always false with that config so the code
> > will never be run, but the compiler is unhappy.
> 
> What is the compiler error?  I have not had any reports of this with all
> of the varied builds that we currently run on the stable trees.

You already applied a fix for this ("kaiser: fix compile error without
vsyscall").

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.