Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S275085AbTHLGx5 (ORCPT ); Tue, 12 Aug 2003 02:53:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S275084AbTHLGx5 (ORCPT ); Tue, 12 Aug 2003 02:53:57 -0400 Received: from pub234.cambridge.redhat.com ([213.86.99.234]:1287 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S275083AbTHLGxy (ORCPT ); Tue, 12 Aug 2003 02:53:54 -0400 Date: Tue, 12 Aug 2003 07:53:53 +0100 From: Christoph Hellwig To: Andries Brouwer Cc: linux-scsi@vger.kernel.org, linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] oops in sd_shutdown Message-ID: <20030812075353.A18547@infradead.org> Mail-Followup-To: Christoph Hellwig , Andries Brouwer , linux-scsi@vger.kernel.org, linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20030812002844.B1353@pclin040.win.tue.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20030812002844.B1353@pclin040.win.tue.nl>; from aebr@win.tue.nl on Tue, Aug 12, 2003 at 12:28:44AM +0200 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 921 Lines: 17 On Tue, Aug 12, 2003 at 12:28:44AM +0200, Andries Brouwer wrote: > I see an Oops in the SCSI code, caused by the fact that sdkp is NULL > in sd_shutdown. "How can that be?", you will ask - dev->driver_data was set > in sd_probe. But in my case sd_probe never finished. An insmod usb-storage > hangs forever, or at least for more than six hours, giving ample opportunity > to observe this race between sd_probe and sd_shutdown. > (Of course sd_probe hangs in sd_revalidate disk.) Well, this same problem could show upb in any other driver. Could you instead send a patch to Pat that the driver model never calls the shutdown method for a driver that hasn't finished ->probe? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/