Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180321133256.GB21153@kroah.com>
References: <20180316152317.167709497@linuxfoundation.org> <CA+G9fYth+j=QNYM-6OBnxncfBruy6W7hXuw-Srt_RMSTqXQ=XQ@mail.gmail.com>
 <20180318102738.GF32470@kroah.com> <1521589759.23626.120.camel@codethink.co.uk>
 <20180321133256.GB21153@kroah.com>
From:   Naresh Kamboju <naresh.kamboju@linaro.org>
Date:   Wed, 21 Mar 2018 23:20:04 +0530
Message-ID: <CA+G9fYs6qkB84N1Ghu4aaZ25tzXy7DHjOiGkd+8icT+fqQR8UQ@mail.gmail.com>
Subject: Re: [PATCH 4.9 00/86] 4.9.88-stable review
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc:     open list <linux-kernel@vger.kernel.org>,
        Shuah Khan <shuahkh@osg.samsung.com>,
        lkft-triage@lists.linaro.org, patches@kernelci.org,
        linux- stable <stable@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Guenter Roeck <linux@roeck-us.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 21 March 2018 at 19:02, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Tue, Mar 20, 2018 at 11:49:19PM +0000, Ben Hutchings wrote:
>> On Sun, 2018-03-18 at 11:27 +0100, Greg Kroah-Hartman wrote:
>> > On Sat, Mar 17, 2018 at 03:48:24PM +0530, Naresh Kamboju wrote:
>> [...]
>> > > Results from Linaro=E2=80=99s test farm.
>> > > No regressions on arm64, arm, qemu_x86_64 and x86_64.
>> > >
>> > > NOTE:
>> > > CONFIG_LEGACY_VSYSCALL_EMULATE=3Dy is enabled from config as default=
.
>> > > Enabled vsyscall=3Dnative and vsyscall=3Dnone from kernel command li=
ne for testing
>> > > selftests/x86/test_vsyscall test case on x86_64 and qemu_x86_64.
>> > >
>> > > test_vdso_64 failed on x86_64 device when vsyscall=3Dnone is enabled=
.
>> > > We will investigate this new test failure.
>> >
>> > I think vsyscall=3Dnone just went away :)
>>
>> No, vsyscall=3Dnative went away upstream.  vsyscall=3Dnone should still
>> work everywhere.
>
> Ah, sorry, got that wrong, thanks for the correction.
>
>> However, test_vdso_64 isn't able to detect what the current
>> configuration is and it will crash with vsyscall=3Dnone (or the
>> equivalent default in kconfig).


Shall i skip running "test_vdso_64" when vsyscall=3Dnone ?
or
Shall we fix the test case to work when vsyscall=3Dnone ?

"test_vdso_64" test failed log when vsyscall=3Dnone on x86_64.
This is a combination of VSYSCALL_EMULATE=3Dy and kernel cmdline vsyscall=
=3Dnone
With this combination test PASS on qemu_x86_64 fails on real hardware.

[  744.132422] test_vdso_64[3957] vsyscall attempted with vsyscall=3Dnone
 ip:ffffffffff600800 cs:33 sp:7ffcf7192e18 ax:ffffffffff600800 si:7ffcf7192=
e4c
 di:7ffcf7192e40
[  744.146945] test_vdso_64[3957]: segfault at ffffffffff600800
 ip ffffffffff600800 sp 00007ffcf7192e18 error 15
[  744.157058] audit: type=3D1701 audit(1521968691.345:4): auid=3D429496729=
5
  uid=3D0 gid=3D0 ses=3D4294967295 subj=3Dkernel pid=3D3957 comm=3D\"test_v=
dso_64\"
  exe=3D\"/opt/kselftests/mainline/x86/test_vdso_64\" sig=3D11 res=3D1
./run_kselftest.sh: line 233:  3957 Segmentation fault
  (core dumped) ./test_vdso_64 > /tmp/test_vdso_64 2>&1
selftests: test_vdso_64 [FAIL]

>
> That's good to know.  Naresh, does that help out?

Yes it helps. Thanks

>
> thanks,
>
> greg k-h