Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] drm/i915/gvt: don't dereference 'workload' before null
 checking it
To:     Joe Perches <joe@perches.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        David Airlie <airlied@linux.ie>,
        intel-gvt-dev@lists.freedesktop.org,
        intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20180321190653.3829-1-colin.king@canonical.com>
 <1521659361.7999.27.camel@perches.com>
From:   Colin Ian King <colin.king@canonical.com>
Message-ID: <a0309d42-a2ab-9270-b486-2325522256b6@canonical.com>
Date:   Wed, 21 Mar 2018 19:18:28 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <1521659361.7999.27.camel@perches.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 21/03/18 19:09, Joe Perches wrote:
> On Wed, 2018-03-21 at 19:06 +0000, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The pointer workload is dereferenced before it is null checked, hence
>> there is a potential for a null pointer dereference on workload. Fix
>> this by only dereferencing workload after it is null checked.
>>
>> Detected by CoverityScan, CID#1466017 ("Dereference before null check")
> 
> Maybe true, but is it possible for workload to be null?
> Maybe the null test should be removed instead.

From what I understand from the static analysis, there may be a
potential for workload to be null, I couldn't rule it out so I went with
the more paranoid stance of keeping the null check in.

> 
>> Fixes: fa3dd623e559 ("drm/i915/gvt: keep oa config in shadow ctx")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>>  drivers/gpu/drm/i915/gvt/scheduler.c | 10 +++++++---
>>  1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gvt/scheduler.c b/drivers/gpu/drm/i915/gvt/scheduler.c
>> index 068126404151..f3010e365a48 100644
>> --- a/drivers/gpu/drm/i915/gvt/scheduler.c
>> +++ b/drivers/gpu/drm/i915/gvt/scheduler.c
>> @@ -60,9 +60,9 @@ static void set_context_pdp_root_pointer(
>>  static void sr_oa_regs(struct intel_vgpu_workload *workload,
>>  		u32 *reg_state, bool save)
>>  {
>> -	struct drm_i915_private *dev_priv = workload->vgpu->gvt->dev_priv;
>> -	u32 ctx_oactxctrl = dev_priv->perf.oa.ctx_oactxctrl_offset;
>> -	u32 ctx_flexeu0 = dev_priv->perf.oa.ctx_flexeu0_offset;
>> +	struct drm_i915_private *dev_priv;
>> +	u32 ctx_oactxctrl;
>> +	u32 ctx_flexeu0;
>>  	int i = 0;
>>  	u32 flex_mmio[] = {
>>  		i915_mmio_reg_offset(EU_PERF_CNTL0),
>> @@ -77,6 +77,10 @@ static void sr_oa_regs(struct intel_vgpu_workload *workload,
>>  	if (!workload || !reg_state || workload->ring_id != RCS)
>>  		return;
>>  
>> +	dev_priv = workload->vgpu->gvt->dev_priv;
>> +	ctx_oactxctrl = dev_priv->perf.oa.ctx_oactxctrl_offset;
>> +	ctx_flexeu0 = dev_priv->perf.oa.ctx_flexeu0_offset;
>> +
>>  	if (save) {
>>  		workload->oactxctrl = reg_state[ctx_oactxctrl + 1];
>>