Received: by 10.213.65.68 with SMTP id h4csp568714imn; Thu, 22 Mar 2018 03:56:48 -0700 (PDT) X-Google-Smtp-Source: AG47ELtZWiIvj1aws5BqnE19o7+HuXCnF/bZQyS10fqo2mnUCi5JAY8TM13Z6Jh2tO2p9TCWUXbE X-Received: by 10.99.143.69 with SMTP id r5mr3606596pgn.159.1521716208426; Thu, 22 Mar 2018 03:56:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521716208; cv=none; d=google.com; s=arc-20160816; b=CGqypWUXnRR0WdcRY2GTCtTUAJKVVke/REdZCg/7ol9xsx1JQEv4lpd5cB5WZP+MKB m/GaNlEbjbsCPn1w9IHHH0rx+CHUKTLG2QMtpFsOT4W5gMR7jh3jDPC4Dya83MnA807U va5hAbl9gUd1Op1ml8OAeGbMz0TDbf1Nun+RCyhQ+0eNyz1B2HwbKsFiSuSzrr4+k7Z5 a+RH1CEMKhXSGZ26ogAas2VxrX9nT3HUX5gq39gSaacxeWu769odDopBY8Cc1sgQC/FS xP7cG++D/lt6YKV6eHLnonvxKxsMl/IloRGM21ClrhJwQCmNZQJ+E77iRxqjAHVaWRjp wU9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :from:references:cc:to:subject:arc-authentication-results; bh=bWTF4F2bEa42uDfJzkDAWsfGff9b+15hwtsNC+Vg6l8=; b=U7iZP86omlwdMNmRNzg6Pzv69RHPjb84Ki75lzPZjcqiSk9ULhjKlrOeqUahn8oUWF JwiUnF6uXsnnTuNy1JLGWRNwUNkZcVSlj8uXV3z/SNs95R5vr1ArSYIaNPsgx8IjWKOz 7iSPziBT3+BH+Trc465QrtpOkHGVVM691nFT9glkOWLWAKt6JySRuuGosJZpm/vdvJy8 nfSKrIavDdBv5ou2RCVGM0s9s8wZkR90SmnKGymRtkwogG396SHTamm6nxwRH99FByUC yLnfxliJXzduNjn7YuASYVttLwGvvO2f2f3vA77G6gAnSb+OkSXd929UN9H/MIBw8TA9 Mg5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z61-v6si3218286plb.200.2018.03.22.03.56.34; Thu, 22 Mar 2018 03:56:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754381AbeCVKr0 (ORCPT + 99 others); Thu, 22 Mar 2018 06:47:26 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:46232 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753802AbeCVKrX (ORCPT ); Thu, 22 Mar 2018 06:47:23 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w2MAiYFE099223 for ; Thu, 22 Mar 2018 06:47:22 -0400 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0b-001b2d01.pphosted.com with ESMTP id 2gv9fqm5eu-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Thu, 22 Mar 2018 06:47:22 -0400 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 22 Mar 2018 10:47:21 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 22 Mar 2018 10:47:16 -0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w2MAlGtK52691126; Thu, 22 Mar 2018 10:47:16 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7E5554C040; Thu, 22 Mar 2018 10:40:22 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 742F14C058; Thu, 22 Mar 2018 10:40:20 +0000 (GMT) Received: from [9.124.31.146] (unknown [9.124.31.146]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 22 Mar 2018 10:40:20 +0000 (GMT) Subject: Re: [PATCH v6 21/21] perf-probe: Add array argument support To: Masami Hiramatsu Cc: Steven Rostedt , linux-kernel@vger.kernel.org, Ingo Molnar , Namhyung Kim , Tom Zanussi , Arnaldo Carvalho de Melo , linux-trace-users@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org, Ravi Bangoria References: <152129024033.31874.15800253385376959274.stgit@devbox> <152129118998.31874.16273532808298489908.stgit@devbox> <8c02c538-4934-59c2-7795-9058ce57e625@linux.vnet.ibm.com> <20180322182347.ca1aab9b77ab4c351100646b@kernel.org> From: Ravi Bangoria Date: Thu, 22 Mar 2018 16:19:46 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180322182347.ca1aab9b77ab4c351100646b@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 18032210-0044-0000-0000-0000053EB303 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18032210-0045-0000-0000-0000287DBB42 Message-Id: <8b3ad72c-f28c-8fc0-32b8-4401dbe16358@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-03-22_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1803220129 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masami :) On 03/22/2018 03:53 PM, Masami Hiramatsu wrote: > On Mon, 19 Mar 2018 13:29:59 +0530 > Ravi Bangoria wrote: > >> >> Is it okay to allow user to specify array size with type field? > Fro this patch, yes. So IIUC, perf _tool_ will allow user to record array either with "name[range]" or by "name:type[length]". Please correct me if that's wrong. And If perf tool will allow array length along with TYPE field, I guess we should document that in man perf-probe? Otherwise, Acked-by: Ravi Bangoria Thanks, Ravi > The availability of type is checked only when > it is automatically generated. > IMO, it should be done in another patch, something like > "Validate user specified type casting" patch. Would you need it? > > Thank you, >