Received: by 10.213.65.68 with SMTP id h4csp1066168imn; Thu, 22 Mar 2018 14:33:17 -0700 (PDT) X-Google-Smtp-Source: AG47ELsJ4HKxvLlrNagrnEVN9Hqj/ivz3XJ54dLfChrGn7lGsaZ/Q3VR5UCKTyeoak4sztX6tRNt X-Received: by 10.98.212.80 with SMTP id u16mr21705423pfl.58.1521754397038; Thu, 22 Mar 2018 14:33:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521754397; cv=none; d=google.com; s=arc-20160816; b=KJCUM98hPlV6n/8uOHqbwmCTX3KeaYyrMtp0szEKJJcNL7ZL0IZCv2DR2DqGSrrbRF mjXe/QU22A7g7F5NwPtpPTbE8dKzoYOKb/t20bFvqjHvE6qtuaVK4ZMcP9VoiOYFcLFd ZzByf2/C05HTDbIkChrBWDDzBPuMi8gCzIVj3FTmeAx0iCNXqDpxw05bwB99dODkBUA0 JyOHSq1l/Um2bfRkSBPrGXOoxED0XmAs3z/rT50/G9q0D4KDYwBmLq20HJWNO2wCTVxF aF7BmMsvKKEP+3XeTuRH3DtpBff+Inp+rrPgKVM7muJCNoObcyhTrE0wARveVSiw+VvN wr1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version:arc-authentication-results; bh=Pw8zJibm3JD3Uv8zChoGJemjQ1/vJJinaU231Ns4tPE=; b=f/OMGRCxpplEb2mEtJLR/m+ZEtTuzmXB1VcLMkXBZxlSFrvdEggBhzu0FzftbhRdj6 YKdaDZdwrOzl10p3lTdk27LF3HNQXSj5qqUvWGr8cCDgV/nIjRJNgeRHcFu3JRBHiKZg 6NrLFRe7o2O985AyMPcbvuqDOmxG6zOdqRRxws/2rZNxDvZpMAS2OyiGUHCk6sd2D5mG zTTFMV4XgSO3i9kfWwkt98AvswnDV5xRj/oFjVrrI9luobINsahSfdxBwQHIxy4sTU9B dcwzQ0cMAA3C9N9KKzIhqAdZPMe3XuveU6iK9oIe4hFEqX7iaxbtDV/+dmetLW8W8wQl OVYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i12si4993954pgr.546.2018.03.22.14.33.02; Thu, 22 Mar 2018 14:33:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752016AbeCVVcE convert rfc822-to-8bit (ORCPT + 99 others); Thu, 22 Mar 2018 17:32:04 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:52032 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751899AbeCVVcC (ORCPT ); Thu, 22 Mar 2018 17:32:02 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 11125825-1500050 for multiple; Thu, 22 Mar 2018 21:31:35 +0000 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: "Gustavo A. R. Silva" , "Zhenyu Wang" , "Zhi Wang" , "Jani Nikula" , "Joonas Lahtinen" , "Rodrigo Vivi" , "David Airlie" From: Chris Wilson In-Reply-To: <20180322182154.GA21590@embeddedgus> Cc: intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" References: <20180322182154.GA21590@embeddedgus> Message-ID: <152175429362.23562.9645295347693081397@mail.alporthouse.com> User-Agent: alot/0.3.6 Subject: Re: [PATCH] drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs Date: Thu, 22 Mar 2018 21:31:33 +0000 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Gustavo A. R. Silva (2018-03-22 18:21:54) > The checks are misleading and not required [1]. > > [1] https://lkml.org/lkml/2018/3/19/1792 > > Addresses-Coverity-ID: 1466017 > Cc: Chris Wilson > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Chris Wilson Zhenyu? -Chris