Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S270430AbTHLOxK (ORCPT ); Tue, 12 Aug 2003 10:53:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S270385AbTHLOxK (ORCPT ); Tue, 12 Aug 2003 10:53:10 -0400 Received: from [213.95.15.193] ([213.95.15.193]:4878 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S270430AbTHLOwz (ORCPT ); Tue, 12 Aug 2003 10:52:55 -0400 Date: Tue, 12 Aug 2003 16:52:23 +0200 From: Andi Kleen To: Zwane Mwaikambo Cc: Linux Kernel , William Lee Irwin III , Andi Kleen Subject: Re: [PATCH][2.6-mm] cpumask_t - ioapic set_ioapic_affinity Message-ID: <20030812145223.GA18538@wotan.suse.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 778 Lines: 27 > -static void set_ioapic_affinity (unsigned int irq, unsigned long mask) > +static void set_ioapic_affinity (unsigned int irq, cpumask_t mask) > { > unsigned long flags; > + unsigned int dest; > + > + dest = cpu_mask_to_apicid(mk_cpumask_const(mask)); > + > /* > * Only the first 8 bits are valid. > */ > - mask = mask << 24; > + dest = dest << 24; > > spin_lock_irqsave(&ioapic_lock, flags); > - __DO_ACTION(1, = mask, ) > + __DO_ACTION(1, = dest, ) > spin_unlock_irqrestore(&ioapic_lock, flags); Looks ok. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/