Received: by 10.213.65.68 with SMTP id h4csp1094452imn; Thu, 22 Mar 2018 15:17:14 -0700 (PDT) X-Google-Smtp-Source: AG47ELu4EvApFfGEQ9lEh+5PtjShkdhOQIRYss8rrZ2vvFPccKYotQj9XX5Q9mYc6zGzMOQcEuX3 X-Received: by 2002:a17:902:322:: with SMTP id 31-v6mr26946364pld.122.1521757034389; Thu, 22 Mar 2018 15:17:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521757034; cv=none; d=google.com; s=arc-20160816; b=gcBETGAykdwPT5r+jWD4naO2RpXNvfxrkyIjQ8vptyCrh4zSkgyRD34z79+JXcl3z6 7FO1puoTSCUKrAxEGzEstg9e4nCBxKTPmIwuQLO3Qx+ynnzl/VhgzckzBdRoVGIpUeWq PI1Y8lUrX5ckRHcrGqltOF46Nt6dinl3+QhF6IxQyB8g0fhpISJ1hA3oU0PVmpaUcnM5 2CIxh3dSBv+nveoaBDQbjIdDgcu7iQph6085K/tymWhJizSG9bGbLXgfsHdQdQeIHPOq yvEGMAY0oJHRimRTuAZZnUNfhq8Wg/nc8Gm8i9ZkpIiCRBv7aavZpBiZWdO92yqfHevV y8nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dmarc-filter :arc-authentication-results; bh=kB4BE8c892OXlQIj0kj3+6Mwy2I675UKoETvP+yDgJI=; b=nWlTAhT/2nlWw2vgbwVe3TTwvsVpe4/x+k1yzVd5D5omGIeFfT0KhoACBrtXRdmhMQ XC1Gwkt20yaSV/DMyckRiZE8PrRhu2VLb3oJz47vwCBfiCwE4Rd4S9EpoRd3y6aseRxs 1YdD88HvK2+4MUZRY/Z2VBCRdoFCkeRHtpl6mbqIp1kCLNS5ptwV1+dHjR1YszRTB8o8 bhgYrTqHocZd+UbsXRnhG5GZvjVoolpCvBnPT7XSuvtKxBm8PyFLl1Xf/BC9snQVRN6C T1cToo9dBjzBJc+K5EPabeJJP5wsa0IzaEtihsflGRdyPeY8eAhVS8Q5tPo3bTj/krz7 kBfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z124si2018282pfb.188.2018.03.22.15.16.59; Thu, 22 Mar 2018 15:17:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751687AbeCVWQG (ORCPT + 99 others); Thu, 22 Mar 2018 18:16:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:60518 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751464AbeCVWQE (ORCPT ); Thu, 22 Mar 2018 18:16:04 -0400 Received: from mail-it0-f52.google.com (mail-it0-f52.google.com [209.85.214.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7119021840 for ; Thu, 22 Mar 2018 22:16:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7119021840 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=luto@kernel.org Received: by mail-it0-f52.google.com with SMTP id d13-v6so269746itf.0 for ; Thu, 22 Mar 2018 15:16:04 -0700 (PDT) X-Gm-Message-State: AElRT7F66w+98EPMCbzF4YNAE92LQZYtaUK+zOo2ywb29zP3pU6WLRXG ZkY+gZtGOymVJJ/lCuNgvIWAjXbKbPsYWEREK0V+qQ== X-Received: by 2002:a24:5ad4:: with SMTP id v203-v6mr11527626ita.150.1521756963785; Thu, 22 Mar 2018 15:16:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.2.137.70 with HTTP; Thu, 22 Mar 2018 15:15:43 -0700 (PDT) In-Reply-To: <20180322205413.GA30543@wotan.suse.de> References: <20180309.135724.452219538059491199.davem@davemloft.net> <81b7599d-aab7-6cb6-7843-64510c8f6260@fb.com> <20180310140843.GP4449@wotan.suse.de> <20180310151652.GV4449@wotan.suse.de> <20180322205413.GA30543@wotan.suse.de> From: Andy Lutomirski Date: Thu, 22 Mar 2018 22:15:43 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next] modules: allow modprobe load regular elf binaries To: "Luis R. Rodriguez" Cc: Alexei Starovoitov , Jessica Yu , Linus Torvalds , Mimi Zohar , Djalal Harouni , David Miller , Kees Cook , Alexei Starovoitov , Al Viro , Daniel Borkmann , Greg Kroah-Hartman , Network Development , Linux Kernel Mailing List , kernel-team , Linux API , Michal Hocko , Hannes Reinecke , werner@suse.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 22, 2018 at 8:54 PM, Luis R. Rodriguez wrote: > If we can ensure that these usermode modules don't take *any time at all* on > their init *from the start*, it would be wonderful and we'd end up avoiding > some really odd corner case issues later. > I don't see why this issue needs to exist at all for the new stuff. After all, the new things aren't usermode modules per se. They're regular kernel code (modular or otherwise) that loads a usermode helper. All we need to do is to make sure that, if this is distributed as a module, that it's init routine doesn't wait for a long time, right?