Received: by 10.213.65.68 with SMTP id h4csp1107139imn; Thu, 22 Mar 2018 15:39:21 -0700 (PDT) X-Google-Smtp-Source: AG47ELvScIO0Z2uDzo1M1Kx7I5ZJIBpBVxr1HfytzZoerhvPQ1rn5nWg8c7/ZVcPxl/BnMvyal3C X-Received: by 10.98.83.5 with SMTP id h5mr21809164pfb.82.1521758361276; Thu, 22 Mar 2018 15:39:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521758361; cv=none; d=google.com; s=arc-20160816; b=hZmHU4IogaMeUqDW2oqEUOReGIPt6baDkCYJRCnnGeVGwvzL9TFWx1rYqJhJ32DgGD Y6/S7fnW7eLq70tk0t2SG11wzJBOFyD5CC4n7ibKVH2/NLsoRqXBc5h6sluTk1q00GFf D+JOIWx0SrgeZIGTAPvZ17WCFnQ+wRyO/CGnE/ab3MvAVbljUbN/oLLP/gBAYIr7OyHC I4TasOofc99tvf3Oshug9I+b0vBPEP2iiuLwCCnoxlY/ASEkzBwar4zAum/UuVBm0QIJ bD3ae7mybeyTr9lm4FDWWAUpt/YojopgzfCwh0JHoklMyBMjg49rJMz2Tu/RbPSTLZEY h2NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=4qFkESj3IqqNYXznQxYLI3vr1U2lrNNAkN3v3wVN26I=; b=lpR9yE2uqXR0X6ZyuZ0juE8zqtxuxsq+q2l6kDIANsvZ+V9OGklZVu4p/kjkseY8Bt sY8T9a044QqXO6Y2qE/6ZNH6RKQWr4r58nlFyLU59yKTytp6ZsMphGuHDGrwlyJXO/JZ isKrY6O14gNQ04QnX2IV2rC5D4nKblRsnOw8ve4b1vidjRw1MZF2C5nyaGZMTHOGYyhT txJRm7BT5ex9M2en/WYJpZoEtmvZHiG+XstdkVTB04CYhJlqIT5x4B/JdHJ6yk+FxRLt xxqHPx4135pA++rApoX7gZh3UYgCteJTK7YXjwqAanwHuSo+S5RwrWTXTtnnPprb0pMn Kp4g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r1si5814569pff.24.2018.03.22.15.39.05; Thu, 22 Mar 2018 15:39:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751999AbeCVWiE (ORCPT + 99 others); Thu, 22 Mar 2018 18:38:04 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52236 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751531AbeCVWiE (ORCPT ); Thu, 22 Mar 2018 18:38:04 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.9.71]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 71EEE106A; Thu, 22 Mar 2018 22:38:03 +0000 (UTC) Date: Thu, 22 Mar 2018 15:38:02 -0700 From: Andrew Morton To: Baoquan He Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, takahiro.akashi@linaro.org, ebiederm@xmission.com, vgoyal@redhat.com, dyoung@redhat.com, prudo@linux.vnet.ibm.com Subject: Re: [PATCH 0/2] Kexec_file: Load kernel at top of system ram Message-Id: <20180322153802.0763bb46978c0c1a3d3f11c0@linux-foundation.org> In-Reply-To: <20180322033722.9279-1-bhe@redhat.com> References: <20180322033722.9279-1-bhe@redhat.com> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Mar 2018 11:37:20 +0800 Baoquan He wrote: > The current kexec_file ignores kexec_buf.top_down value when call > arch_kexec_walk_mem() to allocate memory for loading kernel/initrd > stuffs. This is not supposed to be what kexec_buf.top_down is used > for. OK, but why is this a problem? When fixing a bug, please fully describe the user-visible effects of that bug. That helps others understand the importance of the fix, whether it should be backported into various kernels, etc.