Received: by 10.213.65.68 with SMTP id h4csp1134034imn; Thu, 22 Mar 2018 16:26:15 -0700 (PDT) X-Google-Smtp-Source: AG47ELvNlShKR7Fljh9IXYcZp4MPWY5REBSMSyTL2NdbhMzSye+s74pBD9whIHj0i1IYdHQady8c X-Received: by 2002:a17:902:f64:: with SMTP id 91-v6mr26956214ply.232.1521761175276; Thu, 22 Mar 2018 16:26:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521761175; cv=none; d=google.com; s=arc-20160816; b=N9EO9nZv/ZoitGsNnlcDH+i7SyYrLy4DCpPvRA8VhctAvsF3HWiWyq2VYOXsYIzTUp 4uG+N2Z2kMf8DUtM6sZpNTJwl1g/g64aMb37+bNiS1bxs/gXYp6P9qx1t2VpU0SrA16s XMZDkQ5D9Ld/uUUjJfZismxhosI5fW6BOqoQu6wKRR2LcH5AtzyrwFc/W+e2MqTyxOij vEMC8A0uXLe5qiJu/OSr0Fn76BdggqV8JfcxxE6nlShzJtF11gv9aTGvZi2C4T0cbX0E bfXVa4P2hNmBpk8sth7EqSTTmi70RKYZ5YYTpGUi/AY7ey30AoXqWFSzFSKAj81aNx9U 4JrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=IjPtk16Q5wOEiYsjq9EYBHS/1oXIh5QWx30PnLUeYtE=; b=Q8yHf4ubTgT9S4AIofq9o4EajQMMR4HIoOyLp+a0HQVTTnG/rOH5MziMv/YOeRFH4l mYqZysXQfnADFfYfqNEa6XTPkkSfUmm579p28w6jlp0z4IRCD/BP9LmmogSSx8KMVCD5 7FiBMbWaLshzyWMZLAtmh0G6a0G3JShcG2fWEU9micnS0I8c7GDDRkb5uIQYR5YzZsr4 E8WLm+Mrjggf4zD6JIiTRjsgXZ6Qu3r7I1scfP5Ygd5IVW4XDes1JZOBwJANQ+i0kEAP 0u9NWQU43vRtWZaBLwslBWzYTmveuYYg0nxAp70WH99yrXHWBoowf7LzdfSXsNK40vvi gAiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b1-v6si5018655plc.95.2018.03.22.16.26.00; Thu, 22 Mar 2018 16:26:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751870AbeCVXZG (ORCPT + 99 others); Thu, 22 Mar 2018 19:25:06 -0400 Received: from cloudserver094114.home.pl ([79.96.170.134]:52606 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751734AbeCVXZF (ORCPT ); Thu, 22 Mar 2018 19:25:05 -0400 Received: from 79.184.254.228.ipv4.supernova.orange.pl (79.184.254.228) (HELO aspire.rjw.lan) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83) id ade742f709d64c18; Fri, 23 Mar 2018 00:25:04 +0100 From: "Rafael J. Wysocki" To: "Lee, Chun-Yi" Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, "Lee, Chun-Yi" , Len Brown Subject: Re: [PATCH v2] ACPI / scan: Send the change uevent with offine environmental data Date: Fri, 23 Mar 2018 00:25:29 +0100 Message-ID: <16547461.vlqm9ldVjj@aspire.rjw.lan> In-Reply-To: <20180320055126.8671-1-jlee@suse.com> References: <20180320055126.8671-1-jlee@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, March 20, 2018 6:51:26 AM CET Lee, Chun-Yi wrote: > In current design of ACPI container offline, Kernel emits > KOBJ_CHANGE uevent to user space to indidate that the ejection of > the container was triggered by platform. (caa73ea15 patch) > > A pure KOBJ_CHANGE uevent is not enough for user space to identify > the purpose. For example, a "udevadm trigger" command can also > be used to emit change event to all udev rules. A udev rule can not > identify that the event is from kernel for offline or from udevadm > for other purpose. Then the offline action in udev rule may also be > triggered by udevadm tool. > > So, similar to the change uevent of dock, kernel sends the > KOBJ_CHANGE uevent with a offline environmental data to indicate > purpose. It's useful by udev rule for using ENV{EVENT} filter. > > v2: > Fix build warning for the environmental string > > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Acked-by: Michal Hocko > Tested-by: Michal Hocko > Signed-off-by: "Lee, Chun-Yi" > --- > drivers/acpi/scan.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > index 8e63d93..490498e 100644 > --- a/drivers/acpi/scan.c > +++ b/drivers/acpi/scan.c > @@ -116,6 +116,7 @@ bool acpi_scan_is_offline(struct acpi_device *adev, bool uevent) > { > struct acpi_device_physical_node *pn; > bool offline = true; > + char *envp[] = { "EVENT=offline", NULL }; > > /* > * acpi_container_offline() calls this for all of the container's > @@ -126,7 +127,7 @@ bool acpi_scan_is_offline(struct acpi_device *adev, bool uevent) > list_for_each_entry(pn, &adev->physical_node_list, node) > if (device_supports_offline(pn->dev) && !pn->dev->offline) { > if (uevent) > - kobject_uevent(&pn->dev->kobj, KOBJ_CHANGE); > + kobject_uevent_env(&pn->dev->kobj, KOBJ_CHANGE, envp); > > offline = false; > break; > Applied, thanks!