Received: by 10.213.65.68 with SMTP id h4csp1165668imn; Thu, 22 Mar 2018 17:24:20 -0700 (PDT) X-Google-Smtp-Source: AG47ELupKaQAiWxAx5c5Kpo07bDS2VezLZCZwsgyL4w6ewGtLLU/1nvL9Bz58jYbf3HXzV2X8fFf X-Received: by 2002:a17:902:b703:: with SMTP id d3-v6mr26739545pls.209.1521764660930; Thu, 22 Mar 2018 17:24:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521764660; cv=none; d=google.com; s=arc-20160816; b=npVpTuUu+bgBWZN2MCG6rak1pLrAombg0TQPZsv9XNqmhbE9C24oTbeVMmUlJOvQJP LNksScUJjI648hVFzLs1mqHbgxXhTbBxOtIf2gtYpl+JKWy6EU9Op9RoywaeExQMuojd ZTJGgwffMHLy8Zxza6eetnBXH6D+BwDBmvQ21zdsp6LAbGC2txhg83rOrCe0Qk8jbPt5 0ttSPZWM1KKdf7878aVhwH8ad3zrEhcYU3OI45fUw2NpMJ84pg+fv6oe2kgrIS6sXcV2 71k/Cov3twzyR9ma4KisRdg5oDW05MtOG0A9u1B2oaCG/Fs6zuoIo2B7BwrKzc1SAz1c ragA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=g/DKCNXjaiptqsNNcdY3mlxd6HQVFJOlzdTKK6hRIxA=; b=fiuPu0nJUFDWaQ66W4HMbJirK6cTYhSAhsgmqT65UxQRTSL7AUfcNZ0rC6rMDQILMG w2Glt9+6ePRwz0Kcn6JX1w68nJwQyN/vDIo9YuUZKLfWquTnsgPKhM2PWcwmJQIMAv2n wskPZVZi0qluRGe/Lwy0K1a5G42jlegsi+0dp8xKYxLJFD01R2PqRH+H+qIU8BJWG/2S H2AAFisAMSbODsvVPqB1tD4ThcpMV3hFFTMYgCnYMH2c3pLwVMOITtDP/CKGFVmkHotr /11VzGuDBbjCJxrNsS6JCrJt6xPCLLbgPk5pVio4tMyUH5aaoPS1+2JXGYwePGlDyKJn Q1jQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=BTmMSb9q; dkim=pass header.i=@codeaurora.org header.s=default header.b=BTmMSb9q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p1si5668476pfp.213.2018.03.22.17.24.06; Thu, 22 Mar 2018 17:24:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=BTmMSb9q; dkim=pass header.i=@codeaurora.org header.s=default header.b=BTmMSb9q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751817AbeCWAXM (ORCPT + 99 others); Thu, 22 Mar 2018 20:23:12 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:54048 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751686AbeCWAXK (ORCPT ); Thu, 22 Mar 2018 20:23:10 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id AF47560246; Fri, 23 Mar 2018 00:23:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521764589; bh=ZjRKH5LfbCB6G4TE3TG3tH8Kol12F4HHnmKuWhFDNVc=; h=Subject:From:To:Cc:References:Date:In-Reply-To:From; b=BTmMSb9qjgFFws7pF8m8Z/bmDCQesJqo4A+bES/XOExviMvCUfKZRQEzGVohTjuFG 3T5Cuid7K/1+ZG4ukpbE+cqjayw6Fh2hNszpK8elNumD/laoEeOZd6dvMeB0QwBBr4 ms/p1WCvnlNaiZZaR70l+KM3Cwjm+9dd6Vm4gMLU= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [10.222.143.167] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: timur@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2983F60246; Fri, 23 Mar 2018 00:23:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521764589; bh=ZjRKH5LfbCB6G4TE3TG3tH8Kol12F4HHnmKuWhFDNVc=; h=Subject:From:To:Cc:References:Date:In-Reply-To:From; b=BTmMSb9qjgFFws7pF8m8Z/bmDCQesJqo4A+bES/XOExviMvCUfKZRQEzGVohTjuFG 3T5Cuid7K/1+ZG4ukpbE+cqjayw6Fh2hNszpK8elNumD/laoEeOZd6dvMeB0QwBBr4 ms/p1WCvnlNaiZZaR70l+KM3Cwjm+9dd6Vm4gMLU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2983F60246 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=timur@codeaurora.org Subject: Re: [PATCH v3 3/3] pinctrl: qcom: Don't allow protected pins to be requested From: Timur Tabi To: Stephen Boyd , Linus Walleij Cc: Stephen Boyd , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Bjorn Andersson , Grant Likely , linux-gpio@vger.kernel.org, Andy Shevchenko References: <20180321165848.89751-1-swboyd@chromium.org> <20180321165848.89751-4-swboyd@chromium.org> <97380342-c3aa-5d34-7b22-f6ebbab4bafe@codeaurora.org> Message-ID: Date: Thu, 22 Mar 2018 19:23:07 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <97380342-c3aa-5d34-7b22-f6ebbab4bafe@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/22/2018 07:16 PM, Timur Tabi wrote: > > This needs to be ret <= max_gpios, otherwise it will fail if every GPIO > is available. > > And it should print an error message and return an error code if ret > > max_gpios. Also, you don't allocate chip->valid_mask anywhere. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.