Received: by 10.213.65.68 with SMTP id h4csp1184288imn; Thu, 22 Mar 2018 18:02:04 -0700 (PDT) X-Google-Smtp-Source: AG47ELsSW7SCloVLHweyPyogg3on4dCIjWjigwYBDnVUunByqBkstsNV1EUW19CuLRTuludckspo X-Received: by 2002:a17:902:b43:: with SMTP id 61-v6mr26906945plq.270.1521766924583; Thu, 22 Mar 2018 18:02:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521766924; cv=none; d=google.com; s=arc-20160816; b=sSoWnZ2DdCbAzpZBOTLtBMs4EwAlsskTtLMlTAaZ4IGF8aA9nKgfEgQW/7WpQZ7TQM Dr3LZI6ROQAX+l6J3M3C3ihkDYHOwadKo8+Apqm0MUbH9BPlHu5s4C7eFUGFrTHIJjVh 5Ak+b2YwZo2hpNeaM6vD9LoOyv3O8kEz5Pjou7+pc1ldHAlWDRuoG1EN2EF+imiKGzOI csY9k0QXbsUXBtYNsq6qC3oZjHjHeRFzxT2ITsmA3pMAmaRlYKJi23q/o7m0uqRxHn9m hHO13I94eN5P6+DqUpihIzjHQYbTositIPLdldvF9h3EN3/4R/I+KZX0IAogMI++dMJf +k5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=rXzgiMLZY7AdwUVLrJw5UJIVwep5ZuKNPiCA3c9Daqk=; b=m4vsCZOXPOz1qS7N0CCVo8+W/1pu8UFfnmnVAdFlpJo1JYOuI/ge9pZt3Jm/U+cXdB scL9oIfUvpsXir+/1SUT+ueYi/nu09aURNFA1pTQVcFGDUS4r0eumANV+TnP0hYtmDZ6 6KoA60BwvLGoPcpr5ng3sJcXzv+wpTduEpXVuicuXVaZaLhwVo0AXY4MIlVREeKnlXFo iv41fDX8kcSXnBhi5oDOwYof8+pjhLqNXEMUzjKmTpAFp83UumgjF+x+bizS6rsDsnSB 071OZK2ZMsiCBZYhqHoy9uldeBc+tT5NaMCorsUJD0fw0UfbADWKDs3pV0QFjCGzAlA+ RBZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=LCBc8Hcj; dkim=pass header.i=@codeaurora.org header.s=default header.b=ayivfPFa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x5si5126725pgb.365.2018.03.22.18.01.50; Thu, 22 Mar 2018 18:02:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=LCBc8Hcj; dkim=pass header.i=@codeaurora.org header.s=default header.b=ayivfPFa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752152AbeCWBAD (ORCPT + 99 others); Thu, 22 Mar 2018 21:00:03 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:36442 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751832AbeCWBAB (ORCPT ); Thu, 22 Mar 2018 21:00:01 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 7E2A960F6B; Fri, 23 Mar 2018 01:00:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521766800; bh=E32Y3kvjI1tJxHKpOCoe9xnbiIY3OrbMXrV9w7YccLM=; h=Subject:From:To:Cc:References:Date:In-Reply-To:From; b=LCBc8HcjO7xs3ci5tO2QVd7pxEhenAya/ijawl5XzvSeiGfOdMfvRyD2QOWU4KUBx o31U6IjkNGSVj5epDM/YKqkN8AuvQtcIjOtg74U5sB03wkgGBsjAq1OQl/56ef4TPC +rnN4urdzfMTry4L+x+Ps4PqaSyv+17S2wlDfr88= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [10.222.143.167] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: timur@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 81BE4607A2; Fri, 23 Mar 2018 00:59:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521766799; bh=E32Y3kvjI1tJxHKpOCoe9xnbiIY3OrbMXrV9w7YccLM=; h=Subject:From:To:Cc:References:Date:In-Reply-To:From; b=ayivfPFacz7DMFoIGk7Zlqbyn4ua1oeLL35sHfUKrpGnM5HXUZ/AC/dSuE5qWToii Df1fCkJzTBl7zc5i1N8uOjkfKsO+yYUKTA+KGdBt9vdsY4lq41Xabq3RzaMOO84VCC g7dwjDZLKmzeOO/u9uy/pePjI+vDuGgwu5T9N9E4= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 81BE4607A2 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=timur@codeaurora.org Subject: Re: [PATCH v3 3/3] pinctrl: qcom: Don't allow protected pins to be requested From: Timur Tabi To: Stephen Boyd , Linus Walleij Cc: Stephen Boyd , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Bjorn Andersson , Grant Likely , linux-gpio@vger.kernel.org, Andy Shevchenko References: <20180321165848.89751-1-swboyd@chromium.org> <20180321165848.89751-4-swboyd@chromium.org> <97380342-c3aa-5d34-7b22-f6ebbab4bafe@codeaurora.org> Message-ID: <59df3700-c0bd-6ee8-eeab-6a49cb92d1db@codeaurora.org> Date: Thu, 22 Mar 2018 19:59:57 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/22/2018 07:23 PM, Timur Tabi wrote: > > Also, you don't allocate chip->valid_mask anywhere. So I see now where it's allocated, but something is fishy. I have three TLMMs on my chip: [ 67.107018] gpiochip_init_valid_mask:351 gpiochip->need_valid_mask=1 [ 67.153747] gpiochip_init_valid_mask:356 gpiochip->ngpio=72 [ 67.195324] gpiochip_init_valid_mask:361 gpiochip->valid_mask=0000000070b1a4b6 [ 68.532992] gpiochip_init_valid_mask:356 gpiochip->ngpio=44 [ 68.574496] gpiochip_init_valid_mask:361 gpiochip->valid_mask=000000002f33b8a3 [ 68.709378] msm_gpio_init_valid_mask:837 ret=44 max_gpios=44 chip->valid_mask=000000002f33b8a3 [ 69.726502] gpiochip_init_valid_mask:351 gpiochip->need_valid_mask=1 [ 69.772960] gpiochip_init_valid_mask:356 gpiochip->ngpio=54 [ 69.814084] gpiochip_init_valid_mask:361 gpiochip->valid_mask=000000001a53c932 Are these normal addresses for kcalloc() to return? They're not even word-aligned. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.