Received: by 10.213.65.68 with SMTP id h4csp1228189imn; Thu, 22 Mar 2018 19:29:15 -0700 (PDT) X-Google-Smtp-Source: AG47ELuOBNpy2GjnMxHUgiZOo0qbxbr7jVXrAWJMdcufkhdG7Ncwr/nnR+NLocWzNLDwZ9UWefhw X-Received: by 2002:a17:902:8602:: with SMTP id f2-v6mr27249468plo.6.1521772155470; Thu, 22 Mar 2018 19:29:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521772155; cv=none; d=google.com; s=arc-20160816; b=TUjUwIaQ4BRvDlTHuCJmN0XTqbm4DTXEgrilnNUDgLPHcWboI0t33s/fNUGk7ht81z XZBvkAyC2SU9jQy6A3sU+9MOPwhUnXR1u+6Cr4wXJzOs0Zh5DvqGW8GLQPEJ4YTGqi2A 5LCIz3sIwnS23+/36GggfaQ92MTH+5ZGkBCG6d6w1oj3Fy1rVeN6dUvJSx95tHN0BPUs LEABAHcRNOV2WzxOTHviitcRCXgetha2WfrWsN3Md9bcoV3BDJ085CC/Y0zJB9n5fTuB xM+TzLJT4Q1xtANBJTNiN3qw6J6u0iyfOjDCCUM6+4ZxubQBGxAFyvcjX9vwZrSpEuKf v/zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:arc-authentication-results; bh=76X2QJ6kw6ZnoG3vVM8nm802VDXYG9agkO5N7RfKc54=; b=wdS6Sgp+qKUQHtPON4WlPmfy7d7zpZ+sgu+TReV2a4HwZI3O93ny7y00i+/g9l0BNQ qfakWevfr5V6Ih/rlP2idO7d1lRde8FukSzIbUr2AKq7W+tW4qYd8KSJxflQC6paH+K9 4owOTYKLDvx/T85qcA6ssS5faeygyDzROjJk5tvjlcnpC1u+G0bwD1j6Vp4/mKNbqBBf VNcpmHRZ/bob3Rj3VAkpz/PIJFGMQdg1fmF+6db5l7RExZu+ElLgFGPSLzrMDcssSZYB IsSFCa6C5Nrsix5UGrpp6lQTCTSMFNf3dhe1l16fgjkMzZaLI9ozCLMZDIjYHF74Y6d5 HKpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a12si6075887pfg.388.2018.03.22.19.28.59; Thu, 22 Mar 2018 19:29:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751719AbeCWC2H (ORCPT + 99 others); Thu, 22 Mar 2018 22:28:07 -0400 Received: from mga18.intel.com ([134.134.136.126]:21706 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751599AbeCWC2G (ORCPT ); Thu, 22 Mar 2018 22:28:06 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2018 19:28:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,347,1517904000"; d="asc'?scan'208";a="27321774" Received: from zhen-hp.sh.intel.com (HELO zhen-hp) ([10.239.13.143]) by orsmga007.jf.intel.com with ESMTP; 22 Mar 2018 19:28:03 -0700 Date: Fri, 23 Mar 2018 10:19:57 +0800 From: Zhenyu Wang To: Chris Wilson Cc: "Gustavo A. R. Silva" , Zhi Wang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs Message-ID: <20180323021957.c633yivqis2ilqpl@zhen-hp.sh.intel.com> Reply-To: Zhenyu Wang References: <20180322182154.GA21590@embeddedgus> <152175429362.23562.9645295347693081397@mail.alporthouse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="kzt6qbsahbmynyur" Content-Disposition: inline In-Reply-To: <152175429362.23562.9645295347693081397@mail.alporthouse.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --kzt6qbsahbmynyur Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2018.03.22 21:31:33 +0000, Chris Wilson wrote: > Quoting Gustavo A. R. Silva (2018-03-22 18:21:54) > > The checks are misleading and not required [1]. > >=20 > > [1] https://lkml.org/lkml/2018/3/19/1792 > >=20 > > Addresses-Coverity-ID: 1466017 > > Cc: Chris Wilson > > Signed-off-by: Gustavo A. R. Silva > Reviewed-by: Chris Wilson >=20 Looks good to me, I will pick this up, thanks! --=20 Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 --kzt6qbsahbmynyur Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQTXuabgHDW6LPt9CICxBBozTXgYJwUCWrRkTQAKCRCxBBozTXgY J58DAJ44R2jNf4O7/GvcRpxbz9m1FwhJawCfW/VelLEDo9ncrJWOka5WjeMvT5s= =rDux -----END PGP SIGNATURE----- --kzt6qbsahbmynyur--