Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Kalluru, Sudarsana" <Sudarsana.Kalluru@cavium.com>
To:     "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        "Elior, Ariel" <Ariel.Elior@cavium.com>,
        Dept-Eng Everest Linux L2 <Dept-EngEverestLinuxL2@cavium.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] qed: Use true and false for boolean values
Thread-Topic: [PATCH] qed: Use true and false for boolean values
Thread-Index: AQHTwhmbkuQWxViA6UOVoTB/ne4K3aPdJyOg
Date:   Fri, 23 Mar 2018 03:20:20 +0000
Message-ID: <MW2PR07MB41395C591E4F4F436ADF05CD8AA80@MW2PR07MB4139.namprd07.prod.outlook.com>
References: <20180322200849.GA28033@embeddedgus>
In-Reply-To: <20180322200849.GA28033@embeddedgus>
Accept-Language: en-IN, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: cavium.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b1d0030-7724-485f-5d12-08d5906d0219
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2018 03:20:20.2282
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR07MB4028
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

-----Original Message-----
From: Gustavo A. R. Silva [mailto:gustavo@embeddedor.com]=20
Sent: 23 March 2018 01:39
To: Elior, Ariel <Ariel.Elior@cavium.com>; Dept-Eng Everest Linux L2 <Dept-=
EngEverestLinuxL2@cavium.com>
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Gustavo A. R. Sil=
va <gustavo@embeddedor.com>
Subject: [PATCH] qed: Use true and false for boolean values

Assign true or false to boolean variables instead of an integer value.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/net/ethernet/qlogic/qed/qed_dev.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c b/drivers/net/ethern=
et/qlogic/qed/qed_dev.c
index 553a6d1..cdb3eec 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dev.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_dev.c
@@ -298,8 +298,8 @@ static void qed_init_qm_params(struct qed_hwfn *p_hwfn)
 	qm_info->start_vport =3D (u8) RESC_START(p_hwfn, QED_VPORT);
=20
 	/* rate limiting and weighted fair queueing are always enabled */
-	qm_info->vport_rl_en =3D 1;
-	qm_info->vport_wfq_en =3D 1;
+	qm_info->vport_rl_en =3D true;
+	qm_info->vport_wfq_en =3D true;
=20
 	/* TC config is different for AH 4 port */
 	four_port =3D p_hwfn->cdev->num_ports_in_engine =3D=3D MAX_NUM_PORTS_K2; =
@@ -1276,9 +1276,9 @@ static int qed_hw_init_common(struct qed_hwfn *p_hwfn=
,
=20
 	if (p_hwfn->mcp_info) {
 		if (p_hwfn->mcp_info->func_info.bandwidth_max)
-			qm_info->pf_rl_en =3D 1;
+			qm_info->pf_rl_en =3D true;
 		if (p_hwfn->mcp_info->func_info.bandwidth_min)
-			qm_info->pf_wfq_en =3D 1;
+			qm_info->pf_wfq_en =3D true;
 	}
=20
 	memset(&params, 0, sizeof(params));
@@ -1630,7 +1630,7 @@ static int qed_vf_start(struct qed_hwfn *p_hwfn,
 		qed_vf_pf_tunnel_param_update(p_hwfn, p_params->p_tunn);
 	}
=20
-	p_hwfn->b_int_enabled =3D 1;
+	p_hwfn->b_int_enabled =3D true;
=20
 	return 0;
 }
--
2.7.4

Acked-by: Sudarsana Kalluru <Sudarsana.Kalluru@cavium.com>