Received: by 10.213.65.68 with SMTP id h4csp187402imn; Fri, 23 Mar 2018 02:22:05 -0700 (PDT) X-Google-Smtp-Source: AG47ELt97ANs5ROVxBIvQ+G7YtNnhv+nQcxg+Bu69NntuNmgMVqMEsmza99CQbQR/n0FmqLb4d8c X-Received: by 2002:a17:902:be0e:: with SMTP id r14-v6mr8362924pls.302.1521796925558; Fri, 23 Mar 2018 02:22:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521796925; cv=none; d=google.com; s=arc-20160816; b=iKpXbzzm38i8EecbXgOeQOU5ZIGAM0odsxPMxMYXDfq11UXv0Yc2ASPpiNIMTXpFve vk8/cFJAUs/ijDqhByNUPkN5fozlPDMDfEZVVx+iMlG7Ty54O0YL9HHCL3WxZcXtxGCG O7+mINtlmZTlw7y85mENp2AEvUeDjQ8TI+f9DFfMqBrBljPGE13GepJB8ziJj0hDd1tX rmK3TU30DhoPHLo6fuOJo/1eGgtnGmoii8xbSzR+CqYpF3A/37vOU7kv2f1NJsMrrhn/ NL6xck9dnsGYtiDyDEnpTQ+CuryBV8S/OQw5V8ZK+HQzSuNSY42pJa9zLZDneT8O0AdJ pItg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=BBFkkmtB0eQ8lIR1o7a4gZmbi9WeremWb2dt8qnJLbE=; b=sn2FURaNfPVSjNH4QdQPfY3T1xEjkwWtPxFHsNe/yXDe68bR0b7vjJxVvke7Plmbte LaSmcFY5Z62Z61PiMuxqgW+ym/JguYS3bFAbKs6gOVfqS8ycE1gadnYZSH7c1yNrto9H GoRVc4OK7JjIyFoiaFQ0BeOFuzhexq1olUTekRWiDYKzLx3PjUlV4d+EKyOquLq7Pj2K DOeMGP8C5hkzoQUkWmZW0a4SQjQPPa1/S3vq76pKpJmQbFnHHSosbIezwAWei4wm/ZwS ARwrNFsG1wbLpwW4lZHZhxHrCHFGSD5sl5fWq/DjZyCSi598PBMdaEpmtFferIfpToQF 0BOQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a6si4561820pgq.712.2018.03.23.02.21.50; Fri, 23 Mar 2018 02:22:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752450AbeCWJUj (ORCPT + 99 others); Fri, 23 Mar 2018 05:20:39 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:9578 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751675AbeCWJPa (ORCPT ); Fri, 23 Mar 2018 05:15:30 -0400 X-UUID: 86c8a38a92a84437a8af2083e96be6cd-20180323 Received: from mtkcas06.mediatek.inc [(172.21.101.30)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 491096552; Fri, 23 Mar 2018 17:15:25 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 23 Mar 2018 17:15:24 +0800 Received: from mtkswgap22.mediatek.inc (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Fri, 23 Mar 2018 17:15:25 +0800 From: To: , , , , , , CC: , , , , , Sean Wang Subject: [PATCH v1 08/16] rtc: mediatek: remove unnecessary irq_dispose_mapping Date: Fri, 23 Mar 2018 17:15:05 +0800 Message-ID: <96f39ce7f57a4dcd7653e049eebc87c83bcbdfc9.1521794177.git.sean.wang@mediatek.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.5042-8.2.9001-23736.004 X-TM-AS-Result: No-5.189400-8.000000-10 X-TMASE-MatchedRID: x6uIgBUWMEw3XjqZll6IQaDH6drx3JPVYoHH/gi0K9uHlDUCu0I+XIny HZfRmqmqTiQecD9aKoSRYJdMgDxPlhgEuFFWa742ypeMiaCPnxvGYnoF/CTeZclk/SMg0CpQo8W MkQWv6iXBcIE78YqRWo6HM5rqDwqtb3C5dDGXC8YVT2mlXIA04VcJ/KqDzE0u8UmmLQxSAiVc+f utAOX47EMMprcbiest X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.189400-8.000000 X-TMASE-Version: SMEX-12.5.0.5042-8.2.9001-23736.004 X-TMASE-POSTMAN: 2-d; X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sean Wang It's unnecessary doing irq_dispose_mapping as a reverse operation for platform_get_irq. Ususally, irq_dispose_mapping should be called in error path or module removal to release the resources for irq_of_parse_and_map requested. Signed-off-by: Sean Wang --- drivers/rtc/rtc-mt6397.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c index b62eaa8..cefb83b 100644 --- a/drivers/rtc/rtc-mt6397.c +++ b/drivers/rtc/rtc-mt6397.c @@ -17,7 +17,6 @@ #include #include #include -#include #include #include #include @@ -336,7 +335,7 @@ static int mtk_rtc_probe(struct platform_device *pdev) if (ret) { dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n", rtc->irq, ret); - goto out_dispose_irq; + return ret; } device_init_wakeup(&pdev->dev, 1); @@ -353,8 +352,7 @@ static int mtk_rtc_probe(struct platform_device *pdev) out_free_irq: free_irq(rtc->irq, rtc->rtc_dev); -out_dispose_irq: - irq_dispose_mapping(rtc->irq); + return ret; } @@ -364,7 +362,6 @@ static int mtk_rtc_remove(struct platform_device *pdev) rtc_device_unregister(rtc->rtc_dev); free_irq(rtc->irq, rtc->rtc_dev); - irq_dispose_mapping(rtc->irq); return 0; } -- 2.7.4