Received: by 10.213.65.68 with SMTP id h4csp195132imn; Fri, 23 Mar 2018 02:35:09 -0700 (PDT) X-Google-Smtp-Source: AG47ELsLgYKtGBGohadN7u2P5disXNLWGgrnTjZPyDrj+DTKIZGeM8xbcfy0isZDwUb0eVhWWdGr X-Received: by 2002:a17:902:2a43:: with SMTP id i61-v6mr28800190plb.54.1521797709473; Fri, 23 Mar 2018 02:35:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521797709; cv=none; d=google.com; s=arc-20160816; b=t0aEfMDDKSWw/lcxXER48VZm/UuzNHO7j2EjfIeLZsXfNyrjAp0hGvxrC7o6RJ9SYB jMapuT6GvB5jlhIxxX62lObLCjuBdm15+C4rjUMVkGY5ZToXTL+w3fqJ7DakpcXvDTYe es8nKplV/BShq9+GVrRM5WM/9k/LzsgyNfNVWGMUpsO0zFNhOBtCB0wwMbhjBTwr8PGK czg42BhuvYp2TzRllbMSaK33iKz2s47WSOZVkqhdThhHapMzRd8z75oQD8QgdD8nMaxE 9UrercA5lDvG9ysGQpHiK1cNVUgO37UI0NLBDOF1wcyY4mLRryvnJpTwqhmBNwyS5cvz MUaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=qIwPKsG9YLiSaPYOY/DF/XJ1oUnMJf3uMlwOTAWuyeg=; b=XuMshpTyPhGv35tLp6r1IWFHK1i146IUgAJKTh3aZRhpYHiFYiwgjY6MPubt80SA1D CVMdsl2riUc38wxyKGQZPmCE4SfQ8VKndAOTWj42tH9VEb6OBH9dWV/v9mPJzyFXEz5F qqPPml/eFnLVBnbCFoQu7DCKylIFG8+83BahnixR4gX0bMJor+x49RpR3ewOXG8HqtEL QtKaLURSYX2ZNJuneaCszXsr9olH5f9NcIi6L63iPn2+h7mRxZHJLxWWA4HrAmkHsGqI ZYQ4dunBBR4I+WoqryYEa6TY2a9ndAVqYk53Qh0kIj5ZosTFPjRIIBupTIVfhKoKw8lv bAew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e4si6415588pfa.103.2018.03.23.02.34.54; Fri, 23 Mar 2018 02:35:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752096AbeCWJdc (ORCPT + 99 others); Fri, 23 Mar 2018 05:33:32 -0400 Received: from mx2.suse.de ([195.135.220.15]:41035 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751617AbeCWJda (ORCPT ); Fri, 23 Mar 2018 05:33:30 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 764F6AE01; Fri, 23 Mar 2018 09:33:28 +0000 (UTC) Date: Fri, 23 Mar 2018 10:33:27 +0100 From: Michal Hocko To: Zhaoyang Huang Cc: zhaoyang.huang@spreadtrum.com, Andrew Morton , Vlastimil Babka , Mel Gorman , Johannes Weiner , vel Tatashin , Tetsuo Handa , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-patch-test@lists.linaro.org Subject: Re: [PATCH v1] mm: help the ALLOC_HARDER allocation pass the watermarki when CMA on Message-ID: <20180323093327.GM23100@dhcp22.suse.cz> References: <1521791852-7048-1-git-send-email-zhaoyang.huang@spreadtrum.com> <20180323083847.GJ23100@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 23-03-18 17:19:26, Zhaoyang Huang wrote: > On Fri, Mar 23, 2018 at 4:38 PM, Michal Hocko wrote: > > On Fri 23-03-18 15:57:32, Zhaoyang Huang wrote: > >> For the type of 'ALLOC_HARDER' page allocation, there is an express > >> highway for the whole process which lead the allocation reach __rmqueue_xxx > >> easier than other type. > >> However, when CMA is enabled, the free_page within zone_watermark_ok() will > >> be deducted for number the pages in CMA type, which may cause the watermark > >> check fail, but there are possible enough HighAtomic or Unmovable and > >> Reclaimable pages in the zone. So add 'alloc_harder' here to > >> count CMA pages in to clean the obstacles on the way to the final. > > > > This is no longer the case in the current mmotm tree. Have a look at > > Joonsoo's zone movable based CMA patchset http://lkml.kernel.org/r/1512114786-5085-1-git-send-email-iamjoonsoo.kim@lge.com > > > Thanks for the information. However, I can't find the commit in the > latest mainline, is it merged? Not yet. It is still sitting in the mmomt tree. I am not sure what is the merge plan but I guess it is still waiting for some review feedback. -- Michal Hocko SUSE Labs