Received: by 10.213.65.68 with SMTP id h4csp233508imn; Fri, 23 Mar 2018 03:31:12 -0700 (PDT) X-Google-Smtp-Source: AG47ELtTyTSdniL0ohicGPeIZhokP+LHfG0ztmCJ/aVzhWbERhRvSZPqZzMvBCHu0mWaytwGGHrt X-Received: by 10.99.112.92 with SMTP id a28mr20216280pgn.17.1521801072255; Fri, 23 Mar 2018 03:31:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521801072; cv=none; d=google.com; s=arc-20160816; b=kx26mQ7FbYl8fbjvCyevpPPW3jSlfpOp+8QpydUALU2T8nxcQxq6Xf9nIA4/VLDVs1 8yLV9hXDS8Sh3Jw+fjfve37dCXQKUCLrc4h6Wkal88qFhBR0EoM/5he2/i29pC34IjcI 1ojuLvyTiAtWx96e61xCToljYyRdsNls9CuoukcibvxNW1opuIo/0N95wgv5r0qOVHZ5 LPwSPZxyGa01RbkRHzS4MVyKqQZe0mFqSs6fxJI2rsv75PVkO4Y8pVBlyQWHDJW5a6+l b2NGcMAsaXIWEP9IFOvcZxq1mCrEjMbyAvCA7tWNTsptLpgPvB3tkkFJUiCa8HfKVw9L gKsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=CQZAKlYNrGKmwmJzV92iPRYSdFLhSRtKc/14wHuOLYc=; b=rlEOel8/6wTv1Ilip/aYyfgT0nN58Z2n/CBHDmiX2o69XmYgqPgyaR+3iWowW6d1WP r7TGwXig5/SNSl7uhLo4zHwtCQrDRpGlfRXRG7aQwZnOqXqfnoopLMngX/VuBrvypMT2 5KnlD+rZEab1WHbJuF7DV9ZMuUhdGBJ4TTvrtsw3kG4m/savIuj00YQrZnVz/xa3MJIe IzXG6P/EVD+xixZXCbJ7U50NhPj5PkYKC/bnJfIuMBQzhiDbzhITF03tK6J9HgPAXi8T Omh7gnI51h7kg24wiz0Fd2TEXZZ0t57o87Cz/Dy899Qhma/kQnQBX6d4zQ8Zfybx95fG PUtw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 37-v6si8300655plq.451.2018.03.23.03.30.57; Fri, 23 Mar 2018 03:31:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933962AbeCWKTO (ORCPT + 99 others); Fri, 23 Mar 2018 06:19:14 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:47966 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933920AbeCWKTK (ORCPT ); Fri, 23 Mar 2018 06:19:10 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 17132F2C; Fri, 23 Mar 2018 10:19:09 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pan Bian , "David S. Miller" , Sasha Levin Subject: [PATCH 3.18 22/47] qlcnic: fix unchecked return value Date: Fri, 23 Mar 2018 10:55:13 +0100 Message-Id: <20180323094249.070391163@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180323094248.117679641@linuxfoundation.org> References: <20180323094248.117679641@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pan Bian [ Upstream commit 91ec701a553cb3de470fd471c6fefe3ad1125455 ] Function pci_find_ext_capability() may return 0, which is an invalid address. In function qlcnic_sriov_virtid_fn(), its return value is used without validation. This may result in invalid memory access bugs. This patch fixes the bug. Signed-off-by: Pan Bian Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c @@ -126,6 +126,8 @@ static int qlcnic_sriov_virtid_fn(struct return 0; pos = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_SRIOV); + if (!pos) + return 0; pci_read_config_word(dev, pos + PCI_SRIOV_VF_OFFSET, &offset); pci_read_config_word(dev, pos + PCI_SRIOV_VF_STRIDE, &stride);