Received: by 10.213.65.68 with SMTP id h4csp259334imn; Fri, 23 Mar 2018 04:08:10 -0700 (PDT) X-Google-Smtp-Source: AG47ELt3vZJlq1hdbz5QoNLuoRSB+1kZKSLvBXnuex5ajP0NMOQdmVtquzPa+mBSUds5hL826wp4 X-Received: by 2002:a17:902:9a8b:: with SMTP id w11-v6mr22516005plp.136.1521803290513; Fri, 23 Mar 2018 04:08:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521803290; cv=none; d=google.com; s=arc-20160816; b=rPbzZF9Jvv981NPzzhxOluQgoqqIClYHzPQJ7A1HyQLUhagSVFbRDnRpuA14f47v+T v+aQi8/YA3aeJX9+Y3+Hl3q4fr98LQ57BFH2bfjA5Lyxo5BRz0hZdo0GZT7+xJMijE0e xf3qQ7dl1KorYIBw5t7R4q+FO2pOoy8JjJM2LEXU/LJjKSMiTmI5MxGKqtx3sgs56tpn MdMCfalWN2Z78FE7APqD3x+AQuw3pcl9iSDvpme3wgqUHmQhsONGtyq8ivrVNpou7szA +PUIU+58Oc5agszzWPnUudQEpMcTxXBVrTozo9PexwP2TS+xn/Rz2yl2J71uPouqfeE6 h/2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=V0A947ZwrifthumS3iDmm2y0itIYoZZRw2vRXD6paHg=; b=kNdqWoO/yFVfRIxaRNGzYnBqcKExp5NkXhrWXWFQ36enwajW3FqNT+i73ofW99MANX mb52F4c0srGN2mOIJviSmF2TF8/Qy20OW1BAZOpfr+e6UuMmoVKYgNy3cURUilMk9YgB yH5IRl2rVXDfKObWJkN4NP1CWh0gwCq6T1hNuBV9axQRsALR5/sNKkud0+qJttPVxjMy gyDLmz4fJiGBdonrP1xxEeREkRIiuF9YeiqqC4LWdHs/j1Z4sB83LFRh9CwnWtdmeRGM WeCOV8TjVLrwA6pfa8ROmKXhpAYuMWgyw0gxcxvi0j9wHSWwP9ku/qn42T1OCKzO+Kcp YIOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k3si6457424pff.82.2018.03.23.04.07.55; Fri, 23 Mar 2018 04:08:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933124AbeCWKMI (ORCPT + 99 others); Fri, 23 Mar 2018 06:12:08 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44146 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933060AbeCWKMF (ORCPT ); Fri, 23 Mar 2018 06:12:05 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id F1D6AE19; Fri, 23 Mar 2018 10:12:04 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bjorn Helgaas , Sasha Levin Subject: [PATCH 4.9 156/177] vgacon: Set VGA struct resource types Date: Fri, 23 Mar 2018 10:54:44 +0100 Message-Id: <20180323094212.071671781@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180323094205.090519271@linuxfoundation.org> References: <20180323094205.090519271@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bjorn Helgaas [ Upstream commit c82084117f79bcae085e40da526253736a247120 ] Set the resource type when we reserve VGA-related I/O port resources. The resource code doesn't actually look at the type, so it inserts resources without a type in the tree correctly even without this change. But if we ever print a resource without a type, it looks like this: vga+ [??? 0x000003c0-0x000003df flags 0x0] Setting the type means it will be printed correctly as: vga+ [io 0x000003c0-0x000003df] Signed-off-by: Bjorn Helgaas Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- arch/alpha/kernel/console.c | 1 + drivers/video/console/vgacon.c | 34 ++++++++++++++++++++++++++-------- 2 files changed, 27 insertions(+), 8 deletions(-) --- a/arch/alpha/kernel/console.c +++ b/arch/alpha/kernel/console.c @@ -20,6 +20,7 @@ struct pci_controller *pci_vga_hose; static struct resource alpha_vga = { .name = "alpha-vga+", + .flags = IORESOURCE_IO, .start = 0x3C0, .end = 0x3DF }; --- a/drivers/video/console/vgacon.c +++ b/drivers/video/console/vgacon.c @@ -405,7 +405,10 @@ static const char *vgacon_startup(void) vga_video_port_val = VGA_CRT_DM; if ((screen_info.orig_video_ega_bx & 0xff) != 0x10) { static struct resource ega_console_resource = - { .name = "ega", .start = 0x3B0, .end = 0x3BF }; + { .name = "ega", + .flags = IORESOURCE_IO, + .start = 0x3B0, + .end = 0x3BF }; vga_video_type = VIDEO_TYPE_EGAM; vga_vram_size = 0x8000; display_desc = "EGA+"; @@ -413,9 +416,15 @@ static const char *vgacon_startup(void) &ega_console_resource); } else { static struct resource mda1_console_resource = - { .name = "mda", .start = 0x3B0, .end = 0x3BB }; + { .name = "mda", + .flags = IORESOURCE_IO, + .start = 0x3B0, + .end = 0x3BB }; static struct resource mda2_console_resource = - { .name = "mda", .start = 0x3BF, .end = 0x3BF }; + { .name = "mda", + .flags = IORESOURCE_IO, + .start = 0x3BF, + .end = 0x3BF }; vga_video_type = VIDEO_TYPE_MDA; vga_vram_size = 0x2000; display_desc = "*MDA"; @@ -437,15 +446,21 @@ static const char *vgacon_startup(void) vga_vram_size = 0x8000; if (!screen_info.orig_video_isVGA) { - static struct resource ega_console_resource - = { .name = "ega", .start = 0x3C0, .end = 0x3DF }; + static struct resource ega_console_resource = + { .name = "ega", + .flags = IORESOURCE_IO, + .start = 0x3C0, + .end = 0x3DF }; vga_video_type = VIDEO_TYPE_EGAC; display_desc = "EGA"; request_resource(&ioport_resource, &ega_console_resource); } else { - static struct resource vga_console_resource - = { .name = "vga+", .start = 0x3C0, .end = 0x3DF }; + static struct resource vga_console_resource = + { .name = "vga+", + .flags = IORESOURCE_IO, + .start = 0x3C0, + .end = 0x3DF }; vga_video_type = VIDEO_TYPE_VGAC; display_desc = "VGA+"; request_resource(&ioport_resource, @@ -489,7 +504,10 @@ static const char *vgacon_startup(void) } } else { static struct resource cga_console_resource = - { .name = "cga", .start = 0x3D4, .end = 0x3D5 }; + { .name = "cga", + .flags = IORESOURCE_IO, + .start = 0x3D4, + .end = 0x3D5 }; vga_video_type = VIDEO_TYPE_CGA; vga_vram_size = 0x2000; display_desc = "*CGA";