Received: by 10.213.65.68 with SMTP id h4csp342354imn; Fri, 23 Mar 2018 05:58:54 -0700 (PDT) X-Google-Smtp-Source: AG47ELuE1zIwqWhXnsO30BwgQktcfpWUQ29CZW0l/XVY/wg94hlqifEJSGWVpFu5/UbipQRFpBn9 X-Received: by 2002:a17:902:28c4:: with SMTP id f62-v6mr8908656plb.19.1521809934252; Fri, 23 Mar 2018 05:58:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521809934; cv=none; d=google.com; s=arc-20160816; b=iYiN+gF7H8bDGDgU4u/PAk1r+phXN7/Ycg9Tdbp0RC1kZOyUXtOMtdPah4y+KUS7S5 Jo2cZvpEIzQ9dtEFPMVmd8GuSLq1EREKcvsKWl937BZTuasxVk4eW7i9/Mepq+I4yIOL wPrkOr8Mpp4M3WgBnPDRVSUkOxMAI0Mj4vRzkGIrPVJNAuH/kefoHPctWxBAQQ7Ru0n8 YBD1uX9BGrl/U+av7Su4YWk0pCcPK2offLNOQ6CSOixHd9ZRf3Nr/fAAoYy9LFz4Ga5v gDTC4jQ2roNPU+NnCJxQZB85A1mbFhiNpkoPcJzcazYlKg/vUtuoQKUWg9LXXe8+5kN9 Kkmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=XQsCPBItJLmcrZYj4pwr5sSvGBJkIicmtf6W93ynfl4=; b=ZVpcKO7A17pi/D5f4S7Um3HVNX1BI7ZnMCqBjQX39WkLQFlqxE7aNDy3ZcuXfHeGJI nLPkV+BdRIVt9Gv5ZE5yToUYPm0b//ywDXFETlm4FPo2Q/eIaZCWz3T6wmTbZU6Q+wh5 7gwYVQE9bpnx2QNa7cqlbpWl/x2nvBnT0na2/ho/+WkRaGLeQ+YvbUWupSJW5p0pPAqZ ytGm/QkMIL+eCHLsaW0i3TasUB4IhKheXEwwPBeOZZCkB1fLOqoRTbxh065ys0BWXynd Ppb+BdMnuAznKy8c/yxQtEiZ9VQ/A0E3UCWNspNVHmlPzdDNLnDt2P9IrxHDJGqzSvGw WtHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Zp0P99kg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y15si6145405pgr.167.2018.03.23.05.58.39; Fri, 23 Mar 2018 05:58:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Zp0P99kg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752855AbeCWM50 (ORCPT + 99 others); Fri, 23 Mar 2018 08:57:26 -0400 Received: from mail-pl0-f67.google.com ([209.85.160.67]:41913 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752593AbeCWM5V (ORCPT ); Fri, 23 Mar 2018 08:57:21 -0400 Received: by mail-pl0-f67.google.com with SMTP id b7-v6so7367264plr.8; Fri, 23 Mar 2018 05:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XQsCPBItJLmcrZYj4pwr5sSvGBJkIicmtf6W93ynfl4=; b=Zp0P99kgiN0n6DpB2kRPaqm0SiJP31ViVmKM++1yXW/kf9ks3+Foc7Pi1ph/z/VxaY 4Sh95wXpuYU1TlSEir07M0WWGMgfwld425Og4Aq5qCbhjmC+YMKxhPNkvD3U8JrVpxwB F4aI01SXzxKgRWRBfDaGESfU6NiGCJmolvY5LWQwS4oXnYfOl04aPyAUMyOOOm9+xfE4 GzCBc5mUM1otoLzt4pgACw3M26JiSKnG1xh/AYYNQBy6kqtFE5syObxIBZ5QCLzTUg33 bxBJPkRwE8djSLLKL6oQ6ztiswh6jAT8rqYZYVz1m/TAL+w38QdHKBqz2Kw+RFWOV2Fs gBLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XQsCPBItJLmcrZYj4pwr5sSvGBJkIicmtf6W93ynfl4=; b=uMByJLdtz67SUEZ/rku+cddIn0TZubi7/FL7fjyUKr50otjMId/N853+FwsCd9Ng7x yPmhx726L9e58U6r8Y3RhzFMVcj+ppiwmCN8Wao9u250YZ3FkCOSI24yR/806Y89Tvk6 3mebrswD6dj9+MVWWpURIK8QfeSKp0/jYIfGC6B3AjGpMVGcCfgE+LQAqXJ9EgoFIL7m lzbx88cUHbbvo7jaGNsK5tlDdw8q5+vsVU7D/zmxdC7+NGX3RITfYUjatS9lGfuAa3AC /9WV+OcYYXgCIdhKkS14VYMWsAuCfZ2uibVBKoPmuOL7tKEHwxVgu/ZLNGKtWGkZgGu7 QCSw== X-Gm-Message-State: AElRT7H4NDsxlR+lx3JeBHBYxTl/RPZ5F4cVJr1bP+FJFBZ5Ukq3KSSN QMDOA4dZMBbj1zppO83Ly0tZsqGA X-Received: by 2002:a17:902:3124:: with SMTP id w33-v6mr30230880plb.119.1521809840461; Fri, 23 Mar 2018 05:57:20 -0700 (PDT) Received: from [192.168.86.235] (c-67-180-167-114.hsd1.ca.comcast.net. [67.180.167.114]) by smtp.gmail.com with ESMTPSA id 68sm17932376pfx.130.2018.03.23.05.57.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Mar 2018 05:57:19 -0700 (PDT) Subject: Re: [PATCH] netlink: make sure nladdr has correct size in netlink_connect() To: Alexander Potapenko , dvyukov@google.com, edumazet@google.com, davem@davemloft.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180323124902.41625-1-glider@google.com> From: Eric Dumazet Message-ID: Date: Fri, 23 Mar 2018 05:57:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180323124902.41625-1-glider@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/23/2018 05:49 AM, Alexander Potapenko wrote: > KMSAN reports use of uninitialized memory in the case when |alen| is > smaller than sizeof(struct sockaddr_nl), and therefore |nladdr| isn't > fully copied from the userspace. > > Signed-off-by: Alexander Potapenko > Fixes: 1da177e4c3f41524 ("Linux-2.6.12-rc2") Reviewed-by: Eric Dumazet Thanks Alexander.