Received: by 10.213.65.68 with SMTP id h4csp375483imn; Fri, 23 Mar 2018 06:35:28 -0700 (PDT) X-Google-Smtp-Source: AG47ELv7CvWY9o6QpwWUu8ZtqkKOdOtWPPDiV1bzAwoXnaM8ckHX/7VcGMDI473TQB4X23Y0Ry3l X-Received: by 10.98.152.22 with SMTP id q22mr24116622pfd.178.1521812128094; Fri, 23 Mar 2018 06:35:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521812128; cv=none; d=google.com; s=arc-20160816; b=pWDpoCju5gkfILqdUZ/U3iC6rRa8l6GG04S2rTb88yMMeA+MiSPSFUKYUiulM/nHYu E5mOnkzxzXd+2cbfwhAuamw0it0pGigQMf093+vAzELITF5wtGIVW/5J7jlfB79i1DNg WM3jl4RZz5EG69Zl41Lx+4wenPN2WSePCDwHt8OlOSEOsm7sauVybcPBX2Mh2Syz46h4 o4HGAA+fRI0mMh1diwIGPZW4tWcOTVk5WuuCc93yggDAiEHad+6vykiDuurIwTc2zdXu enhf/VreEUArwKhcJVtpZfROfpwinF2I7eAseh0hyWMzglLum0hHKCAyqLNY9AYTWRHg msDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=arsH2oOGqUi8JLWY02Kib3D74LScefG8j04PFivqbM4=; b=CC4r+9tMBWw0m0sUyaAPFf9etlci2xqdZUmdWL8TRmFYDTmCsJEgqz+NmUT4QIZiRR OeGA/F3yq2dWFrblKlXoZ8rhrCG6wmZUmZUfOQBSLJcWYS0rAAA4CF+Ns7wS6ucopQqA TVRRG4tK+HJ9ZZx8kgEcwQn/VD/zYDbCOVLNA4REG0pUcVFhfXKkl1UqnR1TLuXfEnut inN/zqk2CSp9SOzrX2OXF3qFItg9F5rwvR37rFGxkNdKb/oXTh/vC5ulXZ/7Qfen6grO u0rg9T8myv+G5kjSmBi9pxKFuWLFOHySoCtYx776SZGSHRawhSLG8wg+YdQm2dAua2iA z3zQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=YhcSsbAt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k20-v6si6286884pll.202.2018.03.23.06.35.13; Fri, 23 Mar 2018 06:35:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=YhcSsbAt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752644AbeCWNeY (ORCPT + 99 others); Fri, 23 Mar 2018 09:34:24 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:38332 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751812AbeCWNeW (ORCPT ); Fri, 23 Mar 2018 09:34:22 -0400 Received: by mail-wr0-f193.google.com with SMTP id l8so12156594wrg.5 for ; Fri, 23 Mar 2018 06:34:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=arsH2oOGqUi8JLWY02Kib3D74LScefG8j04PFivqbM4=; b=YhcSsbAtw+Vr4qxzaTSR91c7meNk5MmuuwX5fHUOWclM1EUxh761qwZ/r9eU9ybk4g lrjCtiep1YDKpyUfCg4JCfLcKvJJ2HgltNxX0U+QJKOkWaaYFkN/gXnJUwVk7b2otoeI 0WPC/bHqKMKR1fzlRU2dD2ZIZhk7murYhR3ep8BxHhavj3MszZkYYsefqFnjHVhu71be sL3C1J8Yizoc8nntbOfzUdG47mGRGupmFkNTEwxEIlNFQyupYgxl1DTxctbBGUSORXNZ V8+XNN0IP02wVdyMVIlm5zpRES6R9K+CfC9jQbyYgXueLun7R34HBQJkaafWYg1i0oTF H88w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=arsH2oOGqUi8JLWY02Kib3D74LScefG8j04PFivqbM4=; b=cSE2wzbHSoYl3jxRTCZXz5QDkyqV7Re11pZuctlqagf9Zw5Rlt+wxF0lVs2IdwOi82 tY9nMB/TXsbufYq6XlxqK7nDK9QeUHoXgUhQPJBExEP0aC6XE1DyccwFBN8XOPJWwrPM a/lP0T4FeISAX/oFBDkpg1wpaNdxutmwE0hr59kkcAMPiR/OoRJaGyVSfKWi7AITYtZO c5KJoSFh3uQao1WecSwD4KpxbiGzYIWid5nRECMPGdmR84lUlcSZYiiKeWO+3yHaaJE1 H81nmLXwgrNc6M7n8HHCYiJ/8mk1kRvRccX6iAbT9p4zqpmtK0NQH5Pih2zVv6Bb9RIl x5tA== X-Gm-Message-State: AElRT7FICGiabQANKl88vpyN5BHwUPU2GJtyL+di10CxTstYlqYOG+29 B5hId5Yf4P4gFjnxTLj6YoNtdA== X-Received: by 10.223.150.56 with SMTP id b53mr24428241wra.79.1521812061609; Fri, 23 Mar 2018 06:34:21 -0700 (PDT) Received: from [172.20.1.93] (host-79-78-33-110.static.as9105.net. [79.78.33.110]) by smtp.gmail.com with ESMTPSA id l22sm8918248wmi.39.2018.03.23.06.34.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Mar 2018 06:34:20 -0700 (PDT) Subject: Re: [PATCH 0/2] bpf: Change print_bpf_insn interface To: Jiri Olsa , Alexei Starovoitov , Daniel Borkmann Cc: lkml , netdev@vger.kernel.org References: <20180323104129.14989-1-jolsa@kernel.org> From: Quentin Monnet Message-ID: Date: Fri, 23 Mar 2018 13:34:19 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180323104129.14989-1-jolsa@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2018-03-23 11:41 UTC+0100 ~ Jiri Olsa > hi, > this patchset removes struct bpf_verifier_env argument > from print_bpf_insn function (patch 1) and changes user > space bpftool user to use it that way (patch 2). > > thanks, > jirka > > --- > Jiri Olsa (2): > bpf: Remove struct bpf_verifier_env argument from print_bpf_insn > bpftool: Adjust to new print_bpf_insn interface > > kernel/bpf/disasm.c | 52 ++++++++++++++++++++++++++-------------------------- > kernel/bpf/disasm.h | 5 +---- > kernel/bpf/verifier.c | 44 +++++++++++++++++++++++++++----------------- > tools/bpf/bpftool/xlated_dumper.c | 12 ++++++------ > 4 files changed, 60 insertions(+), 53 deletions(-) > Thanks, this version looks good to me. Please keep the "Reviewed-by" tags when resubmitting new versions of your patch sets :) For the series: Reviewed-by: Quentin Monnet