Received: by 10.213.65.68 with SMTP id h4csp469387imn; Fri, 23 Mar 2018 08:26:44 -0700 (PDT) X-Google-Smtp-Source: AG47ELtSsRmHGth0vDyS7EQS8Oi/MyHdHr93G8nsrsaJTzLxRfq3uOy4NTAIH/qF4buxsLq61qH6 X-Received: by 10.101.67.68 with SMTP id k4mr843708pgq.197.1521818803995; Fri, 23 Mar 2018 08:26:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521818803; cv=none; d=google.com; s=arc-20160816; b=xSzpEckI8SpP+zIu/Jrvl+kGLu/PmSwB7AIzIQxndXXH8scAGY53TwPySyQrSqs+So DTnE7u022JhN0XmZRyyIJmrK7n6pTvJ47WhBl8Gh2oF5quRZtmKJ32hic14B2p1pw2/O 40xx8dglL1W/gnGxEciut/97iKYSlURjRwDI32B5HkSNGE1xpboS7O17BwotUgGs+wex iOZafGKWiXgVYkfrAs5YDcRf2fc5JabfvsUUIXgVNXJmIC5ddM27WHTz5PyOs+JmfotO yR2wWjgbQrmGQLfgH//GKMvd7amML2nbC86lZTK6eChn5p//FguzfoiYLHHw555sbWjq JDTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject:arc-authentication-results; bh=hTmvY/XZVWO0/FPmNpxh5C8SiHguwZSX/JRNI4av/Go=; b=R4CgGe6OCZYtESmOhtx6Frj4RZgD+KLv11yyeRqb+5v0ztAdJn14vKGUXBlo3cl2sU mJL4ryNniMP/n6L3QmQkJCVVPtZEc77zoFxDtzaH/L8y+JrgWoWS30bOIyoQ7znjSSaB CffNyWQs59XnfiY4jwvFB2PZrlAUoMYR8+qdoK2bfSS35pRrBS78zYYIdsoW/+7N2XVw 8lXn7ESSt/FIpC06Z67ZqOXxUSaHMtfFBjnNaGjNxlMZQlZOCJpfs+cU58C6sJtc/vMq tYyUBGZUNlSQ8pRhtdLIavMYHS8f+mah3FE0bwsEZRVduemW0JYfkSbA+IKoyQnVSWQh NxKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x11si6005225pgr.147.2018.03.23.08.26.28; Fri, 23 Mar 2018 08:26:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751858AbeCWPZf (ORCPT + 99 others); Fri, 23 Mar 2018 11:25:35 -0400 Received: from vps-vb.mhejs.net ([37.28.154.113]:43430 "EHLO vps-vb.mhejs.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751491AbeCWPZe (ORCPT ); Fri, 23 Mar 2018 11:25:34 -0400 Received: by vps-vb.mhejs.net with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ezOZL-0002OT-TP; Fri, 23 Mar 2018 16:25:27 +0100 Subject: Re: [PATCH] X.509: unpack RSA signatureValue field from BIT STRING From: "Maciej S. Szmigiero" To: David Howells Cc: Herbert Xu , "David S. Miller" , Tom Lendacky , Gary Hook , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org References: <88da0c24-385c-64a9-6d56-36696d433bc7@maciej.szmigiero.name> <30085.1520437454@warthog.procyon.org.uk> <593f6dbe-4ab4-0149-43d9-388cf0fee9f3@maciej.szmigiero.name> Message-ID: <9264ee5d-e793-22c3-6aad-6bd7b8737dbf@maciej.szmigiero.name> Date: Fri, 23 Mar 2018 16:25:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <593f6dbe-4ab4-0149-43d9-388cf0fee9f3@maciej.szmigiero.name> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07.03.2018 18:56, Maciej S. Szmigiero wrote: > On 07.03.2018 16:44, David Howells wrote: >> Maciej S. Szmigiero wrote: >> >>> + if (!strcmp(ctx->cert->sig->pkey_algo, "rsa")) { >> >> I'm going to change this to '== 0' rather than '!'. > > No problem. I cannot find this patch in any tree that I have looked at. Are you going to pick it up later or am I not looking at the right place? Thanks, Maciej