Received: by 10.213.65.68 with SMTP id h4csp493137imn; Fri, 23 Mar 2018 08:58:15 -0700 (PDT) X-Google-Smtp-Source: AG47ELu9qlT34yryg415X73ul3IMnzLR7ZPc/6E2dHWAnyLoRjaT0DTVjmi0c6GQm9sbRtFSRFJl X-Received: by 10.99.95.135 with SMTP id t129mr21417254pgb.268.1521820695511; Fri, 23 Mar 2018 08:58:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521820695; cv=none; d=google.com; s=arc-20160816; b=a4D7IxR/P9Sw0939oDI+UFetwzvXbtlYLcFqDCTPSyayoBhIL2BtDys9L73Ay0xDKC db/rNDvreezlDiGOnKwm+t1uUrIldON2cQmzX0IWTyCcCBdZ7nLTos/fujIYphcvZTlA BBtTQSYTac9GVieWc0+7+VymX85s7vl372wS28LZL8Gq7Bz+wX71wBNmJIbFKNw4YIK1 /hhwcvDbu/WoatIZl18z37k8LhWEV8APaN0xOyyCXP72lNXZaXP5Ch5pxCxeUcCzDwWE w1H9gNHOo7IXl72XvxlxIaOgqmcG+RV3scejXCVdE4Zz5+z68kRa0DqELgndHHTPA/DX APPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=b5QJ6mFzYrEQIiVxnGBDV2zrjBOTs9B6Bo9G6VRNyQA=; b=CVS0K9Qb1GqiXOScLds0YlR6aWfjvmi2qtSS/Nq+MVfaNfv+yl9H9jVq+S6aQnp9yM D/xwskiIEZYgBKToNtCHrfYjqsiUgv1GsYy1395UyP55nE0eLisDuC23vZi4lAFGCdyH CRJCNzf4Ph+W0wDN03s6PTJc5LPXd8SXHjYb5T81jPwN55r6ANxRMX/XC38NOBxsJftc DK3kmT86pZF803vmg0KsVljo+Hy5+nl+Yw9W2UEFPGYapsZ0V4S521zASBcT/71O+/g7 FlEhEIWgexamb87UkB/VDLyFS/zrXrXwx1MGOB2fCEH8RC/v7bdy5kmcMKEr/AYePxju 9k8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector1 header.b=nGxKbhIm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g13-v6si8714269pln.61.2018.03.23.08.58.01; Fri, 23 Mar 2018 08:58:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector1 header.b=nGxKbhIm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752130AbeCWP43 (ORCPT + 99 others); Fri, 23 Mar 2018 11:56:29 -0400 Received: from mail-ve1eur01on0052.outbound.protection.outlook.com ([104.47.1.52]:5120 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751798AbeCWP41 (ORCPT ); Fri, 23 Mar 2018 11:56:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=b5QJ6mFzYrEQIiVxnGBDV2zrjBOTs9B6Bo9G6VRNyQA=; b=nGxKbhIm4fCbpDIa1uapMN9ulkB7kl7/v0x2t/5GBzqYQzqcL9+REAs5Vhovzc6Kt0oUhQZVFNP6DH0/Gm9MTQZYPyMzMBmq83lawtt7HlnCz0o2NmIxCRK9Ijjq2pm4iLYB5fDmYWtzZEsq9WBPW9hFz2+cenpxazsmSTu96v8= Received: from HE1PR04MB3212.eurprd04.prod.outlook.com (10.170.253.152) by HE1PR04MB1081.eurprd04.prod.outlook.com (10.162.26.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.609.10; Fri, 23 Mar 2018 15:56:24 +0000 Received: from HE1PR04MB3212.eurprd04.prod.outlook.com ([fe80::f883:80a3:fbf3:3d70]) by HE1PR04MB3212.eurprd04.prod.outlook.com ([fe80::f883:80a3:fbf3:3d70%13]) with mapi id 15.20.0588.017; Fri, 23 Mar 2018 15:56:24 +0000 From: Ioana Ciornei To: Greg KH CC: Laurentiu Tudor , "linux-kernel@vger.kernel.org" , "stuyoder@gmail.com" , Ruxandra Ioana Ciocoi Radulescu , "arnd@arndb.de" , Razvan Stefanescu , Roy Pledge Subject: RE: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support Thread-Topic: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support Thread-Index: AQHTwr0rRbeSymdCeEiXdPiYqeyzd6Pd9tsAgAABPBA= Date: Fri, 23 Mar 2018 15:56:24 +0000 Message-ID: References: <20180323154654.GA382@kroah.com> In-Reply-To: <20180323154654.GA382@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [86.34.165.90] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;HE1PR04MB1081;7:D1W2l2hJ8ivvIgWMQCZC1K8HOQpdSz0T/943U5xrocLWRCLxxCp8/70zZAth6sAvETOz/eQMQXRDo2hq9MlOkOuV47bIm9wIOz2iMp9PbS5NnEUGa7vhNBcc1gWs8MnK2vcDUGQwLyDMIGainh9TUb9Og3ArUljl4PysCc4AqsGmwkmEd2rRKqDHCHaua/hDob8NW2/g2xlLTl7x3TxSsSlRFpZCLjYb+dbhAha3YvyuuLCYreduCTF2ddUZYLR0 x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5e84a809-c5b3-4aa5-ea1f-08d590d6a14c x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:HE1PR04MB1081; x-ms-traffictypediagnostic: HE1PR04MB1081: authentication-results: spf=none (sender IP is ) smtp.mailfrom=ioana.ciornei@nxp.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501327)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041310)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(6072148)(201708071742011);SRVR:HE1PR04MB1081;BCL:0;PCL:0;RULEID:;SRVR:HE1PR04MB1081; x-forefront-prvs: 0620CADDF3 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(366004)(396003)(39380400002)(376002)(346002)(189003)(199004)(229853002)(478600001)(86362001)(106356001)(99286004)(68736007)(54906003)(105586002)(53936002)(66066001)(186003)(102836004)(14454004)(11346002)(59450400001)(446003)(316002)(6506007)(26005)(6116002)(2906002)(76176011)(5660300001)(39060400002)(25786009)(7696005)(4326008)(7736002)(305945005)(6916009)(74316002)(97736004)(8676002)(5250100002)(33656002)(55016002)(3846002)(6246003)(6436002)(2900100001)(81156014)(3660700001)(81166006)(3280700002)(8936002)(9686003);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR04MB1081;H:HE1PR04MB3212.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: gzSsOGEVBEavNGYkdm/8LyohprP+6aakRLABLdAfTVSYFqYw+E/6HiC8FYdH72VS7yAvVWVg5Ep4dthBVdnXs+qghisDP8TqMY+IBK4VjTdBhBcS09CQEoXzm1eU2aE5qERg4hUNtDZMnJWG7xdGJjFBzr/npEgVZ3HEGSBbb/mMAMpjMn0bcXwp7+4X9e9VV7I1VwXTy10QPCFv0veH8KjhQyurq5UpcvYRmrZM8bK+LdiiX4hFX6FZsOLK4S3LO3T923fkD6C43fY5F82zCvByMqo/3LxbwTs3iJooF3SEmSBqFTUGq7YCrnwPCw+MSK3y/Pu0CQAglVe3rYVgFw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e84a809-c5b3-4aa5-ea1f-08d590d6a14c X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2018 15:56:24.4960 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB1081 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >=20 > On Fri, Mar 23, 2018 at 10:38:56AM -0500, Ioana Ciornei wrote: > > +#include "fsl-mc-private.h" > > + > > +#define FSL_MC_BUS_MAX_MINORS 1 >=20 > As you only need/want one character device here, why not just use the mis= c > device api? It's much simpler, and handles all of the housekeeping for y= ou > correctly. It also means I don't have to audit all of your chardev code = to verify it > is correct :) I have considered the misc device api but the fsl-mc bus, since it is a pla= tform driver, is probing before the misc char driver. Ioana >=20 > And it will save you lines-of-code, always a good thing. >=20 > thanks, >=20 > greg k-h