Received: by 10.213.65.68 with SMTP id h4csp523204imn; Fri, 23 Mar 2018 09:33:54 -0700 (PDT) X-Google-Smtp-Source: AG47ELstwG+pV2bNzJiegSyZP+rLolI0lDv6KNGg/Ky6jz+0S//z7JeKLElldnD+OzTzI0Beyu03 X-Received: by 2002:a17:902:bb81:: with SMTP id m1-v6mr29484936pls.71.1521822834460; Fri, 23 Mar 2018 09:33:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521822834; cv=none; d=google.com; s=arc-20160816; b=IMve9njHHfrFUnTCNvekfPDU9ajNo+wPxeBltips641PIXta1b3ciPpgGBXKI08ycz hkQ3NWF/oaRE5x2fbZU8mu9uojZBEIlznKifpN2UDAW/oWS6Ok7pGyA6JBwfFX7WgWkH HL+/qCRHy3djIBe53YMXtDU/O4uT97ISBDgAZv470QQxE4tsIVFJ1Yx0H6jgS6OG8kzN XS52/8EYM8vU0zr7GBZppaI6y6DQCAJn3sV1HIPpJlo/qHYzOB4dbzEvZQLjTSPmGkQU SBKvd8ckS0VB2/MLAiJWQlog6FnPNnuJy+tqZbdrhB/pLCBjFKMiwgjnOJJ607O2Qw1H W2dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=X8h0zNNp7rhwIIH4ztmABkYISQxn41R2G67A27WDY7M=; b=UNJ6DDFeF7uKCjYH8PDoP7asvGxMScjKounXPTae+F9g4BgWXAaPzMWQSbtmndAt9h 7UQYYCWhOzx0Pkpvd/BlzKJpHuBC8FSKCsrnD+N7P1kBO5IuBFmqflNMG7jY86wTdxsQ nwbjy850VSM2iYWgmdMq/Dqgh4LWt4Cgh+HR5fgHFzhMBEKiPDrbLNs5LLEJfgIwid30 4IPE+7TckqPxfPoAyby1jeA/oh1Q9wBSouwXjUx2LIfIQ/QjuvNWuisZqFGcq/UPUTM0 X1XKMDz+QbyzavpN8xRfRsCkTR6yOSxyKzMEDMi2JRjgGdk1fCIofZpdoNVs7LDJYktV tA4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vSPLyIU1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o5si6197511pgp.16.2018.03.23.09.33.39; Fri, 23 Mar 2018 09:33:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vSPLyIU1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752223AbeCWQcl (ORCPT + 99 others); Fri, 23 Mar 2018 12:32:41 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:45945 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751479AbeCWQci (ORCPT ); Fri, 23 Mar 2018 12:32:38 -0400 Received: by mail-qk0-f193.google.com with SMTP id s9so13481739qke.12; Fri, 23 Mar 2018 09:32:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=X8h0zNNp7rhwIIH4ztmABkYISQxn41R2G67A27WDY7M=; b=vSPLyIU1wr1za7qMQp80mtK02r1qTYRk4GlN8/vWVWNCohTNydGpaKp0nIdBCWxCIx Tzr9wOyYSCBCw+Mbh9Czmy7DsRfz4gZnSfIijZiKNtYbW9zMa6XWbhAln5a88/h2EXy+ 5jNECSUhxB4rT6EDqlxYqeC0ebCywgikjgdCpOO46F8mzGVVrgD0k3RV6dyr3CBa2kuv VXnC+9apX3v5ffL7v6s3wzBBtRa5sLJEzDdnTmnNIGjmbHCyUZ+lxlFRFvtcJmjh2eYX IslL7vZMOQ2YMatUmcvzFj96qPQ3sc1vAGGQ4ueqMViSyUIDTMANQdXmtGtkdW4bxDU/ vdZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=X8h0zNNp7rhwIIH4ztmABkYISQxn41R2G67A27WDY7M=; b=cb8lXU7QWao1fgiHMFlFO5HA+v/JcOr4zTdxAwMP3/cGtTeoaVU2q46se6s7lbSg5V ni2+35Ui/SpB+ehFVsLXRc4gSiNT/Lx6y5ASzdAgoAxf3YEPfblgxPQ7HJZJGAXj3Yp8 nsujoJG0ejLdSN4Ngq6eui5GEpkzf7eA43eBHCaL7h8OZhxQJYxyq3mFV24/BdpwSo8N mGDmAmkZFDn7jqo6eqTEwFFzcWaOS34EAg/t1RRZLy9iWwYPlrlOAmBg2sK2YiEXaFzv 8QUbC7QY3ILSe8s7wD9Nh+i86Y+Wp2Vtst+kQaIIJM6eKUx6Wfw77Duj1jPuJ31dQcKN Is0A== X-Gm-Message-State: AElRT7EtF0yp9+z7HWY/VDpBLWY86CrwkCOx3aY9k5+zmHVAZn1PCZZF HsPLnMkNzQTheqgid0DFe9jH6Fx1w+dQmde5o18= X-Received: by 10.55.245.14 with SMTP id l14mr42598363qkk.301.1521822758096; Fri, 23 Mar 2018 09:32:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.137.74 with HTTP; Fri, 23 Mar 2018 09:32:37 -0700 (PDT) In-Reply-To: References: <20180321165848.89751-1-swboyd@chromium.org> <20180321165848.89751-4-swboyd@chromium.org> <97380342-c3aa-5d34-7b22-f6ebbab4bafe@codeaurora.org> <1521804964.23017.96.camel@linux.intel.com> <152182210780.178046.13284917877743312593@swboyd.mtv.corp.google.com> From: Andy Shevchenko Date: Fri, 23 Mar 2018 18:32:37 +0200 Message-ID: Subject: Re: [PATCH v3 3/3] pinctrl: qcom: Don't allow protected pins to be requested To: Stephen Boyd Cc: Andy Shevchenko , Linus Walleij , Timur Tabi , Stephen Boyd , Linux Kernel Mailing List , linux-arm Mailing List , devicetree , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Grant Likely , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 23, 2018 at 6:31 PM, Andy Shevchenko wrote: > On Fri, Mar 23, 2018 at 6:21 PM, Stephen Boyd wrote: > >> bitmap_zero(chip->valid_mask, max_gpios); >> for (i = 0; i < len; i++) >> set_bit(tmp[i], chip->valid_mask); > > Looking to this code I just realized it would be nice to have > > {of,device}_property_read_bitmask() where bitmask_parse() is called. > > Since it related to change a binding, I would really take couple of > days to hear other opinions. > > In the above case, you need to supply a string, like > > "1-5,16,18,25" s/bitmask/bitmap/g -- With Best Regards, Andy Shevchenko