Received: by 10.213.65.68 with SMTP id h4csp575729imn; Fri, 23 Mar 2018 10:43:21 -0700 (PDT) X-Google-Smtp-Source: AG47ELsl/WUger5JdMOLmapVML+9T+H4Ue93PzbAvKco/l2JJaqVY3wiSBIgXsnbvSs+fayDOSwu X-Received: by 2002:a17:902:86:: with SMTP id a6-v6mr3801293pla.298.1521827001385; Fri, 23 Mar 2018 10:43:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521827001; cv=none; d=google.com; s=arc-20160816; b=GCHXfEKdPaKsoL2y+ofw0Xp0xQyo71txfuS4GffBOuJiq74kgR8fAvU1EykvMeOOB+ CEAuR/5vL45ZK53a0+0VZ/ry4gY937eVFBM9JfOP4hbDWGscmzC7Ws9KRHQn7mSCuuIp wWbPWYiBWq4KEniJoXEfLVholRiIbaBkdoakgPpTo/HnsoOREGHl3dGaTHk38D4vCi8o 5D0Yz4O0aLYjmLzB5Fg/XlJX2oiX4RZAFhsjxc4VsW6lZaISAWRDrveJKLDh9otlpTat Nwyo/rmCdRP6WBaeCosD7CYWDJnofK0VEIzw5vo2dX79aZBFmmqWYT+dhAhy7SL1vJvB 7I8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:to:from:dkim-signature :arc-authentication-results; bh=+IYB+Ci1nPnUh+Zv31sFcRKkpzHj9/gNwsiqvtDxxok=; b=pnRNCtQO0Fpk8Bu1LEV5lpz/rUeYFfwNvOJntkjbHMJ9gPuGhdFuwWMRdydCePzvdk jeivAOPTol4S0eO1qOgrtezmBdiGAnZf8EbvHZUWHft9osaGb8C2l+ICOEPnVVBxqaOn 7HqnlCSjrzJWl+mLx9N1aw1VnxWUEYTiKUiPSBe4Dcm4eZvDCvVptPISgg/Z1OrrhE7i DwMSXE+hpemxSgtla3awJLLbpfMBYb028YZ9DyGcYHLuo4dA0rYtm4DZm7btwj5Zy3tb s0q0K/r7e5dMQy5lhSbvHqvshQNvpPZjkSBE727cUuObSA4PJerUlxha6Lc5JRqDQoM0 NrWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=ISVKZNwq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u19si5854498pgv.798.2018.03.23.10.43.06; Fri, 23 Mar 2018 10:43:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=ISVKZNwq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752007AbeCWRmJ (ORCPT + 99 others); Fri, 23 Mar 2018 13:42:09 -0400 Received: from mail-by2nam03on0133.outbound.protection.outlook.com ([104.47.42.133]:30048 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751691AbeCWRmH (ORCPT ); Fri, 23 Mar 2018 13:42:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+IYB+Ci1nPnUh+Zv31sFcRKkpzHj9/gNwsiqvtDxxok=; b=ISVKZNwqtXBUoMJLrSsIf1iXvs6xwpfC3SM09B2WwBojUDv5D3+38AM3DBus8xq4z9NB53Tgg/KZ6bZRnponclCxyRBNOefLognYLt6DX1/J6PlcDhi56eCb4Dcp9qXCbRHG0xaV7yUn2qHHZRhgZRI+HOkL3a6oJN0iYA2IsgA= Received: from MWHPR2101MB0729.namprd21.prod.outlook.com (10.167.161.167) by MWHPR2101MB0874.namprd21.prod.outlook.com (10.167.237.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.631.4; Fri, 23 Mar 2018 17:42:05 +0000 Received: from MWHPR2101MB0729.namprd21.prod.outlook.com ([fe80::2944:e336:d611:1ee9]) by MWHPR2101MB0729.namprd21.prod.outlook.com ([fe80::2944:e336:d611:1ee9%5]) with mapi id 15.20.0631.007; Fri, 23 Mar 2018 17:42:05 +0000 From: Long Li To: KY Srinivasan , Haiyang Zhang , Long Li , Stephen Hemminger , "James E . J . Bottomley" , "Martin K . Petersen" , "devel@linuxdriverproject.org" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 2/3] Netvsc: Use the vmbus functiton to calculate ring buffer percentage Thread-Topic: [PATCH 2/3] Netvsc: Use the vmbus functiton to calculate ring buffer percentage Thread-Index: AQHTwjxH0m8zl19MNkGQP7G3JLrrTqPd6ueAgAADQwCAACmY8A== Date: Fri, 23 Mar 2018 17:42:04 +0000 Message-ID: References: <20180323001538.31876-1-longli@linuxonhyperv.com> <20180323001538.31876-2-longli@linuxonhyperv.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [2001:4898:80e8:8::2e0] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MWHPR2101MB0874;7:veLWxZ9c8w04WgCIB0v5JBK2HlTAX9M4QTKRohiQhPuypYlBpOK8bj8jumVjkWwpk3ObFimHtaofTTO+QYLqA9+uToIbNxGitJuQ0zTvVeBajp9ABDw4Elxv0Rm4gFUX967gIJwOM8at5yPHdEqew6PoB4tV8jCSCwnYfU/wmKIcP7DOnnuJjPdv2fIT/LIbLZHdqbxUDDsPZr9kM2eg2DZXQY9JstnBjV+8zW3kBs0LfPrGYpiNPkOz1+xvllSI;20:j5vB3pD7mHPnKMNTKXtSZ3jN2MvsFe3ULw4GiKWow14LbugYKbsgrKpymetphu2lZ+ok1QrMBT93MYTUG7LlS1nqlo64CfrcWQoTpVy7WJoWRw2hvm22AtyA56KJobzXrsj0KhJH9vk9+3Q6WEJ3vE4AMefP6GYgjONyzEEbKWI= x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2e9c8e17-b7e2-41d9-c8db-08d590e56493 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603328)(7193020);SRVR:MWHPR2101MB0874; x-ms-traffictypediagnostic: MWHPR2101MB0874: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(9452136761055)(146099531331640); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501327)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(61426038)(61427038)(6041310)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(6072148)(201708071742011);SRVR:MWHPR2101MB0874;BCL:0;PCL:0;RULEID:;SRVR:MWHPR2101MB0874; x-forefront-prvs: 0620CADDF3 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(346002)(366004)(39380400002)(376002)(39860400002)(199004)(189003)(13464003)(81156014)(305945005)(446003)(93886005)(68736007)(106356001)(2201001)(74316002)(5660300001)(86612001)(7736002)(478600001)(2900100001)(10290500003)(3280700002)(81166006)(11346002)(8936002)(14454004)(316002)(110136005)(229853002)(8676002)(99286004)(575784001)(22452003)(86362001)(6506007)(9686003)(7696005)(8990500004)(55016002)(53546011)(53936002)(6116002)(2906002)(10090500001)(105586002)(3660700001)(25786009)(97736004)(76176011)(33656002)(5250100002)(102836004)(2501003)(6436002)(6346003)(6246003)(1511001)(46003);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR2101MB0874;H:MWHPR2101MB0729.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=longli@microsoft.com; x-microsoft-antispam-message-info: AtGQbdder+nRojKsDhk4u585OJP89tYi5BV92r/PGhA3p8GxJUZVjpW80cvQLGTcg6eM4pGd+t71xc47uIUo8VQoqOGCxUmrfw3/fLY0DmnZduIWsDM9t5KNVZlSAcNVlHVlU4a4XT3wBdz5sxgO2p0KgmHtraShLDjLucfXyIpD/lhB4tbo8zUIJ6MKZGrovYmuPr1sADje1JJmbF3YUzc+f0DAARdlVsvzfHjl5k9SASHKVtTR1hGv+jSkwiJHWpBA+Z3fXBG9ZpeRezWfsgO0mgoGlJXJJy6rNnnTvHvHbvdvUwMTLTvbfEJML6OdJaDgTj3D9j5cJncdEKfkoQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e9c8e17-b7e2-41d9-c8db-08d590e56493 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2018 17:42:04.9718 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR2101MB0874 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Subject: RE: [PATCH 2/3] Netvsc: Use the vmbus functiton to calculate rin= g > buffer percentage >=20 >=20 >=20 > > -----Original Message----- > > From: Haiyang Zhang > > Sent: Friday, March 23, 2018 8:01 AM > > To: Long Li ; KY Srinivasan > > ; Stephen Hemminger ; > James > > E . J . Bottomley ; Martin K . Petersen > > ; devel@linuxdriverproject.org; linux- > > scsi@vger.kernel.org; linux-kernel@vger.kernel.org > > Cc: Long Li > > Subject: RE: [PATCH 2/3] Netvsc: Use the vmbus functiton to calculate > > ring buffer percentage > > > > > > > > > -----Original Message----- > > > From: Long Li > > > Sent: Thursday, March 22, 2018 8:16 PM > > > To: KY Srinivasan ; Haiyang Zhang > > > ; Stephen Hemminger > > ; > > > James E . J . Bottomley ; Martin K . Petersen > > > ; devel@linuxdriverproject.org; linux- > > > scsi@vger.kernel.org; linux-kernel@vger.kernel.org > > > Cc: Long Li > > > Subject: [PATCH 2/3] Netvsc: Use the vmbus functiton to calculate > > > ring > > buffer > > > percentage > > > > > > From: Long Li > > > > > > In Vmbus, we have defined a function to calculate available ring > > > buffer percentage to write. > > > > > > Use that function and remove duplicate netvsc code. > > > > > > Signed-off-by: Long Li > > > --- > > > drivers/net/hyperv/netvsc.c | 17 +++-------------- > > > drivers/net/hyperv/netvsc_drv.c | 3 --- > > > 2 files changed, 3 insertions(+), 17 deletions(-) >=20 > Why is the patch being sent to the scsi list and not to the network maili= ng list > and Dave Miller. I will re-send the patch. >=20 > K. Y > > > > > > diff --git a/drivers/net/hyperv/netvsc.c > > > b/drivers/net/hyperv/netvsc.c > > index > > > 0265d703eb03..8af0069e4d8c 100644 > > > --- a/drivers/net/hyperv/netvsc.c > > > +++ b/drivers/net/hyperv/netvsc.c > > > @@ -31,7 +31,6 @@ > > > #include > > > #include > > > #include > > > -#include > > > > > > #include > > > > > > @@ -590,17 +589,6 @@ void netvsc_device_remove(struct hv_device > > *device) > > > #define RING_AVAIL_PERCENT_HIWATER 20 #define > > > RING_AVAIL_PERCENT_LOWATER 10 > > > > > > -/* > > > - * Get the percentage of available bytes to write in the ring. > > > - * The return value is in range from 0 to 100. > > > - */ > > > -static u32 hv_ringbuf_avail_percent(const struct > > > hv_ring_buffer_info > > > *ring_info) -{ > > > - u32 avail_write =3D hv_get_bytes_to_write(ring_info); > > > - > > > - return reciprocal_divide(avail_write * 100, netvsc_ring_reciprocal= ); > > > -} > > > - > > > static inline void netvsc_free_send_slot(struct netvsc_device > > *net_device, > > > u32 index) > > > { > > > @@ -649,7 +637,8 @@ static void netvsc_send_tx_complete(struct > > > netvsc_device *net_device, > > > wake_up(&net_device->wait_drain); > > > > > > if (netif_tx_queue_stopped(netdev_get_tx_queue(ndev, q_idx)) > > && > > > - (hv_ringbuf_avail_percent(&channel->outbound) > > > > RING_AVAIL_PERCENT_HIWATER || > > > + (hv_get_avail_to_write_percent(&channel->outbound) > > > > + RING_AVAIL_PERCENT_HIWATER || > > > queue_sends < 1)) { > > > netif_tx_wake_queue(netdev_get_tx_queue(ndev, q_idx)); > > > ndev_ctx->eth_stats.wake_queue++; @@ -757,7 +746,7 @@ > static > > >inline int netvsc_send_pkt( > > > struct netdev_queue *txq =3D netdev_get_tx_queue(ndev, packet- > > >q_idx); > > > u64 req_id; > > > int ret; > > > - u32 ring_avail =3D hv_ringbuf_avail_percent(&out_channel- > > >outbound); > > > + u32 ring_avail =3D > > > +hv_get_avail_to_write_percent(&out_channel->outbound); > > > > > > nvmsg.hdr.msg_type =3D NVSP_MSG1_TYPE_SEND_RNDIS_PKT; > > > if (skb) > > > diff --git a/drivers/net/hyperv/netvsc_drv.c > > b/drivers/net/hyperv/netvsc_drv.c > > > index faea0be18924..b0b1c2fd2b7b 100644 > > > --- a/drivers/net/hyperv/netvsc_drv.c > > > +++ b/drivers/net/hyperv/netvsc_drv.c > > > @@ -35,7 +35,6 @@ > > > #include > > > #include > > > #include > > > -#include > > > > > > #include > > > #include > > > @@ -55,7 +54,6 @@ static unsigned int ring_size __ro_after_init =3D > > > 128; module_param(ring_size, uint, S_IRUGO); > > MODULE_PARM_DESC(ring_size, > > > "Ring buffer size (# of pages)"); unsigned int netvsc_ring_bytes > > __ro_after_init; > > > -struct reciprocal_value netvsc_ring_reciprocal __ro_after_init; > > > > > > static const u32 default_msg =3D NETIF_MSG_DRV | NETIF_MSG_PROBE | > > > NETIF_MSG_LINK | NETIF_MSG_IFUP | @@ - > 2186,7 +2184,6 @@ static > > > int __init netvsc_drv_init(void) > > > ring_size); > > > } > > > netvsc_ring_bytes =3D ring_size * PAGE_SIZE; > > > - netvsc_ring_reciprocal =3D reciprocal_value(netvsc_ring_bytes); > > > > > > ret =3D vmbus_driver_register(&netvsc_drv); > > > if (ret) > > > -- > > > > > > Please also remove netvsc_ring_reciprocal from hyperv_net.h Thanks. I will fix it and re-send the patch. > > > > Reviewed-by: Haiyang Zhang